From 7ccabe59bb6fc5d3cd143ee92d1221e7bad32797 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Thu, 5 Oct 2023 11:22:11 -0400 Subject: [PATCH 1/4] Bump up compatibility-integration-test runner --- .github/workflows/test-integrations.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-integrations.yml b/.github/workflows/test-integrations.yml index a3521dee753..9fac881086f 100644 --- a/.github/workflows/test-integrations.yml +++ b/.github/workflows/test-integrations.yml @@ -375,7 +375,7 @@ jobs: run: datadog-ci junit upload --service "$GITHUB_REPOSITORY" $TEST_RESULTS_DIR/results.xml compatibility-integration-test: - runs-on: ${{ fromJSON(needs.setup.outputs.compute-large) }} + runs-on: ${{ fromJSON(needs.setup.outputs.compute-xl) }} needs: - setup - dev-build From 3962af6fb8fe4a5d0faef04dc646b19ff434b822 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Thu, 5 Oct 2023 11:24:29 -0400 Subject: [PATCH 2/4] No more verbose --- .github/workflows/test-integrations.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-integrations.yml b/.github/workflows/test-integrations.yml index 9fac881086f..6d6310d9d26 100644 --- a/.github/workflows/test-integrations.yml +++ b/.github/workflows/test-integrations.yml @@ -32,14 +32,14 @@ concurrency: jobs: conditional-skip: - runs-on: ubuntu-latest + runs-on: ubuntu-latest name: Get files changed and conditionally skip CI outputs: skip-ci: ${{ steps.read-files.outputs.skip-ci }} steps: - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 with: - fetch-depth: 0 + fetch-depth: 0 - name: Get changed files id: read-files run: ./.github/scripts/filter_changed_files_go_test.sh @@ -262,7 +262,7 @@ jobs: # multiplied by 8 based on these values: # envoy-version: ["1.24.10", "1.25.9", "1.26.4", "1.27.0"] # xds-target: ["server", "client"] - TOTAL_RUNNERS: 4 + TOTAL_RUNNERS: 4 JQ_SLICER: '[ inputs ] | [_nwise(length / $runnercount | floor)]' run: | NUM_RUNNERS=$TOTAL_RUNNERS @@ -431,9 +431,9 @@ jobs: docker run --rm ${{ env.CONSUL_LATEST_IMAGE_NAME }}:local consul version go run gotest.tools/gotestsum@v${{env.GOTESTSUM_VERSION}} \ --raw-command \ - --format=standard-verbose \ + --format=pkgname-and-test-fails \ --debug \ - --rerun-fails=3 \ + --rerun-fails=2 \ -- \ go test \ -tags "${{ env.GOTAGS }}" \ @@ -487,7 +487,7 @@ jobs: test-integrations-success: - needs: + needs: - conditional-skip - setup - dev-build From c53bb7af45a909e49b0c3574e3ab412a4d705fb5 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Thu, 5 Oct 2023 11:55:46 -0400 Subject: [PATCH 3/4] Add flags back --- .github/workflows/test-integrations.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-integrations.yml b/.github/workflows/test-integrations.yml index 6d6310d9d26..4212bce4f1d 100644 --- a/.github/workflows/test-integrations.yml +++ b/.github/workflows/test-integrations.yml @@ -375,7 +375,7 @@ jobs: run: datadog-ci junit upload --service "$GITHUB_REPOSITORY" $TEST_RESULTS_DIR/results.xml compatibility-integration-test: - runs-on: ${{ fromJSON(needs.setup.outputs.compute-xl) }} + runs-on: ${{ fromJSON(needs.setup.outputs.compute-xl) }} # NOTE: do not change without tuning the -p and -parallel flags in go test. needs: - setup - dev-build @@ -436,6 +436,8 @@ jobs: --rerun-fails=2 \ -- \ go test \ + -p=6 \ + -parallel=4 \ -tags "${{ env.GOTAGS }}" \ -timeout=30m \ -json \ From 7265f25dc94482110b891f9cfd0941d827f76c7f Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Thu, 5 Oct 2023 12:35:24 -0400 Subject: [PATCH 4/4] back to 3 --- .github/workflows/test-integrations.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-integrations.yml b/.github/workflows/test-integrations.yml index 4212bce4f1d..beb832c3296 100644 --- a/.github/workflows/test-integrations.yml +++ b/.github/workflows/test-integrations.yml @@ -433,7 +433,7 @@ jobs: --raw-command \ --format=pkgname-and-test-fails \ --debug \ - --rerun-fails=2 \ + --rerun-fails=3 \ -- \ go test \ -p=6 \