From 7bd75e1c164b8d8c4e5a9c27e5febde2efb5e6c5 Mon Sep 17 00:00:00 2001 From: Simon Jakobi Date: Tue, 2 Nov 2021 13:47:06 +0100 Subject: [PATCH 1/3] Fix no-text CI with GHC 7.10.3 This job was reporting linker issues due to https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/123. --- .github/workflows/no-text.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/no-text.yml b/.github/workflows/no-text.yml index cccfba05..30cf3012 100644 --- a/.github/workflows/no-text.yml +++ b/.github/workflows/no-text.yml @@ -33,4 +33,6 @@ jobs: path: ${{ steps.setup-haskell-cabal.outputs.cabal-store }} key: ${{ runner.os }}-${{ matrix.ghc }} - name: Build - run: cabal build -f-text prettyprinter:prettyprinter + # -optl-no-pie is a workaround for an issue with GHC 7.10.3: + # https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/123 + run: cabal build --ghc-option=-optl-no-pie -f-text prettyprinter:prettyprinter From 88361f954f5b7ce310c26ac262bfdfc4258e75b5 Mon Sep 17 00:00:00 2001 From: Simon Jakobi Date: Tue, 2 Nov 2021 14:01:44 +0100 Subject: [PATCH 2/3] Try passing -optc-no-pie too --- .github/workflows/no-text.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/no-text.yml b/.github/workflows/no-text.yml index 30cf3012..480cb6fe 100644 --- a/.github/workflows/no-text.yml +++ b/.github/workflows/no-text.yml @@ -35,4 +35,4 @@ jobs: - name: Build # -optl-no-pie is a workaround for an issue with GHC 7.10.3: # https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/123 - run: cabal build --ghc-option=-optl-no-pie -f-text prettyprinter:prettyprinter + run: cabal build --ghc-option=-optl-no-pie --ghc-option=-optc-no-pie -f-text prettyprinter:prettyprinter From 423b6300b16ffe4f1b299ce78d9df8a64ae98947 Mon Sep 17 00:00:00 2001 From: Simon Jakobi Date: Tue, 2 Nov 2021 14:11:15 +0100 Subject: [PATCH 3/3] Revert "Try passing -optc-no-pie too" This reverts commit 88361f954f5b7ce310c26ac262bfdfc4258e75b5. --- .github/workflows/no-text.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/no-text.yml b/.github/workflows/no-text.yml index 480cb6fe..30cf3012 100644 --- a/.github/workflows/no-text.yml +++ b/.github/workflows/no-text.yml @@ -35,4 +35,4 @@ jobs: - name: Build # -optl-no-pie is a workaround for an issue with GHC 7.10.3: # https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/123 - run: cabal build --ghc-option=-optl-no-pie --ghc-option=-optc-no-pie -f-text prettyprinter:prettyprinter + run: cabal build --ghc-option=-optl-no-pie -f-text prettyprinter:prettyprinter