From f4b32240dc8b6861c7d1acb52796957fcb51f783 Mon Sep 17 00:00:00 2001 From: Abhijit L Date: Tue, 15 Jul 2025 09:18:42 +0530 Subject: [PATCH 1/4] fix: update lint command. --- Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index e2df78c..a1472aa 100644 --- a/Makefile +++ b/Makefile @@ -13,9 +13,8 @@ format: poetry run ruff --select I --fix . lint: - poetry run mypy --exclude tests javelin_sdk/ - poetry run black . --check - poetry run ruff javelin_sdk/ + poetry run black . + poetry run flake8 . --config=.flake8 --output-file=lint-report.json test: poetry run pytest tests From 0cd9afd57780fa26df2da90bb1ec8f6935a51a11 Mon Sep 17 00:00:00 2001 From: Abhijit L Date: Tue, 15 Jul 2025 09:25:19 +0530 Subject: [PATCH 2/4] fix: update lint command --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index a1472aa..bc4e7c4 100644 --- a/Makefile +++ b/Makefile @@ -10,7 +10,6 @@ coverage: format: poetry run black . - poetry run ruff --select I --fix . lint: poetry run black . From dffad7eb8584392adb44a6015eae1e8a9bbce5fd Mon Sep 17 00:00:00 2001 From: Abhijit L Date: Tue, 15 Jul 2025 09:29:31 +0530 Subject: [PATCH 3/4] fix: update dependencies --- pyproject.toml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index a270327..48e3b17 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -43,8 +43,7 @@ pytest-mock = "^3.10.0" [tool.poetry.group.dev.dependencies] black = "24.3.0" -ruff = "^0.0.265" -mypy = "^1.2.0" +flake8 = "^7.3.0" pre-commit = "^3.3.1" mkdocs = "^1.4.3" mkdocstrings = {version = "0.21.2", extras = ["python"]} From 95dc06b4b8009c00b986ac95aab287f41329642b Mon Sep 17 00:00:00 2001 From: Abhijit L Date: Wed, 16 Jul 2025 08:25:45 +0530 Subject: [PATCH 4/4] fix: remove nil fields from data --- javelin_sdk/services/gateway_service.py | 12 ++++++++++-- javelin_sdk/services/provider_service.py | 8 ++++++-- javelin_sdk/services/route_service.py | 12 ++++++++++-- javelin_sdk/services/secret_service.py | 4 ++-- javelin_sdk/services/template_service.py | 20 ++++++++++++++++---- 5 files changed, 44 insertions(+), 12 deletions(-) diff --git a/javelin_sdk/services/gateway_service.py b/javelin_sdk/services/gateway_service.py index 7059370..5c1143b 100644 --- a/javelin_sdk/services/gateway_service.py +++ b/javelin_sdk/services/gateway_service.py @@ -53,7 +53,11 @@ def create_gateway(self, gateway: Gateway) -> str: if gateway.name: self._validate_gateway_name(gateway.name) response = self.client._send_request_sync( - Request(method=HttpMethod.POST, gateway=gateway.name, data=gateway.dict()) + Request( + method=HttpMethod.POST, + gateway=gateway.name, + data=gateway.dict(exclude_none=True), + ) ) return self._process_gateway_response_ok(response) @@ -61,7 +65,11 @@ async def acreate_gateway(self, gateway: Gateway) -> str: if gateway.name: self._validate_gateway_name(gateway.name) response = await self.client._send_request_async( - Request(method=HttpMethod.POST, gateway=gateway.name, data=gateway.dict()) + Request( + method=HttpMethod.POST, + gateway=gateway.name, + data=gateway.dict(exclude_none=True), + ) ) return self._process_gateway_response_ok(response) diff --git a/javelin_sdk/services/provider_service.py b/javelin_sdk/services/provider_service.py index bfc1a13..467c8ee 100644 --- a/javelin_sdk/services/provider_service.py +++ b/javelin_sdk/services/provider_service.py @@ -65,7 +65,9 @@ def create_provider(self, provider) -> str: self._validate_provider_name(provider.name) response = self.client._send_request_sync( Request( - method=HttpMethod.POST, provider=provider.name, data=provider.dict() + method=HttpMethod.POST, + provider=provider.name, + data=provider.dict(exclude_none=True), ) ) return self._process_provider_response_ok(response) @@ -78,7 +80,9 @@ async def acreate_provider(self, provider) -> str: self._validate_provider_name(provider.name) response = await self.client._send_request_async( Request( - method=HttpMethod.POST, provider=provider.name, data=provider.dict() + method=HttpMethod.POST, + provider=provider.name, + data=provider.dict(exclude_none=True), ) ) return self._process_provider_response_ok(response) diff --git a/javelin_sdk/services/route_service.py b/javelin_sdk/services/route_service.py index e7f77ae..d9ec620 100644 --- a/javelin_sdk/services/route_service.py +++ b/javelin_sdk/services/route_service.py @@ -67,7 +67,11 @@ def create_route(self, route) -> str: route = Route.model_validate(route) self._validate_route_name(route.name) response = self.client._send_request_sync( - Request(method=HttpMethod.POST, route=route.name, data=route.dict()) + Request( + method=HttpMethod.POST, + route=route.name, + data=route.dict(exclude_none=True), + ) ) return self._process_route_response_ok(response) @@ -76,7 +80,11 @@ async def acreate_route(self, route) -> str: route = Route.model_validate(route) self._validate_route_name(route.name) response = await self.client._send_request_async( - Request(method=HttpMethod.POST, route=route.name, data=route.dict()) + Request( + method=HttpMethod.POST, + route=route.name, + data=route.dict(exclude_none=True), + ) ) return self._process_route_response_ok(response) diff --git a/javelin_sdk/services/secret_service.py b/javelin_sdk/services/secret_service.py index 636b9e7..e12dbcd 100644 --- a/javelin_sdk/services/secret_service.py +++ b/javelin_sdk/services/secret_service.py @@ -133,7 +133,7 @@ def update_secret(self, secret) -> str: Request( method=HttpMethod.PUT, secret=secret.api_key, - data=secret.dict(), + data=secret.dict(exclude_none=True), provider=secret.provider_name, ) ) @@ -172,7 +172,7 @@ async def aupdate_secret(self, secret) -> str: Request( method=HttpMethod.PUT, secret=secret.api_key, - data=secret.dict(), + data=secret.dict(exclude_none=True), provider=secret.provider_name, ) ) diff --git a/javelin_sdk/services/template_service.py b/javelin_sdk/services/template_service.py index 54471b7..bce1349 100644 --- a/javelin_sdk/services/template_service.py +++ b/javelin_sdk/services/template_service.py @@ -44,7 +44,9 @@ def create_template(self, template) -> str: template = Template.model_validate(template) response = self.client._send_request_sync( Request( - method=HttpMethod.POST, template=template.name, data=template.dict() + method=HttpMethod.POST, + template=template.name, + data=template.dict(exclude_none=True), ) ) if template.name: @@ -56,7 +58,9 @@ async def acreate_template(self, template) -> str: template = Template.model_validate(template) response = await self.client._send_request_async( Request( - method=HttpMethod.POST, template=template.name, data=template.dict() + method=HttpMethod.POST, + template=template.name, + data=template.dict(exclude_none=True), ) ) if template.name: @@ -105,7 +109,11 @@ def update_template(self, template) -> str: if not isinstance(template, Template): template = Template.model_validate(template) response = self.client._send_request_sync( - Request(method=HttpMethod.PUT, template=template.name, data=template.dict()) + Request( + method=HttpMethod.PUT, + template=template.name, + data=template.dict(exclude_none=True), + ) ) if template.name: self.reload_data_protection(template.name) @@ -115,7 +123,11 @@ async def aupdate_template(self, template) -> str: if not isinstance(template, Template): template = Template.model_validate(template) response = await self.client._send_request_async( - Request(method=HttpMethod.PUT, template=template.name, data=template.dict()) + Request( + method=HttpMethod.PUT, + template=template.name, + data=template.dict(exclude_none=True), + ) ) if template.name: await self.areload_data_protection(template.name)