Use PHP builtin instead of home grown algorithm.

At least in PHP 8.3, our own implementation fails for encoding query strings from multi dimensional arrays, i.e. whups' search strings with category lists.

Author: ralflang

lib/Horde/Url.php

@@ -70,13 +70,6 @@ class Horde_Url
      */
     public $url;
 
-    /**
-     * Cached parameter list for use in toString().
-     *
-     * @var array
-     */
-    protected $_cache;
-
     /**
      * Constructor.
      *
@@ -168,8 +161,6 @@ public function add($parameters, $value = null)
             }
         }
 
-        unset($this->_cache);
-
         return $this;
     }
 
@@ -191,8 +182,6 @@ public function remove($parameters)
             unset($this->parameters[$parameter]);
         }
 
-        unset($this->_cache);
-
         return $this;
     }
 
@@ -275,8 +264,8 @@ public function toString($raw = false, $full = true)
             }
         }
 
-        if ($params = $this->_getParameters()) {
-            $url .= '?' . implode($raw ? '&' : '&', $params);
+        if ($params = $this->parameters) {
+            $url .= '?' . http_build_query($params, "", $raw ? '&' : '&');
         }
 
         if ($this->anchor) {
@@ -286,33 +275,6 @@ public function toString($raw = false, $full = true)
         return strval($url);
     }
 
-    /**
-     * Return a formatted list of URL parameters.
-     *
-     * @return array  Parameter list.
-     */
-    protected function _getParameters()
-    {
-        if (!isset($this->_cache)) {
-            $params = array();
-
-            foreach ($this->parameters as $p => $v) {
-                if (is_array($v)) {
-                    foreach ($v as $val) {
-                        $params[] = rawurlencode($p) . '[]=' . rawurlencode($val);
-                    }
-                } else {
-                    $params[] = rawurlencode($p) .
-                        (strlen($v) ? ('=' . rawurlencode($v)) : '');
-                }
-            }
-
-            $this->_cache = $params;
-        }
-
-        return $this->_cache;
-    }
-
     /**
      * Creates the full URL string.
      *