[core] Fix quark #42457
Merged
[core] Fix quark #42457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
reviewed
Nov 27, 2025
| quant_state = target_key.split("_", 1)[-1] | ||
| # print(f"full_layer_name: {full_layer_name}") | ||
|
|
||
| sub_module_state = full_layer_name.rsplit(".", 1)[0] + "." + param + "_quantizer" + "." + quant_state |
| EXPECTED_OUTPUTS.add("Today I am in Paris and I am enjoying my day off! The sun is shining, the birds are") | ||
| EXPECTED_OUTPUTS.add("Today I am in Paris and I'm here to tell you about it. It's a beautiful day,") | ||
| EXPECTED_OUTPUTS.add("Today I am in Paris and I am not in Paris at all! I am not in Paris, but") | ||
| EXPECTED_OUTPUTS.add("Today I am in Paris and I am in Paris, but I am not in Paris\nToday I am") |
Member
There was a problem hiding this comment.
any idea why this changed ? the most likely culprit is the dtype we loaded the param but not sure
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
reviewed
Nov 28, 2025
Comment on lines
119
to
124
| converters = [] | ||
| for key in CHECKPOINT_KEYS.keys(): | ||
| converters.append( | ||
| WeightConverter(source_keys=[key], target_keys=key, operations=[QuarkDeserialize(self)]) | ||
| ) | ||
| return converters |
Member
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
Member
|
@bot /style |
Contributor
|
Style fix is beginning .... View the workflow run here. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: quark_integration |
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
* intial * update * add convert * fix * style * rm comment * explain * loop * fix * fix * update * Apply style fixes * fix * style * update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Quark after weight refactor, all tests passing locally