-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Command-a-vision fix #42642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Command-a-vision fix #42642
Conversation
4c93a19 to
2450d3d
Compare
2450d3d to
3066589
Compare
|
Hi @dongluw , thanks for the contribution, indeed there seems to be a flip issue. however how do you obtain the test image above? I'm surprised our tests haven't caught this, it should be all wrong, so a reproducer would help |
|
hey @molbap I saved the this issue only affects generation quality if images are of very high/low aspect ratio |
src/transformers/models/cohere2_vision/image_processing_cohere2_vision_fast.py
Outdated
Show resolved
Hide resolved
src/transformers/models/cohere2_vision/modular_cohere2_vision.py
Outdated
Show resolved
Hide resolved
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2_vision |

What does this PR do?
before fix:
after fix:

Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.