From 93ae22f8e0dfcf05796fce6a458e24b024ab5449 Mon Sep 17 00:00:00 2001 From: Matth_eu Date: Fri, 3 Jan 2014 13:48:34 +0000 Subject: [PATCH 1/2] Neater way to add element attributes --- class.cmb-meta-box.php | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/class.cmb-meta-box.php b/class.cmb-meta-box.php index f5b3af55..75720d3e 100644 --- a/class.cmb-meta-box.php +++ b/class.cmb-meta-box.php @@ -240,27 +240,24 @@ static function layout_fields( array $fields ) { ?> $current_colspan += $field->args['cols']; - $classes = array('field'); - + $classes = array( 'field', get_class($field) ); + if ( ! empty( $field->args['repeatable'] ) ) $classes[] = 'repeatable'; - $classes[] = get_class($field); - - $classes = 'class="' . esc_attr( implode(' ', array_map( 'sanitize_html_class', $classes ) ) ) . '"'; - - $attrs = array(); - + $attrs = array( + sprintf( 'class="%s"', esc_attr( implode(' ', array_map( 'sanitize_html_class', $classes ) ) ) ) + ); + + // Field Repeatable Max. if ( isset( $field->args['repeatable_max'] ) ) - $attrs[] = 'data-rep-max="' . intval( $field->args['repeatable_max'] ) . '"'; - - $attrs = implode( ' ', $attrs ); + $attrs[] = sprintf( 'data-rep-max="%s"', intval( $field->args['repeatable_max'] ) ); ?>
-
> +
> display(); ?>
From c5deae42cf3f93d6e0df787674c70378950ede23 Mon Sep 17 00:00:00 2001 From: Matth_eu Date: Fri, 3 Jan 2014 13:48:56 +0000 Subject: [PATCH 2/2] add field ID as continuer element ID attribute --- class.cmb-meta-box.php | 1 + 1 file changed, 1 insertion(+) diff --git a/class.cmb-meta-box.php b/class.cmb-meta-box.php index 75720d3e..ced2aae6 100644 --- a/class.cmb-meta-box.php +++ b/class.cmb-meta-box.php @@ -246,6 +246,7 @@ static function layout_fields( array $fields ) { ?> $classes[] = 'repeatable'; $attrs = array( + sprintf( 'id="%s"', sanitize_html_class( $field->id ) ), sprintf( 'class="%s"', esc_attr( implode(' ', array_map( 'sanitize_html_class', $classes ) ) ) ) );