From 38864f7976d8f6c9f63306bf07d610adcd41c515 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:01:14 +0300 Subject: [PATCH 1/3] Add new category: INFO --- src/python/review/inspectors/issue.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/python/review/inspectors/issue.py b/src/python/review/inspectors/issue.py index c910bf80..b1b3cf52 100644 --- a/src/python/review/inspectors/issue.py +++ b/src/python/review/inspectors/issue.py @@ -26,6 +26,7 @@ class IssueType(Enum): CLASS_RESPONSE = 'CLASS_RESPONSE' METHOD_NUMBER = 'METHOD_NUMBER' MAINTAINABILITY = 'MAINTAINABILITY' + INFO = 'INFO' # Keys in results dictionary From 70ebe99992bd7d33a82419061766aa31a82e5954 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:01:32 +0300 Subject: [PATCH 2/3] Fix config --- src/python/review/inspectors/flake8/issue_types.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/python/review/inspectors/flake8/issue_types.py b/src/python/review/inspectors/flake8/issue_types.py index 02401f7e..7adf57da 100644 --- a/src/python/review/inspectors/flake8/issue_types.py +++ b/src/python/review/inspectors/flake8/issue_types.py @@ -27,6 +27,10 @@ 'C818': IssueType.CODE_STYLE, 'C819': IssueType.CODE_STYLE, + # flake8-spellcheck + 'SC100': IssueType.INFO, + 'SC200': IssueType.INFO, + # WPS: Naming 'WPS117': IssueType.CODE_STYLE, # Forbid naming variables self, cls, or mcs. 'WPS125': IssueType.ERROR_PRONE, # Forbid variable or module names which shadow builtin names. @@ -71,7 +75,7 @@ 'WPS419': IssueType.ERROR_PRONE, # Forbid multiple returning paths with try / except case. 'WPS424': IssueType.ERROR_PRONE, # Forbid BaseException exception. 'WPS426': IssueType.ERROR_PRONE, # Forbid lambda inside loops. - 'WPS432': IssueType.CODE_STYLE, # Forbid magic numbers. + 'WPS432': IssueType.INFO, # Forbid magic numbers. 'WPS433': IssueType.CODE_STYLE, # Forbid imports nested in functions. 'WPS439': IssueType.ERROR_PRONE, # Forbid Unicode escape sequences in binary strings. 'WPS440': IssueType.ERROR_PRONE, # Forbid overlapping local and block variables. From 6e33f71c7f0b91eb468c4d2c85dc29386487f9d8 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:01:39 +0300 Subject: [PATCH 3/3] Fix tests --- test/python/inspectors/test_flake8_inspector.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/python/inspectors/test_flake8_inspector.py b/test/python/inspectors/test_flake8_inspector.py index 3208d633..6d199c49 100644 --- a/test/python/inspectors/test_flake8_inspector.py +++ b/test/python/inspectors/test_flake8_inspector.py @@ -57,7 +57,7 @@ def test_file_with_issues(file_name: str, n_issues: int): n_cc=8, n_other_complexity=2)), ('case3_redefining_builtin.py', IssuesTestInfo(n_error_prone=2)), - ('case4_naming.py', IssuesTestInfo(n_code_style=7, n_best_practices=3, n_cc=5, n_cohesion=1)), + ('case4_naming.py', IssuesTestInfo(n_code_style=7, n_cc=5, n_cohesion=1)), ('case6_unused_variables.py', IssuesTestInfo(n_best_practices=3, n_cc=1)), ('case8_good_class.py', IssuesTestInfo(n_cc=1, n_cohesion=1)), @@ -107,13 +107,13 @@ def test_parse(): assert [issue.description for issue in issues] == ['test 1', 'test 2', 'test 3'] assert [issue.type for issue in issues] == [IssueType.CODE_STYLE, IssueType.CODE_STYLE, - IssueType.BEST_PRACTICES] + IssueType.INFO] def test_choose_issue_type(): error_codes = ['B006', 'SC100', 'R503', 'ABC123', 'E101'] expected_issue_types = [ - IssueType.ERROR_PRONE, IssueType.BEST_PRACTICES, + IssueType.ERROR_PRONE, IssueType.INFO, IssueType.ERROR_PRONE, IssueType.BEST_PRACTICES, IssueType.CODE_STYLE, ]