From ef5a06d8f0eb5be18d90056a804a9f381aee1535 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:26:43 +0300 Subject: [PATCH 1/3] Add origin class for maintainability index --- src/python/review/inspectors/radon/radon.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/python/review/inspectors/radon/radon.py b/src/python/review/inspectors/radon/radon.py index f6a2236d..bdf9e570 100644 --- a/src/python/review/inspectors/radon/radon.py +++ b/src/python/review/inspectors/radon/radon.py @@ -10,6 +10,9 @@ from src.python.review.inspectors.tips import get_maintainability_index_tip +MAINTAINABILITY_ORIGIN_CLASS = "RAD100" + + class RadonInspector(BaseInspector): inspector_type = InspectorType.RADON @@ -41,7 +44,9 @@ def mi_parse(cls, mi_output: str) -> List[BaseIssue]: file_path = Path(groups[0]) maintainability_lack = convert_percentage_of_value_to_lack_of_value(float(groups[1])) - issue_data = IssueData.get_base_issue_data_dict(file_path, cls.inspector_type) + issue_data = IssueData.get_base_issue_data_dict( + file_path, cls.inspector_type, origin_class=MAINTAINABILITY_ORIGIN_CLASS + ) issue_data[IssueData.DESCRIPTION.value] = get_maintainability_index_tip() issue_data[IssueData.MAINTAINABILITY_LACK.value] = maintainability_lack issue_data[IssueData.ISSUE_TYPE.value] = IssueType.MAINTAINABILITY From 66a6efffa70219a433b2fc3c092fcd00bc48d854 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:27:29 +0300 Subject: [PATCH 2/3] Add WPS518 to ignore due to collision with C0200 by Pylint --- src/python/review/inspectors/flake8/.flake8 | 1 + 1 file changed, 1 insertion(+) diff --git a/src/python/review/inspectors/flake8/.flake8 b/src/python/review/inspectors/flake8/.flake8 index 2ad4f70f..19edebba 100644 --- a/src/python/review/inspectors/flake8/.flake8 +++ b/src/python/review/inspectors/flake8/.flake8 @@ -41,6 +41,7 @@ ignore=W291, # trailing whitespaces WPS431, # Forbid nested classes. WPS435, # Forbid multiplying lists. # WPS: Refactoring + WPS518, # Forbid implicit enumerate() calls. TODO: Collision with "C0200" WPS527, # Require tuples as arguments for frozenset. # WPS: OOP WPS602, # Forbid @staticmethod decorator. From e5f409838cc9024798060e215bedd71a65df6a1f Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Sun, 30 May 2021 17:30:21 +0300 Subject: [PATCH 3/3] Fix trailing comma --- src/python/review/inspectors/radon/radon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python/review/inspectors/radon/radon.py b/src/python/review/inspectors/radon/radon.py index bdf9e570..79223164 100644 --- a/src/python/review/inspectors/radon/radon.py +++ b/src/python/review/inspectors/radon/radon.py @@ -45,7 +45,7 @@ def mi_parse(cls, mi_output: str) -> List[BaseIssue]: maintainability_lack = convert_percentage_of_value_to_lack_of_value(float(groups[1])) issue_data = IssueData.get_base_issue_data_dict( - file_path, cls.inspector_type, origin_class=MAINTAINABILITY_ORIGIN_CLASS + file_path, cls.inspector_type, origin_class=MAINTAINABILITY_ORIGIN_CLASS, ) issue_data[IssueData.DESCRIPTION.value] = get_maintainability_index_tip() issue_data[IssueData.MAINTAINABILITY_LACK.value] = maintainability_lack