From ff1baa8ba6a4fdc3272b60e664be44538575ffc3 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Wed, 14 Jul 2021 16:01:23 +0300 Subject: [PATCH 1/5] Added a link to the table --- src/python/review/inspectors/checkstyle/files/config.xml | 2 ++ src/python/review/inspectors/pmd/files/bin/basic.xml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/python/review/inspectors/checkstyle/files/config.xml b/src/python/review/inspectors/checkstyle/files/config.xml index aceb7d8c..20689d93 100644 --- a/src/python/review/inspectors/checkstyle/files/config.xml +++ b/src/python/review/inspectors/checkstyle/files/config.xml @@ -6,6 +6,8 @@ + + diff --git a/src/python/review/inspectors/pmd/files/bin/basic.xml b/src/python/review/inspectors/pmd/files/bin/basic.xml index a0ebbcfb..09961647 100644 --- a/src/python/review/inspectors/pmd/files/bin/basic.xml +++ b/src/python/review/inspectors/pmd/files/bin/basic.xml @@ -9,6 +9,8 @@ The Basic ruleset contains a collection of good practices which should be followed. + + From ea360c670e9b06e710c41994fe35c1a240b30a75 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Wed, 14 Jul 2021 16:01:43 +0300 Subject: [PATCH 2/5] Added a link to the document --- src/python/review/inspectors/flake8/issue_types.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/python/review/inspectors/flake8/issue_types.py b/src/python/review/inspectors/flake8/issue_types.py index 440f5f82..b1074b52 100644 --- a/src/python/review/inspectors/flake8/issue_types.py +++ b/src/python/review/inspectors/flake8/issue_types.py @@ -27,6 +27,8 @@ 'C818': IssueType.CODE_STYLE, 'C819': IssueType.CODE_STYLE, + # The categorization for WPS was created using the following document: https://bit.ly/3yms06n + # WPS: Naming 'WPS117': IssueType.CODE_STYLE, # Forbid naming variables self, cls, or mcs. 'WPS125': IssueType.ERROR_PRONE, # Forbid variable or module names which shadow builtin names. From 47beb982079c6d03ba9fef2905c16539be2b2fb0 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov Date: Wed, 14 Jul 2021 16:04:05 +0300 Subject: [PATCH 3/5] Fixed the use of a non-existent class field --- .../inspectors/inspectors_stat/statistics_gathering.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/python/evaluation/inspectors/inspectors_stat/statistics_gathering.py b/src/python/evaluation/inspectors/inspectors_stat/statistics_gathering.py index c2c159ad..046c2606 100644 --- a/src/python/evaluation/inspectors/inspectors_stat/statistics_gathering.py +++ b/src/python/evaluation/inspectors/inspectors_stat/statistics_gathering.py @@ -76,8 +76,7 @@ def collect_stat_by_language(language: Language) -> IssuesStat: elif language == Language.JAVA: java_inspection_to_matcher = [ (set(PMD_RULE_TO_ISSUE_TYPE.keys()), PMDInspector.choose_issue_type), - (set(CHECK_CLASS_NAME_TO_ISSUE_TYPE.keys() - set(CheckstyleInspector.skipped_issues)), - CheckstyleInspector.choose_issue_type), + (set(CHECK_CLASS_NAME_TO_ISSUE_TYPE.keys()), CheckstyleInspector.choose_issue_type), ] return __collect_language_stat(*java_inspection_to_matcher) elif language == Language.KOTLIN: From 5ca6728baa37f4d8886e4442ee283aceea6a44a8 Mon Sep 17 00:00:00 2001 From: Ilya Vlasov <55441714+GirZ0n@users.noreply.github.com> Date: Wed, 14 Jul 2021 16:17:57 +0300 Subject: [PATCH 4/5] Updated statistics --- .../inspectors/inspectors_stat/README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/python/evaluation/inspectors/inspectors_stat/README.md b/src/python/evaluation/inspectors/inspectors_stat/README.md index c33c16f3..23c63428 100644 --- a/src/python/evaluation/inspectors/inspectors_stat/README.md +++ b/src/python/evaluation/inspectors/inspectors_stat/README.md @@ -15,12 +15,12 @@ More information about these categories can be found on [this](https://support.h The current statistics is: - | Error prone | Code style | Code complexity | Best practice ----------------| -----------|-------------|-----------------|-------------- -| Python | 162 | 146 | 35 | 254 | -| Java | 105 | 133 | 15 | 203 | -| JavaScript | 15 | 17 | 1 | 34 | -| Kotlin | 21 | 70 | 12 | 75 | +| | Error prone | Code style | Code complexity | Best practice | +|------------|-------------|------------|-----------------|---------------| +| Python | 162 | 146 | 35 | 254 | +| Java | 51 | 50 | 8 | 110 | +| JavaScript | 15 | 17 | 1 | 34 | +| Kotlin | 21 | 70 | 12 | 75 | ## Usage @@ -42,4 +42,4 @@ complexity: 35 times; error prone: 162 times; undefined: 3 times; Note: undefined means a category that is not categorized among the four main categories. Most likely it is info category -``` \ No newline at end of file +``` From 7f9fbbbf6a3bc0f4cb2df847a3c5b00d6e6932ae Mon Sep 17 00:00:00 2001 From: Ilya Vlasov <55441714+GirZ0n@users.noreply.github.com> Date: Wed, 14 Jul 2021 16:19:51 +0300 Subject: [PATCH 5/5] Small fix --- .../evaluation/inspectors/inspectors_stat/README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/python/evaluation/inspectors/inspectors_stat/README.md b/src/python/evaluation/inspectors/inspectors_stat/README.md index 23c63428..f8a4ad94 100644 --- a/src/python/evaluation/inspectors/inspectors_stat/README.md +++ b/src/python/evaluation/inspectors/inspectors_stat/README.md @@ -16,11 +16,11 @@ More information about these categories can be found on [this](https://support.h The current statistics is: | | Error prone | Code style | Code complexity | Best practice | -|------------|-------------|------------|-----------------|---------------| -| Python | 162 | 146 | 35 | 254 | -| Java | 51 | 50 | 8 | 110 | -| JavaScript | 15 | 17 | 1 | 34 | -| Kotlin | 21 | 70 | 12 | 75 | +|------------|:-----------:|:----------:|:---------------:|:-------------:| +| Python | 162 | 146 | 35 | 254 | +| Java | 51 | 50 | 8 | 110 | +| JavaScript | 15 | 17 | 1 | 34 | +| Kotlin | 21 | 70 | 12 | 75 | ## Usage