From 6e540a60a6e576ef148e00d1960bc91d519300e8 Mon Sep 17 00:00:00 2001 From: nihalshetty-boop <80703906+nihalshetty-boop@users.noreply.github.com> Date: Tue, 3 Aug 2021 19:57:47 +0530 Subject: [PATCH 1/3] Develop Branch Commit --- src/python/review/inspectors/base_inspector.py | 4 ++-- src/python/review/inspectors/checkstyle/checkstyle.py | 4 ++-- src/python/review/inspectors/detekt/detekt.py | 4 ++-- src/python/review/inspectors/eslint/eslint.py | 4 ++-- src/python/review/inspectors/flake8/flake8.py | 4 ++-- src/python/review/inspectors/intellij/intellij.py | 2 +- src/python/review/inspectors/pmd/pmd.py | 4 ++-- src/python/review/inspectors/pyast/python_ast.py | 2 +- src/python/review/inspectors/pylint/pylint.py | 4 ++-- src/python/review/inspectors/radon/radon.py | 4 ++-- src/python/review/inspectors/spotbugs/spotbugs.py | 2 +- src/python/review/inspectors/springlint/springlint.py | 2 +- 12 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/python/review/inspectors/base_inspector.py b/src/python/review/inspectors/base_inspector.py index 2fc92e93..0399bd8a 100644 --- a/src/python/review/inspectors/base_inspector.py +++ b/src/python/review/inspectors/base_inspector.py @@ -1,6 +1,6 @@ import abc from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.inspectors.inspector_type import InspectorType from src.python.review.inspectors.issue import BaseIssue @@ -30,5 +30,5 @@ def inspector_type(self) -> InspectorType: raise NotImplementedError('inspector_type property not implemented yet') @abc.abstractmethod - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: raise NotImplementedError('inspect method not implemented yet') diff --git a/src/python/review/inspectors/checkstyle/checkstyle.py b/src/python/review/inspectors/checkstyle/checkstyle.py index 57f809ec..808ff011 100644 --- a/src/python/review/inspectors/checkstyle/checkstyle.py +++ b/src/python/review/inspectors/checkstyle/checkstyle.py @@ -1,6 +1,6 @@ import logging from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess @@ -42,7 +42,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: '-f', 'xml', '-o', output_path, str(path), ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/detekt/detekt.py b/src/python/review/inspectors/detekt/detekt.py index 041c6b2d..af00bf05 100644 --- a/src/python/review/inspectors/detekt/detekt.py +++ b/src/python/review/inspectors/detekt/detekt.py @@ -1,6 +1,6 @@ import logging from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess @@ -41,7 +41,7 @@ def _create_command(cls, path: Path, output_path: Path): '--input', str(path), ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/eslint/eslint.py b/src/python/review/inspectors/eslint/eslint.py index c7d0b1b4..d75f9f34 100644 --- a/src/python/review/inspectors/eslint/eslint.py +++ b/src/python/review/inspectors/eslint/eslint.py @@ -1,5 +1,5 @@ from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess @@ -32,7 +32,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: path, ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/flake8/flake8.py b/src/python/review/inspectors/flake8/flake8.py index 7eb75a9d..1318e951 100644 --- a/src/python/review/inspectors/flake8/flake8.py +++ b/src/python/review/inspectors/flake8/flake8.py @@ -1,7 +1,7 @@ import logging import re from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector @@ -34,7 +34,7 @@ class Flake8Inspector(BaseInspector): inspector_type = InspectorType.FLAKE8 @classmethod - def inspect(cls, path: Path, config: dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: command = [ 'flake8', f'--format={FORMAT}', diff --git a/src/python/review/inspectors/intellij/intellij.py b/src/python/review/inspectors/intellij/intellij.py index b50dc0ca..10c68d89 100644 --- a/src/python/review/inspectors/intellij/intellij.py +++ b/src/python/review/inspectors/intellij/intellij.py @@ -51,7 +51,7 @@ def create_command(output_dir_path) -> List[Union[str, Path]]: INTELLIJ_INSPECTOR_SETTINGS, output_dir_path, '-v2', ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: path_in_project_to_origin_path = self.copy_files_to_project(path) try: diff --git a/src/python/review/inspectors/pmd/pmd.py b/src/python/review/inspectors/pmd/pmd.py index eb4878dd..5efc8703 100644 --- a/src/python/review/inspectors/pmd/pmd.py +++ b/src/python/review/inspectors/pmd/pmd.py @@ -2,7 +2,7 @@ import logging import os from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.application_config import LanguageVersion from src.python.review.common.file_system import new_temp_dir @@ -42,7 +42,7 @@ def _create_command(cls, path: Path, '-t', str(n_cpu), ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = Path(temp_dir / 'out.csv') diff --git a/src/python/review/inspectors/pyast/python_ast.py b/src/python/review/inspectors/pyast/python_ast.py index 58fc1bdd..e1ec3242 100644 --- a/src/python/review/inspectors/pyast/python_ast.py +++ b/src/python/review/inspectors/pyast/python_ast.py @@ -109,7 +109,7 @@ class PythonAstInspector(BaseInspector): inspector_type = InspectorType.PYTHON_AST @classmethod - def inspect(cls, path: Path, config: dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: if path.is_file(): path_to_files = [path] else: diff --git a/src/python/review/inspectors/pylint/pylint.py b/src/python/review/inspectors/pylint/pylint.py index e5a256cb..959e595c 100644 --- a/src/python/review/inspectors/pylint/pylint.py +++ b/src/python/review/inspectors/pylint/pylint.py @@ -1,7 +1,7 @@ import logging import re from pathlib import Path -from typing import List, Optional +from typing import Dict, List, Optional from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector @@ -25,7 +25,7 @@ class PylintInspector(BaseInspector): ) @classmethod - def inspect(cls, path: Path, config: dict) -> List[CodeIssue]: + def inspect(cls, path: Path, config: Dict) -> List[CodeIssue]: command = [ 'pylint', '--load-plugins', 'pylint_django', diff --git a/src/python/review/inspectors/radon/radon.py b/src/python/review/inspectors/radon/radon.py index a5153fc1..b357122c 100644 --- a/src/python/review/inspectors/radon/radon.py +++ b/src/python/review/inspectors/radon/radon.py @@ -1,6 +1,6 @@ import re from pathlib import Path -from typing import List +from typing import Dict, List from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector @@ -17,7 +17,7 @@ class RadonInspector(BaseInspector): inspector_type = InspectorType.RADON @classmethod - def inspect(cls, path: Path, config: dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: mi_command = [ 'radon', 'mi', # compute the Maintainability Index score '--max', 'F', # set the maximum MI rank to display diff --git a/src/python/review/inspectors/spotbugs/spotbugs.py b/src/python/review/inspectors/spotbugs/spotbugs.py index a2ee8b38..6f75aa69 100644 --- a/src/python/review/inspectors/spotbugs/spotbugs.py +++ b/src/python/review/inspectors/spotbugs/spotbugs.py @@ -33,7 +33,7 @@ def _create_command(cls, path: Path) -> List[str]: str(path), ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: if path.is_file(): is_successful = javac(path) else: diff --git a/src/python/review/inspectors/springlint/springlint.py b/src/python/review/inspectors/springlint/springlint.py index b5eca5a4..ad9eaa93 100644 --- a/src/python/review/inspectors/springlint/springlint.py +++ b/src/python/review/inspectors/springlint/springlint.py @@ -82,7 +82,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: '--project', str(path), ] - def inspect(self, path: Path, config: dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: with new_temp_dir() as temp_dir: if path.is_file(): return self._inspect_file(path, temp_dir) From a673b6ebb665b22eb086d9f10616c4c74ed7ec37 Mon Sep 17 00:00:00 2001 From: nihalshetty-boop <80703906+nihalshetty-boop@users.noreply.github.com> Date: Wed, 4 Aug 2021 20:45:42 +0530 Subject: [PATCH 2/3] Added Types for Dict --- src/python/review/inspectors/base_inspector.py | 2 +- src/python/review/inspectors/checkstyle/checkstyle.py | 2 +- src/python/review/inspectors/detekt/detekt.py | 2 +- src/python/review/inspectors/eslint/eslint.py | 2 +- src/python/review/inspectors/flake8/flake8.py | 2 +- src/python/review/inspectors/intellij/intellij.py | 2 +- src/python/review/inspectors/pmd/pmd.py | 2 +- src/python/review/inspectors/pyast/python_ast.py | 2 +- src/python/review/inspectors/pylint/pylint.py | 2 +- src/python/review/inspectors/radon/radon.py | 2 +- src/python/review/inspectors/spotbugs/spotbugs.py | 2 +- src/python/review/inspectors/springlint/springlint.py | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/python/review/inspectors/base_inspector.py b/src/python/review/inspectors/base_inspector.py index 0399bd8a..79a5d410 100644 --- a/src/python/review/inspectors/base_inspector.py +++ b/src/python/review/inspectors/base_inspector.py @@ -30,5 +30,5 @@ def inspector_type(self) -> InspectorType: raise NotImplementedError('inspector_type property not implemented yet') @abc.abstractmethod - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: raise NotImplementedError('inspect method not implemented yet') diff --git a/src/python/review/inspectors/checkstyle/checkstyle.py b/src/python/review/inspectors/checkstyle/checkstyle.py index 808ff011..32952499 100644 --- a/src/python/review/inspectors/checkstyle/checkstyle.py +++ b/src/python/review/inspectors/checkstyle/checkstyle.py @@ -42,7 +42,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: '-f', 'xml', '-o', output_path, str(path), ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/detekt/detekt.py b/src/python/review/inspectors/detekt/detekt.py index af00bf05..553abea1 100644 --- a/src/python/review/inspectors/detekt/detekt.py +++ b/src/python/review/inspectors/detekt/detekt.py @@ -41,7 +41,7 @@ def _create_command(cls, path: Path, output_path: Path): '--input', str(path), ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/eslint/eslint.py b/src/python/review/inspectors/eslint/eslint.py index d75f9f34..24cadc27 100644 --- a/src/python/review/inspectors/eslint/eslint.py +++ b/src/python/review/inspectors/eslint/eslint.py @@ -32,7 +32,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: path, ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = temp_dir / 'output.xml' command = self._create_command(path, output_path) diff --git a/src/python/review/inspectors/flake8/flake8.py b/src/python/review/inspectors/flake8/flake8.py index 1318e951..8130b5db 100644 --- a/src/python/review/inspectors/flake8/flake8.py +++ b/src/python/review/inspectors/flake8/flake8.py @@ -34,7 +34,7 @@ class Flake8Inspector(BaseInspector): inspector_type = InspectorType.FLAKE8 @classmethod - def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: command = [ 'flake8', f'--format={FORMAT}', diff --git a/src/python/review/inspectors/intellij/intellij.py b/src/python/review/inspectors/intellij/intellij.py index 10c68d89..f9146901 100644 --- a/src/python/review/inspectors/intellij/intellij.py +++ b/src/python/review/inspectors/intellij/intellij.py @@ -51,7 +51,7 @@ def create_command(output_dir_path) -> List[Union[str, Path]]: INTELLIJ_INSPECTOR_SETTINGS, output_dir_path, '-v2', ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: path_in_project_to_origin_path = self.copy_files_to_project(path) try: diff --git a/src/python/review/inspectors/pmd/pmd.py b/src/python/review/inspectors/pmd/pmd.py index 5efc8703..93f6f285 100644 --- a/src/python/review/inspectors/pmd/pmd.py +++ b/src/python/review/inspectors/pmd/pmd.py @@ -42,7 +42,7 @@ def _create_command(cls, path: Path, '-t', str(n_cpu), ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: with new_temp_dir() as temp_dir: output_path = Path(temp_dir / 'out.csv') diff --git a/src/python/review/inspectors/pyast/python_ast.py b/src/python/review/inspectors/pyast/python_ast.py index e1ec3242..0c2b0479 100644 --- a/src/python/review/inspectors/pyast/python_ast.py +++ b/src/python/review/inspectors/pyast/python_ast.py @@ -109,7 +109,7 @@ class PythonAstInspector(BaseInspector): inspector_type = InspectorType.PYTHON_AST @classmethod - def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: if path.is_file(): path_to_files = [path] else: diff --git a/src/python/review/inspectors/pylint/pylint.py b/src/python/review/inspectors/pylint/pylint.py index 959e595c..8a200012 100644 --- a/src/python/review/inspectors/pylint/pylint.py +++ b/src/python/review/inspectors/pylint/pylint.py @@ -25,7 +25,7 @@ class PylintInspector(BaseInspector): ) @classmethod - def inspect(cls, path: Path, config: Dict) -> List[CodeIssue]: + def inspect(cls, path: Path, config: Dict[str, Any]) -> List[CodeIssue]: command = [ 'pylint', '--load-plugins', 'pylint_django', diff --git a/src/python/review/inspectors/radon/radon.py b/src/python/review/inspectors/radon/radon.py index b357122c..0d17b9e3 100644 --- a/src/python/review/inspectors/radon/radon.py +++ b/src/python/review/inspectors/radon/radon.py @@ -17,7 +17,7 @@ class RadonInspector(BaseInspector): inspector_type = InspectorType.RADON @classmethod - def inspect(cls, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(cls, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: mi_command = [ 'radon', 'mi', # compute the Maintainability Index score '--max', 'F', # set the maximum MI rank to display diff --git a/src/python/review/inspectors/spotbugs/spotbugs.py b/src/python/review/inspectors/spotbugs/spotbugs.py index 6f75aa69..f93edefc 100644 --- a/src/python/review/inspectors/spotbugs/spotbugs.py +++ b/src/python/review/inspectors/spotbugs/spotbugs.py @@ -33,7 +33,7 @@ def _create_command(cls, path: Path) -> List[str]: str(path), ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: if path.is_file(): is_successful = javac(path) else: diff --git a/src/python/review/inspectors/springlint/springlint.py b/src/python/review/inspectors/springlint/springlint.py index ad9eaa93..d6dd748b 100644 --- a/src/python/review/inspectors/springlint/springlint.py +++ b/src/python/review/inspectors/springlint/springlint.py @@ -82,7 +82,7 @@ def _create_command(cls, path: Path, output_path: Path) -> List[str]: '--project', str(path), ] - def inspect(self, path: Path, config: Dict) -> List[BaseIssue]: + def inspect(self, path: Path, config: Dict[str, Any]) -> List[BaseIssue]: with new_temp_dir() as temp_dir: if path.is_file(): return self._inspect_file(path, temp_dir) From b603c89a61ac10bac140fe8bc71b78f146836672 Mon Sep 17 00:00:00 2001 From: nihalshetty-boop <80703906+nihalshetty-boop@users.noreply.github.com> Date: Thu, 5 Aug 2021 13:27:34 +0530 Subject: [PATCH 3/3] Added Any to typing --- src/python/review/inspectors/base_inspector.py | 2 +- src/python/review/inspectors/checkstyle/checkstyle.py | 2 +- src/python/review/inspectors/detekt/detekt.py | 2 +- src/python/review/inspectors/eslint/eslint.py | 2 +- src/python/review/inspectors/flake8/flake8.py | 2 +- src/python/review/inspectors/intellij/intellij.py | 2 +- src/python/review/inspectors/pmd/pmd.py | 2 +- src/python/review/inspectors/pyast/python_ast.py | 2 +- src/python/review/inspectors/pylint/pylint.py | 2 +- src/python/review/inspectors/radon/radon.py | 2 +- src/python/review/inspectors/spotbugs/spotbugs.py | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/python/review/inspectors/base_inspector.py b/src/python/review/inspectors/base_inspector.py index 79a5d410..032f6f60 100644 --- a/src/python/review/inspectors/base_inspector.py +++ b/src/python/review/inspectors/base_inspector.py @@ -1,6 +1,6 @@ import abc from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.inspectors.inspector_type import InspectorType from src.python.review.inspectors.issue import BaseIssue diff --git a/src/python/review/inspectors/checkstyle/checkstyle.py b/src/python/review/inspectors/checkstyle/checkstyle.py index 32952499..0eafef7f 100644 --- a/src/python/review/inspectors/checkstyle/checkstyle.py +++ b/src/python/review/inspectors/checkstyle/checkstyle.py @@ -1,6 +1,6 @@ import logging from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess diff --git a/src/python/review/inspectors/detekt/detekt.py b/src/python/review/inspectors/detekt/detekt.py index 553abea1..f9a9bdec 100644 --- a/src/python/review/inspectors/detekt/detekt.py +++ b/src/python/review/inspectors/detekt/detekt.py @@ -1,6 +1,6 @@ import logging from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess diff --git a/src/python/review/inspectors/eslint/eslint.py b/src/python/review/inspectors/eslint/eslint.py index 24cadc27..0d4736d4 100644 --- a/src/python/review/inspectors/eslint/eslint.py +++ b/src/python/review/inspectors/eslint/eslint.py @@ -1,5 +1,5 @@ from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.file_system import new_temp_dir from src.python.review.common.subprocess_runner import run_in_subprocess diff --git a/src/python/review/inspectors/flake8/flake8.py b/src/python/review/inspectors/flake8/flake8.py index 8130b5db..a427cb14 100644 --- a/src/python/review/inspectors/flake8/flake8.py +++ b/src/python/review/inspectors/flake8/flake8.py @@ -1,7 +1,7 @@ import logging import re from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector diff --git a/src/python/review/inspectors/intellij/intellij.py b/src/python/review/inspectors/intellij/intellij.py index f9146901..360cb089 100644 --- a/src/python/review/inspectors/intellij/intellij.py +++ b/src/python/review/inspectors/intellij/intellij.py @@ -2,7 +2,7 @@ import os import re from pathlib import Path -from typing import Dict, List, Optional, Union +from typing import Any, Dict, List, Optional, Union from xml.etree import ElementTree from src.python.review.common.file_system import get_all_file_system_items, new_temp_dir diff --git a/src/python/review/inspectors/pmd/pmd.py b/src/python/review/inspectors/pmd/pmd.py index 93f6f285..6f6f1b08 100644 --- a/src/python/review/inspectors/pmd/pmd.py +++ b/src/python/review/inspectors/pmd/pmd.py @@ -2,7 +2,7 @@ import logging import os from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.application_config import LanguageVersion from src.python.review.common.file_system import new_temp_dir diff --git a/src/python/review/inspectors/pyast/python_ast.py b/src/python/review/inspectors/pyast/python_ast.py index 0c2b0479..77cdb8d1 100644 --- a/src/python/review/inspectors/pyast/python_ast.py +++ b/src/python/review/inspectors/pyast/python_ast.py @@ -1,7 +1,7 @@ import ast from collections import Counter, defaultdict from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common import language from src.python.review.common.file_system import get_all_file_system_items diff --git a/src/python/review/inspectors/pylint/pylint.py b/src/python/review/inspectors/pylint/pylint.py index 8a200012..a8430d05 100644 --- a/src/python/review/inspectors/pylint/pylint.py +++ b/src/python/review/inspectors/pylint/pylint.py @@ -1,7 +1,7 @@ import logging import re from pathlib import Path -from typing import Dict, List, Optional +from typing import Any, Dict, List, Optional from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector diff --git a/src/python/review/inspectors/radon/radon.py b/src/python/review/inspectors/radon/radon.py index 0d17b9e3..4d7466fa 100644 --- a/src/python/review/inspectors/radon/radon.py +++ b/src/python/review/inspectors/radon/radon.py @@ -1,6 +1,6 @@ import re from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.subprocess_runner import run_in_subprocess from src.python.review.inspectors.base_inspector import BaseInspector diff --git a/src/python/review/inspectors/spotbugs/spotbugs.py b/src/python/review/inspectors/spotbugs/spotbugs.py index f93edefc..c4580034 100644 --- a/src/python/review/inspectors/spotbugs/spotbugs.py +++ b/src/python/review/inspectors/spotbugs/spotbugs.py @@ -2,7 +2,7 @@ import re from collections import Counter from pathlib import Path -from typing import Dict, List +from typing import Any, Dict, List from src.python.review.common.file_system import get_all_file_system_items from src.python.review.common.java_compiler import javac, javac_project