From 22a1785e92e429c8f66a13b75a51fdc6f822d5b4 Mon Sep 17 00:00:00 2001 From: kamaleshnneerasa Date: Wed, 10 Nov 2021 10:53:18 +0530 Subject: [PATCH 1/2] Changing labels graphql apis to use new labels config schema --- .../graphql/label/dao/LabelRequestConverter.java | 12 ++++-------- .../graphql/label/dao/LabelResponseConverter.java | 9 +++++---- hypertrace-graphql-platform/build.gradle.kts | 5 +++-- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelRequestConverter.java b/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelRequestConverter.java index 57c7386d..b88dba8f 100644 --- a/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelRequestConverter.java +++ b/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelRequestConverter.java @@ -2,25 +2,21 @@ import org.hypertrace.graphql.label.request.LabelCreateRequest; import org.hypertrace.graphql.label.request.LabelUpdateRequest; -import org.hypertrace.label.config.service.v1.CreateLabel; import org.hypertrace.label.config.service.v1.CreateLabelRequest; -import org.hypertrace.label.config.service.v1.Label; +import org.hypertrace.label.config.service.v1.LabelData; import org.hypertrace.label.config.service.v1.UpdateLabelRequest; public class LabelRequestConverter { CreateLabelRequest convertCreationRequest(LabelCreateRequest creationRequest) { return CreateLabelRequest.newBuilder() - .setLabel(CreateLabel.newBuilder().setKey(creationRequest.label().key()).build()) + .setData(LabelData.newBuilder().setKey(creationRequest.label().key()).build()) .build(); } UpdateLabelRequest convertUpdateRequest(LabelUpdateRequest updateRequest) { return UpdateLabelRequest.newBuilder() - .setLabel( - Label.newBuilder() - .setKey(updateRequest.label().key()) - .setId(updateRequest.label().id()) - .build()) + .setId(updateRequest.label().id()) + .setData(LabelData.newBuilder().setKey(updateRequest.label().key()).build()) .build(); } } diff --git a/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelResponseConverter.java b/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelResponseConverter.java index 8641815d..f5b2c603 100644 --- a/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelResponseConverter.java +++ b/hypertrace-graphql-labels-schema/src/main/java/org/hypertrace/graphql/label/dao/LabelResponseConverter.java @@ -25,22 +25,23 @@ Single convert(GetLabelsResponse response) { Single> convertToLabelList(GetLabelsResponse response) { return Single.just( response.getLabelsList().stream() - .map(label -> new DefaultLabel(label.getId(), label.getKey())) + .map(label -> new DefaultLabel(label.getId(), label.getData().getKey())) .collect(Collectors.toUnmodifiableList())); } Single