From d9776c3594b29ad84e6e580a23c1995a56171c0b Mon Sep 17 00:00:00 2001 From: Aaron Steinfeld Date: Mon, 17 Apr 2023 12:13:19 +0530 Subject: [PATCH 1/2] refactor: update direct use of context to use new version --- hypertrace-core-graphql | 2 +- .../hypertrace/graphql/entity/fetcher/EntityFetcher.java | 6 +++++- .../graphql/explorer/fetcher/ExplorerFetcher.java | 6 +++++- .../graphql/label/fetcher/LabelApplicationRuleFetcher.java | 4 +++- .../org/hypertrace/graphql/label/fetcher/LabelFetcher.java | 7 +++++-- .../label/mutator/LabelApplicationRuleCreateMutator.java | 4 +++- .../label/mutator/LabelApplicationRuleDeleteMutator.java | 4 +++- .../label/mutator/LabelApplicationRuleUpdateMutator.java | 4 +++- .../graphql/label/mutator/LabelCreateMutator.java | 4 +++- .../graphql/label/mutator/LabelUpdateMutator.java | 4 +++- .../graphql/spaces/fetcher/SpaceConfigRuleFetcher.java | 4 +++- .../hypertrace/graphql/spaces/fetcher/SpacesFetcher.java | 4 +++- .../spaces/mutator/SpaceConfigRuleCreationMutator.java | 4 +++- .../spaces/mutator/SpaceConfigRuleDeleteMutator.java | 4 +++- .../spaces/mutator/SpaceConfigRuleUpdateMutator.java | 4 +++- .../fetcher/mutation/ExcludeSpanCreateRuleMutator.java | 4 +++- .../fetcher/mutation/ExcludeSpanDeleteRuleMutator.java | 4 +++- .../fetcher/mutation/ExcludeSpanUpdateRuleMutator.java | 4 +++- .../fetcher/query/ExcludeSpanRulesFetcher.java | 4 +++- 19 files changed, 61 insertions(+), 20 deletions(-) diff --git a/hypertrace-core-graphql b/hypertrace-core-graphql index 9712c62a..69ce0440 160000 --- a/hypertrace-core-graphql +++ b/hypertrace-core-graphql @@ -1 +1 @@ -Subproject commit 9712c62a023f007119fa075723452235e7a9caaa +Subproject commit 69ce044055889015c58b5c3a0e5994b7779e463b diff --git a/hypertrace-graphql-entity-schema/src/main/java/org/hypertrace/graphql/entity/fetcher/EntityFetcher.java b/hypertrace-graphql-entity-schema/src/main/java/org/hypertrace/graphql/entity/fetcher/EntityFetcher.java index 5b4c0b29..679023ca 100644 --- a/hypertrace-graphql-entity-schema/src/main/java/org/hypertrace/graphql/entity/fetcher/EntityFetcher.java +++ b/hypertrace-graphql-entity-schema/src/main/java/org/hypertrace/graphql/entity/fetcher/EntityFetcher.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.entity.fetcher; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -29,7 +31,9 @@ static final class EntityFetcherImpl implements DataFetcher get(DataFetchingEnvironment environment) { return this.requestBuilder .build( - environment.getContext(), environment.getArguments(), environment.getSelectionSet()) + contextFromEnvironment(environment), + environment.getArguments(), + environment.getSelectionSet()) .flatMap(this.entityDao::getEntities) .toCompletionStage() .toCompletableFuture(); diff --git a/hypertrace-graphql-explorer-schema/src/main/java/org/hypertrace/graphql/explorer/fetcher/ExplorerFetcher.java b/hypertrace-graphql-explorer-schema/src/main/java/org/hypertrace/graphql/explorer/fetcher/ExplorerFetcher.java index a32e3190..5e473f44 100644 --- a/hypertrace-graphql-explorer-schema/src/main/java/org/hypertrace/graphql/explorer/fetcher/ExplorerFetcher.java +++ b/hypertrace-graphql-explorer-schema/src/main/java/org/hypertrace/graphql/explorer/fetcher/ExplorerFetcher.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.explorer.fetcher; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -31,7 +33,9 @@ static final class ExplorerFetcherImpl public CompletableFuture get(DataFetchingEnvironment environment) { return this.requestBuilder .build( - environment.getContext(), environment.getArguments(), environment.getSelectionSet()) + contextFromEnvironment(environment), + environment.getArguments(), + environment.getSelectionSet()) .flatMap(this.explorerDao::explore) .toCompletionStage() .toCompletableFuture(); diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelApplicationRuleFetcher.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelApplicationRuleFetcher.java index 35d85fdc..669f2819 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelApplicationRuleFetcher.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelApplicationRuleFetcher.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.label.fetcher; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -31,7 +33,7 @@ static final class LabelApplicationRuleFetcherImpl public CompletableFuture get( DataFetchingEnvironment environment) { return this.labelApplicationRuleDao - .getLabelApplicationRules(this.requestBuilder.build(environment.getContext())) + .getLabelApplicationRules(this.requestBuilder.build(contextFromEnvironment(environment))) .toCompletionStage() .toCompletableFuture(); } diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelFetcher.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelFetcher.java index 3381db12..98d01cec 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelFetcher.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/fetcher/LabelFetcher.java @@ -1,10 +1,13 @@ package org.hypertrace.graphql.label.fetcher; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; import javax.inject.Inject; import org.hypertrace.core.graphql.common.fetcher.InjectableDataFetcher; +import org.hypertrace.graphql.label.joiner.EntityAndRuleJoiner; import org.hypertrace.graphql.label.joiner.EntityAndRuleJoinerBuilder; import org.hypertrace.graphql.label.schema.LabelResultSet; @@ -25,8 +28,8 @@ static final class LabelFetcherImpl implements DataFetcher get(DataFetchingEnvironment environment) { return this.requestBuilder - .build(environment.getContext(), environment.getSelectionSet()) - .flatMap(request -> request.joinLabelsWithEntitiesAndRules()) + .build(contextFromEnvironment(environment), environment.getSelectionSet()) + .flatMap(EntityAndRuleJoiner::joinLabelsWithEntitiesAndRules) .toCompletionStage() .toCompletableFuture(); } diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleCreateMutator.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleCreateMutator.java index 4de7ccc5..379e6d0c 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleCreateMutator.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleCreateMutator.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.label.mutator; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -33,7 +35,7 @@ public CompletableFuture get(DataFetchingEnvironment envir return this.labelApplicationRuleDao .createLabelApplicationRule( this.requestBuilder.buildCreateLabelApplicationRuleRequest( - environment.getContext(), environment.getArguments())) + contextFromEnvironment(environment), environment.getArguments())) .toCompletionStage() .toCompletableFuture(); } diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleDeleteMutator.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleDeleteMutator.java index 2cd2aa1e..ede47bef 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleDeleteMutator.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleDeleteMutator.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.label.mutator; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -31,7 +33,7 @@ public CompletableFuture get(DataFetchingEnvironment environment) { return this.labelApplicationRuleDao .deleteLabelApplicationRule( this.requestBuilder.buildDeleteLabelApplicationRuleRequest( - environment.getContext(), environment.getArguments())) + contextFromEnvironment(environment), environment.getArguments())) .toCompletionStage() .toCompletableFuture(); } diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleUpdateMutator.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleUpdateMutator.java index eb80dfdf..876888f3 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleUpdateMutator.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelApplicationRuleUpdateMutator.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.label.mutator; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -33,7 +35,7 @@ public CompletableFuture get(DataFetchingEnvironment envir return this.labelApplicationRuleDao .updateLabelApplicationRule( this.requestBuilder.buildUpdateLabelApplicationRuleRequest( - environment.getContext(), environment.getArguments())) + contextFromEnvironment(environment), environment.getArguments())) .toCompletionStage() .toCompletableFuture(); } diff --git a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelCreateMutator.java b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelCreateMutator.java index e4305d31..be273ed6 100644 --- a/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelCreateMutator.java +++ b/hypertrace-graphql-labels-schema-api/src/main/java/org/hypertrace/graphql/label/mutator/LabelCreateMutator.java @@ -1,5 +1,7 @@ package org.hypertrace.graphql.label.mutator; +import static org.hypertrace.core.graphql.context.GraphQlRequestContext.contextFromEnvironment; + import graphql.schema.DataFetcher; import graphql.schema.DataFetchingEnvironment; import java.util.concurrent.CompletableFuture; @@ -30,7 +32,7 @@ public CompletableFuture