From d4c131385509201ba5317fc0915c0b9f534aba16 Mon Sep 17 00:00:00 2001
From: Ronak <ronak@traceable.ai>
Date: Thu, 25 Nov 2021 12:04:18 +0530
Subject: [PATCH 1/2] fix: adds support for default max spans limit helm config

---
 .../helm/templates/raw-spans-grouper-config.yaml          | 4 ++++
 raw-spans-grouper/helm/values.yaml                        | 2 ++
 .../core/rawspansgrouper/RawSpansProcessor.java           | 8 +++-----
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/raw-spans-grouper/helm/templates/raw-spans-grouper-config.yaml b/raw-spans-grouper/helm/templates/raw-spans-grouper-config.yaml
index 9cac53297..fcb9d8765 100644
--- a/raw-spans-grouper/helm/templates/raw-spans-grouper-config.yaml
+++ b/raw-spans-grouper/helm/templates/raw-spans-grouper-config.yaml
@@ -56,6 +56,10 @@ data:
 
     span.groupby.session.window.interval = {{ .Values.rawSpansGrouperConfig.span.groupby.internal }}
 
+    {{- if hasKey .Values.rawSpansGrouperConfig "defaultMaxSpanCount" }}
+    default.max.span.count = {{ .Values.rawSpansGrouperConfig.defaultMaxSpanCount }}
+    {{- end }}
+
     {{- if hasKey .Values.rawSpansGrouperConfig "maxSpanCount" }}
     max.span.count = {
     {{- range $k, $v := .Values.rawSpansGrouperConfig.maxSpanCount }}
diff --git a/raw-spans-grouper/helm/values.yaml b/raw-spans-grouper/helm/values.yaml
index fb69622df..409232cb3 100644
--- a/raw-spans-grouper/helm/values.yaml
+++ b/raw-spans-grouper/helm/values.yaml
@@ -128,6 +128,8 @@ rawSpansGrouperConfig:
     groupby:
       internal: 30
 
+  defaultMaxSpanCount: 1000
+
 logConfig:
   name: raw-spans-grouper-log-config
   monitorInterval: 30
diff --git a/raw-spans-grouper/raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java b/raw-spans-grouper/raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
index b165870ba..c0a944c5b 100644
--- a/raw-spans-grouper/raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
+++ b/raw-spans-grouper/raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
@@ -175,10 +175,9 @@ private boolean shouldDropSpan(TraceIdentity key, TraceState traceState) {
     long maxSpanCountTenantLimit =
         maxSpanCountMap.containsKey(key.getTenantId())
             ? maxSpanCountMap.get(key.getTenantId())
-            : Long.MAX_VALUE;
+            : defaultMaxSpanCountLimit;
 
-    if (inFlightSpansPerTrace >= defaultMaxSpanCountLimit
-        || inFlightSpansPerTrace >= maxSpanCountTenantLimit) {
+    if (inFlightSpansPerTrace >= maxSpanCountTenantLimit) {
 
       if (logger.isDebugEnabled()) {
         logger.debug(
@@ -199,8 +198,7 @@ private boolean shouldDropSpan(TraceIdentity key, TraceState traceState) {
           .increment();
 
       // increment the counter when the number of spans reaches the max.span.count limit.
-      if (inFlightSpansPerTrace == defaultMaxSpanCountLimit
-          || inFlightSpansPerTrace == maxSpanCountTenantLimit) {
+      if (inFlightSpansPerTrace == maxSpanCountTenantLimit) {
         truncatedTracesCounter
             .computeIfAbsent(
                 key.getTenantId(),

From 7b4a3091d48878f9376c3a407c992ee34407fdf3 Mon Sep 17 00:00:00 2001
From: Ronak <ronak@traceable.ai>
Date: Thu, 25 Nov 2021 12:11:40 +0530
Subject: [PATCH 2/2] there is no limit as default

---
 raw-spans-grouper/helm/values.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/raw-spans-grouper/helm/values.yaml b/raw-spans-grouper/helm/values.yaml
index 409232cb3..fb69622df 100644
--- a/raw-spans-grouper/helm/values.yaml
+++ b/raw-spans-grouper/helm/values.yaml
@@ -128,8 +128,6 @@ rawSpansGrouperConfig:
     groupby:
       internal: 30
 
-  defaultMaxSpanCount: 1000
-
 logConfig:
   name: raw-spans-grouper-log-config
   monitorInterval: 30