From af3179d46c1cf1885fa66c21728741b0fd993258 Mon Sep 17 00:00:00 2001 From: Jay Bhatt Date: Tue, 18 Jan 2022 16:57:26 +0530 Subject: [PATCH 1/4] feat(metrics): show y Axis and corresponding grid lines --- .../metrics/service-metrics.dashboard.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts b/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts index d4ded84dd..6a2ba1d74 100644 --- a/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts +++ b/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts @@ -201,6 +201,13 @@ export const serviceMetricsDashboard: DashboardDefaultConfiguration = { 'color-palette': RED_COLOR_PALETTE, 'selectable-interval': true, 'legend-position': LegendPosition.TopLeft, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, + 'max-series-data-points': 150, bands: [ { type: 'band', @@ -383,6 +390,13 @@ export const serviceMetricsDashboard: DashboardDefaultConfiguration = { type: 'cartesian-widget', 'selectable-interval': true, 'legend-position': LegendPosition.None, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, + 'max-series-data-points': 150, series: [ { type: 'series', From e15c1fcfde37f313adc7e2d0db78ff706c87f352 Mon Sep 17 00:00:00 2001 From: Jay Bhatt Date: Tue, 18 Jan 2022 23:17:53 +0530 Subject: [PATCH 2/4] refactor: remove max series data points from y axis config --- .../apis/service-detail/metrics/service-metrics.dashboard.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts b/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts index 6a2ba1d74..6d8ae4569 100644 --- a/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts +++ b/projects/observability/src/pages/apis/service-detail/metrics/service-metrics.dashboard.ts @@ -207,7 +207,6 @@ export const serviceMetricsDashboard: DashboardDefaultConfiguration = { 'show-grid-lines': true, 'min-upper-limit': 25 }, - 'max-series-data-points': 150, bands: [ { type: 'band', @@ -396,7 +395,6 @@ export const serviceMetricsDashboard: DashboardDefaultConfiguration = { 'show-grid-lines': true, 'min-upper-limit': 25 }, - 'max-series-data-points': 150, series: [ { type: 'series', From 6cfc678fa34286064b3ce581c5dd576e9455c85a Mon Sep 17 00:00:00 2001 From: Jay Bhatt Date: Thu, 20 Jan 2022 18:24:39 +0530 Subject: [PATCH 3/4] feat: added y axis grid lines for metrics tab in API view --- .../apis/api-detail/metrics/api-metrics.dashboard.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/projects/observability/src/pages/apis/api-detail/metrics/api-metrics.dashboard.ts b/projects/observability/src/pages/apis/api-detail/metrics/api-metrics.dashboard.ts index 0a9470ee4..b5e6abab9 100644 --- a/projects/observability/src/pages/apis/api-detail/metrics/api-metrics.dashboard.ts +++ b/projects/observability/src/pages/apis/api-detail/metrics/api-metrics.dashboard.ts @@ -201,6 +201,12 @@ export const apiMetricsDashboard: DashboardDefaultConfiguration = { 'color-palette': RED_COLOR_PALETTE, 'selectable-interval': true, 'legend-position': LegendPosition.TopLeft, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, bands: [ { type: 'band', @@ -383,6 +389,12 @@ export const apiMetricsDashboard: DashboardDefaultConfiguration = { type: 'cartesian-widget', 'selectable-interval': true, 'legend-position': LegendPosition.None, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, series: [ { type: 'series', From 0d4f34f22288d6ee375025a7285ea349dbeaf642 Mon Sep 17 00:00:00 2001 From: Jay Bhatt Date: Thu, 20 Jan 2022 18:25:07 +0530 Subject: [PATCH 4/4] feat: added y axis grid lines for metrics tab in Backends view --- .../metrics/backend-metrics.dashboard.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/projects/observability/src/pages/apis/backend-detail/metrics/backend-metrics.dashboard.ts b/projects/observability/src/pages/apis/backend-detail/metrics/backend-metrics.dashboard.ts index 00bbc7987..433d293e4 100644 --- a/projects/observability/src/pages/apis/backend-detail/metrics/backend-metrics.dashboard.ts +++ b/projects/observability/src/pages/apis/backend-detail/metrics/backend-metrics.dashboard.ts @@ -201,6 +201,12 @@ export const backendMetricsDashboard: DashboardDefaultConfiguration = { 'color-palette': RED_COLOR_PALETTE, 'selectable-interval': true, 'legend-position': LegendPosition.TopLeft, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, series: [ { type: 'series', @@ -351,6 +357,12 @@ export const backendMetricsDashboard: DashboardDefaultConfiguration = { type: 'cartesian-widget', 'selectable-interval': true, 'legend-position': LegendPosition.None, + 'show-y-axis': true, + 'y-axis': { + type: 'cartesian-axis', + 'show-grid-lines': true, + 'min-upper-limit': 25 + }, series: [ { type: 'series',