From 1c0b4754e5b292e078d3ba10c7a46b6a686b17ce Mon Sep 17 00:00:00 2001
From: Aaron Steinfeld <aaron@traceable.ai>
Date: Sat, 19 Mar 2022 09:32:08 -0400
Subject: [PATCH 1/2] refactor: always use query limits

---
 .../trace-detail/data/trace-detail-data-source.model.test.ts  | 4 ++--
 .../trace-detail/data/trace-detail-data-source.model.ts       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts
index 3811874c1..b1e396a4f 100644
--- a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts
+++ b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.test.ts
@@ -74,7 +74,7 @@ describe('API Trace detail data source model', () => {
       expect.objectContaining({
         requestType: TRACE_GQL_REQUEST,
         traceId: 'test',
-        spanLimit: 0,
+        spanLimit: 1000,
         timestamp: undefined,
         traceProperties: expect.arrayContaining([
           expect.objectContaining({ name: 'tags' }),
@@ -94,7 +94,7 @@ describe('API Trace detail data source model', () => {
       expect.objectContaining({
         requestType: TRACE_GQL_REQUEST,
         traceId: 'test',
-        spanLimit: 0,
+        spanLimit: 1000,
         timestamp: new Date(1576364117792),
         traceProperties: expect.arrayContaining([
           expect.objectContaining({ name: 'tags' }),
diff --git a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts
index 290f5e62a..7d5b83ced 100644
--- a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts
+++ b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/trace-detail-data-source.model.ts
@@ -42,7 +42,7 @@ export class TraceDetailDataSourceModel extends GraphQlDataSourceModel<TraceDeta
       requestType: TRACE_GQL_REQUEST,
       traceType: this.trace[traceTypeKey],
       traceId: this.trace[traceIdKey],
-      spanLimit: 0,
+      spanLimit: 1000,
       timestamp: this.dateCoercer.coerce(this.startTime ?? this.trace.startTime),
       traceProperties: this.getTraceAttributes().map(attribute =>
         this.attributeSpecBuilder.attributeSpecificationForKey(attribute)

From 0b2a3dfb7c6c5fc353c0355f4a118c14c80d92ab Mon Sep 17 00:00:00 2001
From: Aaron Steinfeld <aaron@traceable.ai>
Date: Sat, 19 Mar 2022 09:54:29 -0400
Subject: [PATCH 2/2] test: update test limits

---
 .../data/api-trace-detail-data-source.model.test.ts         | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts
index d01fd0376..425d40831 100644
--- a/projects/observability/src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts
+++ b/projects/observability/src/shared/dashboard/widgets/trace-detail/data/api-trace-detail-data-source.model.test.ts
@@ -79,7 +79,7 @@ describe('API Trace detail data source model', () => {
       expect.objectContaining({
         requestType: TRACE_GQL_REQUEST,
         traceId: 'test',
-        spanLimit: 0,
+        spanLimit: 1000,
         timestamp: undefined,
         traceProperties: expect.arrayContaining([
           expect.objectContaining({ name: 'tags' }),
@@ -99,7 +99,7 @@ describe('API Trace detail data source model', () => {
       expect.objectContaining({
         requestType: TRACE_GQL_REQUEST,
         traceId: 'test',
-        spanLimit: 0,
+        spanLimit: 1000,
         timestamp: undefined,
         traceProperties: expect.arrayContaining([
           expect.objectContaining({ name: 'tags' }),
@@ -119,7 +119,7 @@ describe('API Trace detail data source model', () => {
       expect.objectContaining({
         requestType: TRACE_GQL_REQUEST,
         traceId: 'test',
-        spanLimit: 0,
+        spanLimit: 1000,
         timestamp: new Date(1568907645141),
         traceProperties: expect.arrayContaining([
           expect.objectContaining({ name: 'tags' }),