From 4aff8ef15a0c65edc68349fc579e695a628e6f2f Mon Sep 17 00:00:00 2001 From: Sandeep Kumar Sharma Date: Wed, 12 May 2021 16:14:46 +0530 Subject: [PATCH 1/2] fix: style fixes --- .../components/src/list-view/list-view.component.scss | 6 +++--- .../components/log-events/log-events-table.component.scss | 8 +++++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/projects/components/src/list-view/list-view.component.scss b/projects/components/src/list-view/list-view.component.scss index f55fd0ca5..9f0ea57bb 100644 --- a/projects/components/src/list-view/list-view.component.scss +++ b/projects/components/src/list-view/list-view.component.scss @@ -3,7 +3,7 @@ $key-width: 40%; $value-width: 60%; -$margin-left: 12px; +$horizontal-offset: 12px; @mixin grid-view { width: 100%; @@ -34,7 +34,7 @@ $margin-left: 12px; .header-key-label, .header-value-label { @include overline; - margin-left: $margin-left; + padding: 0px $horizontal-offset; width: 100%; } } @@ -51,7 +51,7 @@ $margin-left: 12px; width: 100%; display: flex; align-items: center; - margin-left: $margin-left; + padding: 0px $horizontal-offset; } .key { font-weight: 500; diff --git a/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss b/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss index c44b410dc..dfecfe067 100644 --- a/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss +++ b/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss @@ -1,7 +1,13 @@ @import 'font'; .log-events-table { - margin-top: 25px; + padding-top: 25px; + width: 100%; + height: 100%; + + ht-table { + max-height: 100%; + } } .content { From 8c843607d1ae064cec76de62abc79062758085a9 Mon Sep 17 00:00:00 2001 From: Sandeep Kumar Sharma Date: Wed, 12 May 2021 17:06:10 +0530 Subject: [PATCH 2/2] fix: addressing review comments --- projects/components/src/list-view/list-view.component.scss | 4 ++-- .../components/log-events/log-events-table.component.scss | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/components/src/list-view/list-view.component.scss b/projects/components/src/list-view/list-view.component.scss index 9f0ea57bb..e52468408 100644 --- a/projects/components/src/list-view/list-view.component.scss +++ b/projects/components/src/list-view/list-view.component.scss @@ -34,7 +34,7 @@ $horizontal-offset: 12px; .header-key-label, .header-value-label { @include overline; - padding: 0px $horizontal-offset; + padding: 0 $horizontal-offset; width: 100%; } } @@ -51,7 +51,7 @@ $horizontal-offset: 12px; width: 100%; display: flex; align-items: center; - padding: 0px $horizontal-offset; + padding: 0 $horizontal-offset; } .key { font-weight: 500; diff --git a/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss b/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss index dfecfe067..4ba2962ed 100644 --- a/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss +++ b/projects/distributed-tracing/src/shared/components/log-events/log-events-table.component.scss @@ -1,7 +1,7 @@ @import 'font'; .log-events-table { - padding-top: 25px; + padding-top: 24px; width: 100%; height: 100%;