From 0e404c0e80a243576fba7bdd56b4b1f6b66f1dc7 Mon Sep 17 00:00:00 2001
From: Arjunlal B <arjun@traceable.ai>
Date: Sat, 3 Jul 2021 14:46:36 +0530
Subject: [PATCH 1/4] fix: menu dropdown should not be shown if no items in the
 list

---
 .../src/menu-dropdown/menu-dropdown.component.test.ts     | 8 ++++++++
 .../src/menu-dropdown/menu-dropdown.component.ts          | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
index bef150898..0efb79ea2 100644
--- a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
+++ b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
@@ -78,4 +78,12 @@ describe('Menu dropdown Component', () => {
 
     expect(onClickSpy).not.toHaveBeenCalled();
   });
+
+  test('should not show the dropdown if no items to show.', () => {
+    spectator = createHost(
+      `<ht-menu-dropdown label="Settings" icon="${IconType.MoreHorizontal}"></ht-menu-dropdown>`,
+    );
+
+    expect(spectator.query('ht-popover-trigger')).not.toExist();
+  });
 });
diff --git a/projects/components/src/menu-dropdown/menu-dropdown.component.ts b/projects/components/src/menu-dropdown/menu-dropdown.component.ts
index b9177f8bb..077bb8d87 100644
--- a/projects/components/src/menu-dropdown/menu-dropdown.component.ts
+++ b/projects/components/src/menu-dropdown/menu-dropdown.component.ts
@@ -9,7 +9,7 @@ import { MenuItemComponent } from './menu-item/menu-item.component';
   changeDetection: ChangeDetectionStrategy.OnPush,
   template: `
     <ht-event-blocker event="click" [enabled]="true">
-      <ht-popover [closeOnClick]="true" [disabled]="this.disabled">
+      <ht-popover [closeOnClick]="true" [disabled]="this.disabled" *ngIf="this.items.length > 0">
         <ht-popover-trigger>
           <div class="trigger-content" [ngClass]="{ disabled: this.disabled, labeled: !!this.label }">
             <ht-label *ngIf="this.label" class="trigger-label" [label]="this.label"> </ht-label>

From bf55e3e2e53d50d0679c6e4c8560bbd2b8691cbd Mon Sep 17 00:00:00 2001
From: Arjunlal B <arjun@traceable.ai>
Date: Sat, 3 Jul 2021 15:38:06 +0530
Subject: [PATCH 2/4] fix: fix lint issue

---
 .../src/menu-dropdown/menu-dropdown.component.test.ts         | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
index 0efb79ea2..f9e4d1437 100644
--- a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
+++ b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
@@ -80,9 +80,7 @@ describe('Menu dropdown Component', () => {
   });
 
   test('should not show the dropdown if no items to show.', () => {
-    spectator = createHost(
-      `<ht-menu-dropdown label="Settings" icon="${IconType.MoreHorizontal}"></ht-menu-dropdown>`,
-    );
+    spectator = createHost(`<ht-menu-dropdown label="Settings" icon="${IconType.MoreHorizontal}"></ht-menu-dropdown>`);
 
     expect(spectator.query('ht-popover-trigger')).not.toExist();
   });

From ea000fa90a401a3571c8e1220e74e11ffb3557aa Mon Sep 17 00:00:00 2001
From: Arjunlal B <arjun@traceable.ai>
Date: Sat, 3 Jul 2021 18:02:38 +0530
Subject: [PATCH 3/4] fix: update check

---
 .../components/src/menu-dropdown/menu-dropdown.component.ts     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/projects/components/src/menu-dropdown/menu-dropdown.component.ts b/projects/components/src/menu-dropdown/menu-dropdown.component.ts
index 077bb8d87..04bba2b34 100644
--- a/projects/components/src/menu-dropdown/menu-dropdown.component.ts
+++ b/projects/components/src/menu-dropdown/menu-dropdown.component.ts
@@ -9,7 +9,7 @@ import { MenuItemComponent } from './menu-item/menu-item.component';
   changeDetection: ChangeDetectionStrategy.OnPush,
   template: `
     <ht-event-blocker event="click" [enabled]="true">
-      <ht-popover [closeOnClick]="true" [disabled]="this.disabled" *ngIf="this.items.length > 0">
+      <ht-popover [closeOnClick]="true" [disabled]="this.disabled" *ngIf="this.items?.length > 0">
         <ht-popover-trigger>
           <div class="trigger-content" [ngClass]="{ disabled: this.disabled, labeled: !!this.label }">
             <ht-label *ngIf="this.label" class="trigger-label" [label]="this.label"> </ht-label>

From ec53209927e1e149d8f8417ac7289645467386f8 Mon Sep 17 00:00:00 2001
From: Arjunlal B <arjun@traceable.ai>
Date: Sun, 4 Jul 2021 23:16:05 +0530
Subject: [PATCH 4/4] fix: update test

---
 .../src/menu-dropdown/menu-dropdown.component.test.ts         | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
index f9e4d1437..a2f18e1d8 100644
--- a/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
+++ b/projects/components/src/menu-dropdown/menu-dropdown.component.test.ts
@@ -26,9 +26,7 @@ describe('Menu dropdown Component', () => {
 
   test('should display trigger content as expected', () => {
     spectator = createHost(
-      `
-    <ht-menu-dropdown label="Settings" icon="${IconType.MoreHorizontal}">
-        </ht-menu-dropdown>`
+      `<ht-menu-dropdown label="Settings" icon="${IconType.MoreHorizontal}"><ht-menu-item label="Option 1"></ht-menu-item></ht-menu-dropdown>`
     );
 
     expect(spectator.query('.trigger-content')).toExist();