From e7960dfe096fd3b72129e58edde3a177e40aeb51 Mon Sep 17 00:00:00 2001 From: Jyothish Jose Date: Wed, 14 Jul 2021 15:43:11 +0530 Subject: [PATCH 1/3] fix: wrong tooltip in radar chart in firefox --- .../components/radar/tooltip/radial-data-lookup-strategy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts index e9d0acc72..1df3a70b1 100644 --- a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts +++ b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts @@ -15,7 +15,7 @@ export class RadialDataLookupStrategy { public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) { this.radialBisector = bisector(axisData => axisData.axisRadian); - this.radialAxisData = clone(radialAxisData); + this.radialAxisData = clone(radialAxisData.sort(axisData => axisData.axisRadian)); this.addCyclicRedundancy(); } From 80139ba27580cc0f123e7c5bd1ee138e49fbd3c3 Mon Sep 17 00:00:00 2001 From: Jyothish Jose Date: Thu, 15 Jul 2021 11:07:03 +0530 Subject: [PATCH 2/3] fix: wrong tooltip in radar chart in firefox --- .../components/radar/tooltip/radial-data-lookup-strategy.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts index 1df3a70b1..b5246e221 100644 --- a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts +++ b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts @@ -15,7 +15,8 @@ export class RadialDataLookupStrategy { public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) { this.radialBisector = bisector(axisData => axisData.axisRadian); - this.radialAxisData = clone(radialAxisData.sort(axisData => axisData.axisRadian)); + this.radialAxisData = clone(radialAxisData); + this.radialAxisData = this.radialAxisData.sort(axisData => axisData.axisRadian); this.addCyclicRedundancy(); } @@ -41,6 +42,7 @@ export class RadialDataLookupStrategy { const leftValue = this.radialAxisData[insertionIndex - 1] as RadarAxisData | undefined; const rightValue = this.radialAxisData[insertionIndex] as RadarAxisData | undefined; + if (leftValue === undefined) { // No values to the left. Target is smallest value. return rightValue; From 5e093638dd868687f1be4645ba1cd1fc6945f4c6 Mon Sep 17 00:00:00 2001 From: Jyothish Jose Date: Thu, 15 Jul 2021 17:29:42 +0530 Subject: [PATCH 3/3] fix: wrong tooltip in radar chart in firefox --- .../components/radar/tooltip/radial-data-lookup-strategy.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts index b5246e221..e112683e6 100644 --- a/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts +++ b/projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts @@ -15,8 +15,7 @@ export class RadialDataLookupStrategy { public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) { this.radialBisector = bisector(axisData => axisData.axisRadian); - this.radialAxisData = clone(radialAxisData); - this.radialAxisData = this.radialAxisData.sort(axisData => axisData.axisRadian); + this.radialAxisData = clone(radialAxisData).sort(axisData => axisData.axisRadian); this.addCyclicRedundancy(); } @@ -42,7 +41,6 @@ export class RadialDataLookupStrategy { const leftValue = this.radialAxisData[insertionIndex - 1] as RadarAxisData | undefined; const rightValue = this.radialAxisData[insertionIndex] as RadarAxisData | undefined; - if (leftValue === undefined) { // No values to the left. Target is smallest value. return rightValue;