From 5ebaa475e9dacd3a488467b1fa4adae1267b5e12 Mon Sep 17 00:00:00 2001 From: Ronak Date: Thu, 31 Aug 2023 15:58:45 +0530 Subject: [PATCH] chore: enhance the test case for bool type --- view-creator-framework/src/test/avro/TestView.avdl | 1 + .../org/hypertrace/core/viewcreator/pinot/PinotUtilsTest.java | 3 ++- .../src/test/resources/sample-view-generation-spec.conf | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/view-creator-framework/src/test/avro/TestView.avdl b/view-creator-framework/src/test/avro/TestView.avdl index 2cf63a1..239988c 100644 --- a/view-creator-framework/src/test/avro/TestView.avdl +++ b/view-creator-framework/src/test/avro/TestView.avdl @@ -10,5 +10,6 @@ protocol TestViewProtocol { array friends = []; map properties = {}; long time_taken_millis = 0; + boolean is_external = false; } } \ No newline at end of file diff --git a/view-creator-framework/src/test/java/org/hypertrace/core/viewcreator/pinot/PinotUtilsTest.java b/view-creator-framework/src/test/java/org/hypertrace/core/viewcreator/pinot/PinotUtilsTest.java index f88edf7..0117096 100644 --- a/view-creator-framework/src/test/java/org/hypertrace/core/viewcreator/pinot/PinotUtilsTest.java +++ b/view-creator-framework/src/test/java/org/hypertrace/core/viewcreator/pinot/PinotUtilsTest.java @@ -62,7 +62,7 @@ public void testCreatePinotSchema() { LOGGER.info("Convert Pinot Schema from View: {}", pinotSchema); assertEquals(viewCreationSpec.getViewName(), pinotSchema.getSchemaName()); // creation_time_millis not included in dimension columns - assertEquals(5, pinotSchema.getDimensionNames().size()); + assertEquals(6, pinotSchema.getDimensionNames().size()); assertEquals(1, pinotSchema.getMetricFieldSpecs().size()); assertEquals(DataType.STRING, pinotSchema.getDimensionSpec("name").getDataType()); assertEquals(DataType.BYTES, pinotSchema.getDimensionSpec("id_sha").getDataType()); @@ -101,6 +101,7 @@ public void testCreatePinotSchema() { new DateTimeFormatSpec(dateTimeFieldSpec.getFormat()).getColumnUnit()); assertEquals(DataType.LONG, dateTimeFieldSpec.getDataType()); assertEquals(0L, dateTimeFieldSpec.getDefaultNullValue()); + assertEquals(DataType.BOOLEAN, pinotSchema.getDimensionSpec("is_external").getDataType()); } @Test diff --git a/view-creator-framework/src/test/resources/sample-view-generation-spec.conf b/view-creator-framework/src/test/resources/sample-view-generation-spec.conf index ac689e6..143e778 100644 --- a/view-creator-framework/src/test/resources/sample-view-generation-spec.conf +++ b/view-creator-framework/src/test/resources/sample-view-generation-spec.conf @@ -13,7 +13,7 @@ pinot = { sortedColumn = "tenant_id" timeColumn = creation_time_millis timeUnit = MILLISECONDS - dimensionColumns = [name, creation_time_millis, id_sha, friends, properties__KEYS, properties__VALUES] + dimensionColumns = [name, creation_time_millis, id_sha, friends, properties__KEYS, properties__VALUES, is_external] dateTimeColumns = [start_time_millis, end_time_millis, bucket_start_time_millis] columnsMaxLength = {id_sha: 64} metricColumns = [time_taken_millis]