-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix image description info events #12781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
can someone test this |
|
Does not seem to fix the issue. In my case, colors are off only when mpv is in fullscreen. |
|
Fullscreen can look different when DS or passthrough is active or when HDR activates in fullscreen. Also if SDR/HDR switch is triggered then it'll send a new preferred image description which is handled by mpv and can result in color changes. |
|
DS is active by default, and I don't have HDR enabled, nor HDR display capabilities. I guess mpv should take that into account even though the source video is HDR. |
|
That's not an mpv fault that CM is different with DS active. |
|
Needs a retest. DS and cm_fs_passthrough should be off because they aren't fully supported. |
Describe your PR, what does it fix/add?
Fixes image description info events according to proto description. Should fix #12775
Stores EDID primaries and luminances as target values.
Always sends some
target_primariesas suggested by https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/305Might fix #12810, needs testing
Applies HDR edid overrides to HDR modes only.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
chromium and other EXT_LINEAR apps might need a HDR image description for correct CM. chromium currently sets an EXT_LINEAR image description with SDR luminances if it gets an SDR image description as preferred one. That trips both SDR and HDR mode.
quirks:prefer_hdr = 1fixes this behaviour. The resulting brightness with a single monitor will use the value from EDID or frommonitorv2:max_avg_luminanceoverride. With multiple monitors it'll use the default HDR luminance 203.Might be reasonable to change the default SDR luminance to 203 as it seems to be the desired value for SDR -> HDR transformation and will fix chromium without the need to set
quirks:prefer_hdr = 1. But it can break some other apps.Is it ready for merging, or does it need work?
Ready