From 2a0d55e0f393533bf3e43deacd991e9b877b1b43 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:17:18 +0100 Subject: [PATCH 01/15] add version --- .github/workflows/idefix-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 579fdd5b..5149d15a 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -10,7 +10,7 @@ on: jobs: Hydro: runs-on: self-hosted - uses: actions/checkout + uses: actions/checkout@v3 steps: - run: cd test - run: ./checks_hydro.sh $TEST_OPTIONS From e11a397a761acc9e4f8853bb2871db3b52dd8e4d Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:24:17 +0100 Subject: [PATCH 02/15] Ensure that we can do a checkout --- .github/workflows/idefix-ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 5149d15a..d714dfb3 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -1,5 +1,5 @@ name: Idefix CIs -run-name: ${{ github.actor }} is learning GitHub Actions +run-name: Idefix CIs on: workflow_dispatch: push: @@ -10,7 +10,8 @@ on: jobs: Hydro: runs-on: self-hosted - uses: actions/checkout@v3 steps: + - name: Check out repo + uses: actions/checkout@v3 - run: cd test - run: ./checks_hydro.sh $TEST_OPTIONS From 43df6ff49f66ea5f2002625f90ce8cb2da836638 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:25:31 +0100 Subject: [PATCH 03/15] indentation --- .github/workflows/idefix-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index d714dfb3..5315faf9 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -12,6 +12,6 @@ jobs: runs-on: self-hosted steps: - name: Check out repo - uses: actions/checkout@v3 + uses: actions/checkout@v3 - run: cd test - run: ./checks_hydro.sh $TEST_OPTIONS From 5cb5de8ab1ea8acad236de5298499d490a604b35 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:28:03 +0100 Subject: [PATCH 04/15] Ensure we are in the right directory --- .github/workflows/idefix-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 5315faf9..373fafd3 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -13,5 +13,5 @@ jobs: steps: - name: Check out repo uses: actions/checkout@v3 - - run: cd test - - run: ./checks_hydro.sh $TEST_OPTIONS + - name: Run Hydro test + - run: cd test && ./checks_hydro.sh $TEST_OPTIONS From f92343f07865b3ec6e912427a18d25d3ec262efe Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:30:45 +0100 Subject: [PATCH 05/15] Update idefix-ci.yml --- .github/workflows/idefix-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 373fafd3..ac28257a 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -14,4 +14,4 @@ jobs: - name: Check out repo uses: actions/checkout@v3 - name: Run Hydro test - - run: cd test && ./checks_hydro.sh $TEST_OPTIONS + run: cd test && ./checks_hydro.sh $TEST_OPTIONS From 27933e8a6d2e4904517cd4dc36fcba171a194dc2 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:39:47 +0100 Subject: [PATCH 06/15] Checkout submodules --- .github/workflows/idefix-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index ac28257a..9681e63f 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -13,5 +13,7 @@ jobs: steps: - name: Check out repo uses: actions/checkout@v3 + with: + submodules: recursive - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS From ab0710928046a778682c0ba2aa9e529a3d5b1be6 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:43:06 +0100 Subject: [PATCH 07/15] add git lfs during checkout --- .github/workflows/idefix-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 9681e63f..082c14a0 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -8,12 +8,13 @@ on: pull_request: jobs: - Hydro: + Hydrodynamics: runs-on: self-hosted steps: - name: Check out repo uses: actions/checkout@v3 with: submodules: recursive + lfs: 'true' - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS From 96dc6a3000810f2c572f03dd0331f311cf05a4ba Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:49:11 +0100 Subject: [PATCH 08/15] more lfs --- .github/workflows/idefix-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 082c14a0..b30d22b5 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -14,7 +14,7 @@ jobs: - name: Check out repo uses: actions/checkout@v3 with: + lfs: true submodules: recursive - lfs: 'true' - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS From f36a171c41dfd5dd2ace248d9a2fa623b609bb35 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 14:54:51 +0100 Subject: [PATCH 09/15] Manually add git lfs pull https://github.com/actions/checkout/issues/270 --- .github/workflows/idefix-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index b30d22b5..a1d0e024 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -16,5 +16,6 @@ jobs: with: lfs: true submodules: recursive + - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS From 2e0d9db281c4c329f17f3d1054a1238e79610161 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 15:21:23 +0100 Subject: [PATCH 10/15] full blown test suite --- .github/workflows/idefix-ci.yml | 110 ++++++++++++++++++++++++++++++++ 1 file changed, 110 insertions(+) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index a1d0e024..92d14c1f 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -8,7 +8,18 @@ on: pull_request: jobs: + Linter: + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: false + - run: pre-commit install + - run: pre-commit run --all-files + Hydrodynamics: + needs: Linter runs-on: self-hosted steps: - name: Check out repo @@ -16,6 +27,105 @@ jobs: with: lfs: true submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS + + Magneto-Hydrodynamics: + needs: Linter + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_mhd.sh $TEST_OPTIONS + + MPI: + needs: [Linter] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_mpi.sh $TEST_OPTIONS + + VectorPotential: + needs: [Linter, MPI] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_vector_potential.sh $TEST_OPTIONS + + HighOrder: + needs: [Linter, MPI] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_highorder.sh $TEST_OPTIONS + + SinglePrecision: + needs: [Linter, MPI] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_singleprecision.sh $TEST_OPTIONS + + Examples: + needs: [Linter, MPI] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_examples.sh $TEST_OPTIONS + + Utils: + needs: [Linter, MPI] + runs-on: self-hosted + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + lfs: true + submodules: recursive + # Manually do a git LFS https://github.com/actions/checkout/issues/270 + - run: git lfs pull + - name: Run Hydro test + run: cd test && ./checks_utils.sh $TEST_OPTIONS From 4896bd889c88a54628341ea58c0a1c33063fcb36 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 15:24:43 +0100 Subject: [PATCH 11/15] update dependencies --- .github/workflows/idefix-ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 92d14c1f..e061d321 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -47,7 +47,7 @@ jobs: run: cd test && ./checks_mhd.sh $TEST_OPTIONS MPI: - needs: [Linter] + needs: Linter runs-on: self-hosted steps: - name: Check out repo @@ -61,7 +61,7 @@ jobs: run: cd test && ./checks_mpi.sh $TEST_OPTIONS VectorPotential: - needs: [Linter, MPI] + needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted steps: - name: Check out repo @@ -75,7 +75,7 @@ jobs: run: cd test && ./checks_vector_potential.sh $TEST_OPTIONS HighOrder: - needs: [Linter, MPI] + needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted steps: - name: Check out repo @@ -89,7 +89,7 @@ jobs: run: cd test && ./checks_highorder.sh $TEST_OPTIONS SinglePrecision: - needs: [Linter, MPI] + needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted steps: - name: Check out repo @@ -103,7 +103,7 @@ jobs: run: cd test && ./checks_singleprecision.sh $TEST_OPTIONS Examples: - needs: [Linter, MPI] + needs: [VectorPotential, HighOrder,SinglePrecision] runs-on: self-hosted steps: - name: Check out repo @@ -117,7 +117,7 @@ jobs: run: cd test && ./checks_examples.sh $TEST_OPTIONS Utils: - needs: [Linter, MPI] + needs: [VectorPotential, HighOrder,SinglePrecision] runs-on: self-hosted steps: - name: Check out repo From 7dc781aa13b653a55d0d3997629b201bd82202a7 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 15:31:24 +0100 Subject: [PATCH 12/15] remove whitespace, add fork prevention --- .github/workflows/idefix-ci.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index e061d321..3c33d71e 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -6,9 +6,11 @@ on: branches: - main pull_request: - + jobs: Linter: + # Don't do this in forks + if: github.repository == 'idefix-code/idefix' runs-on: self-hosted steps: - name: Check out repo @@ -17,7 +19,7 @@ jobs: lfs: false - run: pre-commit install - run: pre-commit run --all-files - + Hydrodynamics: needs: Linter runs-on: self-hosted @@ -31,7 +33,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_hydro.sh $TEST_OPTIONS - + Magneto-Hydrodynamics: needs: Linter runs-on: self-hosted @@ -59,7 +61,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_mpi.sh $TEST_OPTIONS - + VectorPotential: needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted @@ -73,7 +75,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_vector_potential.sh $TEST_OPTIONS - + HighOrder: needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted @@ -87,7 +89,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_highorder.sh $TEST_OPTIONS - + SinglePrecision: needs: [Linter, Hydrodynamics, Magneto-Hydrodynamics, MPI] runs-on: self-hosted @@ -101,7 +103,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_singleprecision.sh $TEST_OPTIONS - + Examples: needs: [VectorPotential, HighOrder,SinglePrecision] runs-on: self-hosted @@ -115,7 +117,7 @@ jobs: - run: git lfs pull - name: Run Hydro test run: cd test && ./checks_examples.sh $TEST_OPTIONS - + Utils: needs: [VectorPotential, HighOrder,SinglePrecision] runs-on: self-hosted From 4f6ee43b75d2268ec455072591e8c9d9bd8a1011 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 15:32:48 +0100 Subject: [PATCH 13/15] fix lint --- .github/workflows/idefix-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 3c33d71e..baa0138a 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -18,7 +18,7 @@ jobs: with: lfs: false - run: pre-commit install - - run: pre-commit run --all-files + - run: pre-commit run --all-files Hydrodynamics: needs: Linter From eb5fe64bc8bd4d4550210277ffc0e22d5deb4cbf Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 15:37:01 +0100 Subject: [PATCH 14/15] change run names --- .github/workflows/idefix-ci.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index baa0138a..3f8da8b6 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -45,7 +45,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run MHD test run: cd test && ./checks_mhd.sh $TEST_OPTIONS MPI: @@ -59,7 +59,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run MPI test run: cd test && ./checks_mpi.sh $TEST_OPTIONS VectorPotential: @@ -73,7 +73,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run Vector Potential test run: cd test && ./checks_vector_potential.sh $TEST_OPTIONS HighOrder: @@ -87,7 +87,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run high order test run: cd test && ./checks_highorder.sh $TEST_OPTIONS SinglePrecision: @@ -101,7 +101,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run single precision test run: cd test && ./checks_singleprecision.sh $TEST_OPTIONS Examples: @@ -115,7 +115,7 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run examples test run: cd test && ./checks_examples.sh $TEST_OPTIONS Utils: @@ -129,5 +129,5 @@ jobs: submodules: recursive # Manually do a git LFS https://github.com/actions/checkout/issues/270 - run: git lfs pull - - name: Run Hydro test + - name: Run utils test run: cd test && ./checks_utils.sh $TEST_OPTIONS From 12c5173b0670332f027baceaddee514d7540b796 Mon Sep 17 00:00:00 2001 From: Geoffroy Lesur Date: Mon, 23 Jan 2023 17:19:31 +0100 Subject: [PATCH 15/15] remove run name --- .github/workflows/idefix-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/idefix-ci.yml b/.github/workflows/idefix-ci.yml index 3f8da8b6..c3e4d18a 100644 --- a/.github/workflows/idefix-ci.yml +++ b/.github/workflows/idefix-ci.yml @@ -1,5 +1,4 @@ name: Idefix CIs -run-name: Idefix CIs on: workflow_dispatch: push: