From 806256b848e0c05530d1c69e9dc8c365d4c83e9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Tue, 23 Jan 2024 13:52:08 +0100 Subject: [PATCH 1/3] test: split as_biadjacency_matrix() tests --- tests/testthat/test-get.incidence.R | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/testthat/test-get.incidence.R b/tests/testthat/test-get.incidence.R index b4f820dfdee..03cc9948fc0 100644 --- a/tests/testthat/test-get.incidence.R +++ b/tests/testthat/test-get.incidence.R @@ -1,14 +1,15 @@ -test_that("as_biadjacency_matrix works", { - ## Dense +test_that("as_biadjacency_matrix works -- dense", { I <- matrix(sample(0:1, 35, replace = TRUE, prob = c(3, 1)), ncol = 5) g <- graph_from_biadjacency_matrix(I) I2 <- as_biadjacency_matrix(g) expect_that(I, is_equivalent_to(I2)) expect_that(rownames(I2), equals(as.character(1:7))) expect_that(colnames(I2), equals(as.character(8:12))) +}) - ## Sparse - +test_that("as_biadjacency_matrix works -- sparse", { + I <- matrix(sample(0:1, 35, replace = TRUE, prob = c(3, 1)), ncol = 5) + g <- graph_from_biadjacency_matrix(I) I3 <- as_biadjacency_matrix(g, sparse = TRUE) expect_that(as.matrix(I3), is_equivalent_to(I)) expect_that(rownames(I3), equals(as.character(1:7))) From 5b8e2dc5b321b8855c628b0038f42a3a22b46fac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Tue, 23 Jan 2024 13:52:54 +0100 Subject: [PATCH 2/3] :nail_care: --- tests/testthat/test-get.incidence.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/test-get.incidence.R b/tests/testthat/test-get.incidence.R index 03cc9948fc0..b29c20bdbdc 100644 --- a/tests/testthat/test-get.incidence.R +++ b/tests/testthat/test-get.incidence.R @@ -1,4 +1,4 @@ -test_that("as_biadjacency_matrix works -- dense", { +test_that("as_biadjacency_matrix() works -- dense", { I <- matrix(sample(0:1, 35, replace = TRUE, prob = c(3, 1)), ncol = 5) g <- graph_from_biadjacency_matrix(I) I2 <- as_biadjacency_matrix(g) @@ -7,7 +7,7 @@ test_that("as_biadjacency_matrix works -- dense", { expect_that(colnames(I2), equals(as.character(8:12))) }) -test_that("as_biadjacency_matrix works -- sparse", { +test_that("as_biadjacency_matrix() works -- sparse", { I <- matrix(sample(0:1, 35, replace = TRUE, prob = c(3, 1)), ncol = 5) g <- graph_from_biadjacency_matrix(I) I3 <- as_biadjacency_matrix(g, sparse = TRUE) From 36a5e496d0b91e3b45b03f05d10d3d775f4562d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABlle=20Salmon?= Date: Tue, 23 Jan 2024 14:12:07 +0100 Subject: [PATCH 3/3] use specific expectations --- tests/testthat/test-get.incidence.R | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testthat/test-get.incidence.R b/tests/testthat/test-get.incidence.R index b29c20bdbdc..bf71a23d7a4 100644 --- a/tests/testthat/test-get.incidence.R +++ b/tests/testthat/test-get.incidence.R @@ -3,8 +3,8 @@ test_that("as_biadjacency_matrix() works -- dense", { g <- graph_from_biadjacency_matrix(I) I2 <- as_biadjacency_matrix(g) expect_that(I, is_equivalent_to(I2)) - expect_that(rownames(I2), equals(as.character(1:7))) - expect_that(colnames(I2), equals(as.character(8:12))) + expect_identical(rownames(I2), as.character(1:7)) + expect_identical(colnames(I2), as.character(8:12)) }) test_that("as_biadjacency_matrix() works -- sparse", { @@ -12,6 +12,6 @@ test_that("as_biadjacency_matrix() works -- sparse", { g <- graph_from_biadjacency_matrix(I) I3 <- as_biadjacency_matrix(g, sparse = TRUE) expect_that(as.matrix(I3), is_equivalent_to(I)) - expect_that(rownames(I3), equals(as.character(1:7))) - expect_that(colnames(I3), equals(as.character(8:12))) + expect_identical(rownames(I3), as.character(1:7)) + expect_identical(colnames(I3), as.character(8:12)) })