From bc48c40633c7d88f35b5b0a24271361cbc80b4e9 Mon Sep 17 00:00:00 2001
From: schochastics <david@schochastics.net>
Date: Thu, 3 Jul 2025 10:12:53 +0200
Subject: [PATCH] fixed vertex attribute type conversion

---
 R/operators.R                   | 12 +++++++++---
 tests/testthat/test-operators.R | 24 +++++++++++++++++++++++-
 2 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/R/operators.R b/R/operators.R
index 42298800a74..8722413f9a1 100644
--- a/R/operators.R
+++ b/R/operators.R
@@ -244,13 +244,19 @@ disjoint_union <- function(...) {
     noattr <- setdiff(names(attr), names(va)) # existint and missing
     newattr <- setdiff(names(va), names(attr)) # new
     for (a in seq_along(exattr)) {
-      attr[[exattr[a]]] <- c(attr[[exattr[a]]], va[[exattr[a]]])
+      attr[[exattr[a]]] <- vctrs::vec_c(attr[[exattr[a]]], va[[exattr[a]]])
     }
     for (a in seq_along(noattr)) {
-      attr[[noattr[a]]] <- c(attr[[noattr[a]]], rep(NA, vc[i]))
+      attr[[noattr[a]]] <- vctrs::vec_c(
+        attr[[noattr[a]]],
+        vctrs::unspecified(vc[[i]])
+      )
     }
     for (a in seq_along(newattr)) {
-      attr[[newattr[a]]] <- c(rep(NA, cumvc[i]), va[[newattr[a]]])
+      attr[[newattr[a]]] <- vctrs::vec_c(
+        vctrs::unspecified(cumvc[[i]]),
+        va[[newattr[a]]]
+      )
     }
   }
   vertex.attributes(res) <- attr
diff --git a/tests/testthat/test-operators.R b/tests/testthat/test-operators.R
index 15cb124f9ce..afa804d5f16 100644
--- a/tests/testthat/test-operators.R
+++ b/tests/testthat/test-operators.R
@@ -30,7 +30,7 @@ test_that("disjoint_union() works", {
   )
 })
 
-test_that("disjoint_union() does not convert types", {
+test_that("disjoint_union() does not convert edge types", {
   # https://github.com/igraph/rigraph/issues/761
 
   g1 <- make_graph(~ A - -B)
@@ -44,6 +44,28 @@ test_that("disjoint_union() does not convert types", {
   expect_s3_class(E(u)$date, c("POSIXct", "POSIXt"))
 })
 
+test_that("disjoint_union() does not convert vertex types", {
+  # https://github.com/igraph/rigraph/issues/1640
+
+  g1 <- make_graph(~ B --C, C --D)
+  g2 <- make_graph(~ A --G, E --F)
+
+  g1 <- set_vertex_attr(
+    g1,
+    "date",
+    value = as.POSIXct(c("2021-01-01 01:01:01", "2022-02-02 02:02:02", "2023-03-03 03:03:03"))
+  )
+  g2 <- set_vertex_attr(
+    g2,
+    "date",
+    value = as.POSIXct(c("2021-03-03 03:03:03", "2022-04-04 04:04:04", "2023-05-05 05:05:05", "2024-06-06 06:06:06"))
+  )
+
+  u <- disjoint_union(g1, g2)
+
+  expect_s3_class(vertex_attr(u, "date"), c("POSIXct", "POSIXt"))
+})
+
 test_that("intersection() works", {
   g1 <- make_ring(10)
   g2 <- make_star(11, center = 11, mode = "undirected")