From 07ff85bccb48108b5fa0969e9fffa6ee90834eca Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Mon, 20 Apr 2026 13:31:45 +0200 Subject: [PATCH] Fix Dist::Zilla PkgVersion "no blank line" warnings When running the tests via `dzil test`, I found that the `Dist::Zilla` plugin `PkgVersion` gave several warnings like this: ``` [@DOY/PkgVersion] no blank line for $VERSION after package OX statement in lib/OX.pm line 1 ``` What this means is that `PkgVersion` expects an empty line after the `package` statement in each module file. This change adds this blank line to all of the affected files, hence removing the warnings and hence the distraction when running the test suite. --- lib/Bread/Board/LifeCycle/Request.pm | 1 + lib/OX.pm | 1 + lib/OX/Application.pm | 1 + lib/OX/Application/Role/Request.pm | 1 + lib/OX/Application/Role/RouteBuilder.pm | 1 + lib/OX/Application/Role/Router.pm | 1 + lib/OX/Application/Role/Router/Path/Router.pm | 1 + lib/OX/Application/Role/RouterConfig.pm | 1 + lib/OX/Application/Role/Sugar.pm | 1 + lib/OX/Meta/Conflict.pm | 1 + lib/OX/Meta/Middleware.pm | 1 + lib/OX/Meta/Mount.pm | 1 + lib/OX/Meta/Mount/App.pm | 1 + lib/OX/Meta/Mount/Class.pm | 1 + lib/OX/Meta/Role/Application.pm | 1 + lib/OX/Meta/Role/Application/ToClass.pm | 1 + lib/OX/Meta/Role/Application/ToInstance.pm | 1 + lib/OX/Meta/Role/Application/ToRole.pm | 1 + lib/OX/Meta/Role/Class.pm | 1 + lib/OX/Meta/Role/Composite.pm | 1 + lib/OX/Meta/Role/HasMiddleware.pm | 1 + lib/OX/Meta/Role/HasRouteBuilders.pm | 1 + lib/OX/Meta/Role/HasRoutes.pm | 1 + lib/OX/Meta/Role/Path.pm | 1 + lib/OX/Meta/Role/Role.pm | 1 + lib/OX/Meta/Route.pm | 1 + lib/OX/Request.pm | 1 + lib/OX/Response.pm | 1 + lib/OX/Role.pm | 1 + lib/OX/RouteBuilder.pm | 1 + lib/OX/RouteBuilder/Code.pm | 1 + lib/OX/RouteBuilder/ControllerAction.pm | 1 + lib/OX/RouteBuilder/HTTPMethod.pm | 1 + lib/OX/Types.pm | 1 + lib/OX/Util.pm | 1 + 35 files changed, 35 insertions(+) diff --git a/lib/Bread/Board/LifeCycle/Request.pm b/lib/Bread/Board/LifeCycle/Request.pm index c2a72d3..a5ab672 100644 --- a/lib/Bread/Board/LifeCycle/Request.pm +++ b/lib/Bread/Board/LifeCycle/Request.pm @@ -1,4 +1,5 @@ package Bread::Board::LifeCycle::Request; + use Moose::Role; use namespace::autoclean; # ABSTRACT: lifecycle for request-scoped services diff --git a/lib/OX.pm b/lib/OX.pm index 1b37dd2..b0958db 100644 --- a/lib/OX.pm +++ b/lib/OX.pm @@ -1,4 +1,5 @@ package OX; + use Moose::Exporter; use 5.010; # ABSTRACT: the hardest working two letters in Perl diff --git a/lib/OX/Application.pm b/lib/OX/Application.pm index 3b03c76..a730682 100644 --- a/lib/OX/Application.pm +++ b/lib/OX/Application.pm @@ -1,4 +1,5 @@ package OX::Application; + use Moose 2.0200; use namespace::autoclean; # ABSTRACT: base class for OX applications diff --git a/lib/OX/Application/Role/Request.pm b/lib/OX/Application/Role/Request.pm index 7e498bb..3d8d06f 100644 --- a/lib/OX/Application/Role/Request.pm +++ b/lib/OX/Application/Role/Request.pm @@ -1,4 +1,5 @@ package OX::Application::Role::Request; + use Moose::Role; use namespace::autoclean; # ABSTRACT: application role to allow the use of request and response objects diff --git a/lib/OX/Application/Role/RouteBuilder.pm b/lib/OX/Application/Role/RouteBuilder.pm index 303a253..839cd41 100644 --- a/lib/OX/Application/Role/RouteBuilder.pm +++ b/lib/OX/Application/Role/RouteBuilder.pm @@ -1,4 +1,5 @@ package OX::Application::Role::RouteBuilder; + use Moose::Role; use namespace::autoclean; # ABSTRACT: application role to configure a router based on a static description diff --git a/lib/OX/Application/Role/Router.pm b/lib/OX/Application/Role/Router.pm index 70df02a..1ec6042 100644 --- a/lib/OX/Application/Role/Router.pm +++ b/lib/OX/Application/Role/Router.pm @@ -1,4 +1,5 @@ package OX::Application::Role::Router; + use Moose::Role; use namespace::autoclean; # ABSTRACT: base role for applications with routers diff --git a/lib/OX/Application/Role/Router/Path/Router.pm b/lib/OX/Application/Role/Router/Path/Router.pm index e249c6f..f8be689 100644 --- a/lib/OX/Application/Role/Router/Path/Router.pm +++ b/lib/OX/Application/Role/Router/Path/Router.pm @@ -1,4 +1,5 @@ package OX::Application::Role::Router::Path::Router; + use Moose::Role; use namespace::autoclean; # ABSTRACT: implementation of OX::Application::Role::Router which uses Path::Router diff --git a/lib/OX/Application/Role/RouterConfig.pm b/lib/OX/Application/Role/RouterConfig.pm index 85d24d4..e5a8131 100644 --- a/lib/OX/Application/Role/RouterConfig.pm +++ b/lib/OX/Application/Role/RouterConfig.pm @@ -1,4 +1,5 @@ package OX::Application::Role::RouterConfig; + use Moose::Role; use namespace::autoclean; # ABSTRACT: adds some common shortcuts to route declarations from OX::Application::Role::RouteBuilder diff --git a/lib/OX/Application/Role/Sugar.pm b/lib/OX/Application/Role/Sugar.pm index 664bce3..8a42b6f 100644 --- a/lib/OX/Application/Role/Sugar.pm +++ b/lib/OX/Application/Role/Sugar.pm @@ -1,4 +1,5 @@ package OX::Application::Role::Sugar; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Conflict.pm b/lib/OX/Meta/Conflict.pm index a76af5b..680ea9b 100644 --- a/lib/OX/Meta/Conflict.pm +++ b/lib/OX/Meta/Conflict.pm @@ -1,4 +1,5 @@ package OX::Meta::Conflict; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Meta/Middleware.pm b/lib/OX/Meta/Middleware.pm index 8b20da2..483ee83 100644 --- a/lib/OX/Meta/Middleware.pm +++ b/lib/OX/Meta/Middleware.pm @@ -1,4 +1,5 @@ package OX::Meta::Middleware; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Meta/Mount.pm b/lib/OX/Meta/Mount.pm index 15e9f33..27837d0 100644 --- a/lib/OX/Meta/Mount.pm +++ b/lib/OX/Meta/Mount.pm @@ -1,4 +1,5 @@ package OX::Meta::Mount; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Meta/Mount/App.pm b/lib/OX/Meta/Mount/App.pm index 01999cf..ae96b6d 100644 --- a/lib/OX/Meta/Mount/App.pm +++ b/lib/OX/Meta/Mount/App.pm @@ -1,4 +1,5 @@ package OX::Meta::Mount::App; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Meta/Mount/Class.pm b/lib/OX/Meta/Mount/Class.pm index 76a46d7..95588db 100644 --- a/lib/OX/Meta/Mount/Class.pm +++ b/lib/OX/Meta/Mount/Class.pm @@ -1,4 +1,5 @@ package OX::Meta::Mount::Class; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Application.pm b/lib/OX/Meta/Role/Application.pm index 5db14e8..da25192 100644 --- a/lib/OX/Meta/Role/Application.pm +++ b/lib/OX/Meta/Role/Application.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Application; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Application/ToClass.pm b/lib/OX/Meta/Role/Application/ToClass.pm index c593c23..4d76e79 100644 --- a/lib/OX/Meta/Role/Application/ToClass.pm +++ b/lib/OX/Meta/Role/Application/ToClass.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Application::ToClass; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Application/ToInstance.pm b/lib/OX/Meta/Role/Application/ToInstance.pm index 19a826c..abde9d5 100644 --- a/lib/OX/Meta/Role/Application/ToInstance.pm +++ b/lib/OX/Meta/Role/Application/ToInstance.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Application::ToInstance; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Application/ToRole.pm b/lib/OX/Meta/Role/Application/ToRole.pm index 8fcf96c..b70b6b3 100644 --- a/lib/OX/Meta/Role/Application/ToRole.pm +++ b/lib/OX/Meta/Role/Application/ToRole.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Application::ToRole; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Class.pm b/lib/OX/Meta/Role/Class.pm index 7f8c4bb..a221315 100644 --- a/lib/OX/Meta/Role/Class.pm +++ b/lib/OX/Meta/Role/Class.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Class; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Composite.pm b/lib/OX/Meta/Role/Composite.pm index dd67743..a54c2fc 100644 --- a/lib/OX/Meta/Role/Composite.pm +++ b/lib/OX/Meta/Role/Composite.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Composite; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/HasMiddleware.pm b/lib/OX/Meta/Role/HasMiddleware.pm index 2a8e83e..6317761 100644 --- a/lib/OX/Meta/Role/HasMiddleware.pm +++ b/lib/OX/Meta/Role/HasMiddleware.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::HasMiddleware; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/HasRouteBuilders.pm b/lib/OX/Meta/Role/HasRouteBuilders.pm index b0a3737..423c4d6 100644 --- a/lib/OX/Meta/Role/HasRouteBuilders.pm +++ b/lib/OX/Meta/Role/HasRouteBuilders.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::HasRouteBuilders; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/HasRoutes.pm b/lib/OX/Meta/Role/HasRoutes.pm index 6536c6d..bd7e7e7 100644 --- a/lib/OX/Meta/Role/HasRoutes.pm +++ b/lib/OX/Meta/Role/HasRoutes.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::HasRoutes; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Path.pm b/lib/OX/Meta/Role/Path.pm index 65a938b..3048290 100644 --- a/lib/OX/Meta/Role/Path.pm +++ b/lib/OX/Meta/Role/Path.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Path; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Role/Role.pm b/lib/OX/Meta/Role/Role.pm index 3567e65..701fc54 100644 --- a/lib/OX/Meta/Role/Role.pm +++ b/lib/OX/Meta/Role/Role.pm @@ -1,4 +1,5 @@ package OX::Meta::Role::Role; + use Moose::Role; use namespace::autoclean; diff --git a/lib/OX/Meta/Route.pm b/lib/OX/Meta/Route.pm index 142bbc1..ff4f8ab 100644 --- a/lib/OX/Meta/Route.pm +++ b/lib/OX/Meta/Route.pm @@ -1,4 +1,5 @@ package OX::Meta::Route; + use Moose; use namespace::autoclean; diff --git a/lib/OX/Request.pm b/lib/OX/Request.pm index c7dede2..651e9fd 100644 --- a/lib/OX/Request.pm +++ b/lib/OX/Request.pm @@ -1,4 +1,5 @@ package OX::Request; + use Moose; use namespace::autoclean; # ABSTRACT: request object for OX diff --git a/lib/OX/Response.pm b/lib/OX/Response.pm index a682a28..17449c2 100644 --- a/lib/OX/Response.pm +++ b/lib/OX/Response.pm @@ -1,4 +1,5 @@ package OX::Response; + use Moose; use namespace::autoclean; # ABSTRACT: response object for OX diff --git a/lib/OX/Role.pm b/lib/OX/Role.pm index 96c1d6c..147460c 100644 --- a/lib/OX/Role.pm +++ b/lib/OX/Role.pm @@ -1,4 +1,5 @@ package OX::Role; + use Moose::Exporter; use 5.010; # ABSTRACT: declare roles for your OX applications diff --git a/lib/OX/RouteBuilder.pm b/lib/OX/RouteBuilder.pm index 52bc47b..d4b50b6 100644 --- a/lib/OX/RouteBuilder.pm +++ b/lib/OX/RouteBuilder.pm @@ -1,4 +1,5 @@ package OX::RouteBuilder; + use Moose::Role; use namespace::autoclean; # ABSTRACT: abstract role for classes that turn configuration into a route diff --git a/lib/OX/RouteBuilder/Code.pm b/lib/OX/RouteBuilder/Code.pm index 823c759..8f00806 100644 --- a/lib/OX/RouteBuilder/Code.pm +++ b/lib/OX/RouteBuilder/Code.pm @@ -1,4 +1,5 @@ package OX::RouteBuilder::Code; + use Moose; use namespace::autoclean; # ABSTRACT: OX::RouteBuilder which routes to a coderef diff --git a/lib/OX/RouteBuilder/ControllerAction.pm b/lib/OX/RouteBuilder/ControllerAction.pm index af5c262..4457fa8 100644 --- a/lib/OX/RouteBuilder/ControllerAction.pm +++ b/lib/OX/RouteBuilder/ControllerAction.pm @@ -1,4 +1,5 @@ package OX::RouteBuilder::ControllerAction; + use Moose; use namespace::autoclean; # ABSTRACT: OX::RouteBuilder which routes to an action method in a controller class diff --git a/lib/OX/RouteBuilder/HTTPMethod.pm b/lib/OX/RouteBuilder/HTTPMethod.pm index 6c4e28c..1510be3 100644 --- a/lib/OX/RouteBuilder/HTTPMethod.pm +++ b/lib/OX/RouteBuilder/HTTPMethod.pm @@ -1,4 +1,5 @@ package OX::RouteBuilder::HTTPMethod; + use Moose; use namespace::autoclean; # ABSTRACT: OX::RouteBuilder which routes to a method in a controller based on the HTTP method diff --git a/lib/OX/Types.pm b/lib/OX/Types.pm index 1c9b55f..9841408 100644 --- a/lib/OX/Types.pm +++ b/lib/OX/Types.pm @@ -1,4 +1,5 @@ package OX::Types; + use strict; use warnings; diff --git a/lib/OX/Util.pm b/lib/OX/Util.pm index e19ab8d..96fb127 100644 --- a/lib/OX/Util.pm +++ b/lib/OX/Util.pm @@ -1,4 +1,5 @@ package OX::Util; + use strict; use warnings;