Address various compiler warnings and deprecations (#1247)

Author: acoburn

api/src/main/java/com/inrupt/client/auth/Authenticator.java

@@ -53,5 +53,4 @@ public interface Authenticator {
      * @return the next stage of completion, containing the access token
      */
     CompletionStage<Credential> authenticate(Session session, Request request, Set<String> algorithms);
-
 }

api/src/main/java/com/inrupt/client/auth/ReactiveAuthorization.java

@@ -119,7 +119,7 @@ public CompletionStage<Optional<Credential>> negotiate(final Session session, fi
             // Use the first authenticator, sorted by priority
             authenticators.sort(comparator);
             final Authenticator auth = authenticators.get(0);
-            LOGGER.debug("Using {} authenticator", auth.getName());
+            LOGGER.debug("Using {} authenticator", auth);
             return session.authenticate(auth, request, algorithms);
         }
         return CompletableFuture.completedFuture(Optional.empty());

api/src/main/java/com/inrupt/client/spi/ClientProviderResolver.java

@@ -30,7 +30,7 @@
  */
 public abstract class ClientProviderResolver {
 
-    private static ClientProviderResolver instance = null;
+    private static ClientProviderResolver instance;
 
     /**
      * Get the {@link Client} for this application.

api/src/main/java/com/inrupt/client/spi/RDFFactory.java

@@ -30,7 +30,7 @@
  */
 public final class RDFFactory {
 
-    private static RDF instance = null;
+    private static RDF instance;
 
     /**
      * Find and return the RDF instance.

examples/spring-web/pom.xml

@@ -98,6 +98,15 @@
 
   <build>
     <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <systemPropertyVariables>
+            <logging.level.root>WARN</logging.level.root>
+          </systemPropertyVariables>
+        </configuration>
+      </plugin>
       <plugin>
         <!-- for building a jar -->
         <groupId>org.springframework.boot</groupId>

examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/controller/SolidController.java

@@ -57,11 +57,11 @@ public class SolidController {
     HttpSession httpSession;
 
     @GetMapping(value = "/resource", produces = "text/turtle")
-    public Resource getResource(final @AuthenticationPrincipal OAuth2User user, final @RequestParam URI uri) {
+    public SolidResource getResource(final @AuthenticationPrincipal OAuth2User user, final @RequestParam URI uri) {
         final var session = SessionUtils.asSession(user)
             .orElseThrow(() -> new OAuth2AuthenticationException(INVALID_TOKEN));
         try (final var resource = client.session(session).read(uri, SolidRDFSource.class)) {
-            return new Resource(resource);
+            return new SolidResource(resource);
         }
     }
 

…/examples/spring/web/model/Resource.java …ples/spring/web/model/SolidResource.javaexamples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/model/Resource.java renamed to examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/model/SolidResource.java examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/model/Resource.java renamed to examples/spring-web/src/main/java/com/inrupt/client/examples/spring/web/model/SolidResource.java

@@ -29,12 +29,12 @@
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.MediaType;
 
-public class Resource extends HttpEntity<byte[]> {
+public class SolidResource extends HttpEntity<byte[]> {
 
     private final HttpHeaders headers = new HttpHeaders();
     private final RDFSource resource;
 
-    public Resource(final RDFSource resource) {
+    public SolidResource(final RDFSource resource) {
         this.resource = resource;
         this.headers.setContentType(MediaType.valueOf(resource.getContentType()));
     }

examples/spring-web/src/main/resources/application.yml

@@ -2,6 +2,8 @@ logging:
   level:
     root: info
 spring:
+  main:
+    banner-mode: "off"
   security:
     oauth2:
       client:

examples/spring-web/src/test/java/com/inrupt/client/examples/spring/web/WebApplicationTests.java

@@ -47,7 +47,9 @@
 import org.springframework.security.oauth2.core.oidc.OidcIdToken;
 import org.springframework.security.oauth2.core.oidc.user.DefaultOidcUser;
 
-@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
+@SpringBootTest(
+    webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
+    classes = WebApplication.class)
 class WebApplicationTests {
 
     static final MockWebServer mockServer = new MockWebServer();

examples/springboot/src/main/java/com/inrupt/client/examples/springboot/ApplicationStartController.java

@@ -52,7 +52,6 @@ public class ApplicationStartController {
 
     private String userName;
 
-
     @GetMapping("/")
     public String index() {
         this.userName = null;
@@ -135,4 +134,4 @@ private void setUsernameFrontendState(final Model model) {
         model.addAttribute(FRONTEND_USERNAME, this.userName);
     }
 
-}
+}