Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/components/input/test/basic/input.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test.describe('input: basic', () => {
test.describe('input with overflow', () => {
test('should not have visual regressions', async ({ page }) => {
await page.setContent(`
<ion-input value="reallylonglonglonginputtoseetheedgesreallylonglonglonginputtoseetheedges"></ion-input>
<ion-input aria-label="Long Input" value="reallylonglonglonginputtoseetheedgesreallylonglonglonginputtoseetheedges"></ion-input>
`);
const input = page.locator('ion-input');
// Validates the display of an input where text extends off the edge of the component.
Expand All @@ -15,7 +15,7 @@ test.describe('input: basic', () => {
test.describe('input with placeholder', () => {
test('should not have visual regressions', async ({ page }) => {
await page.setContent(`
<ion-input placeholder="Placeholder"></ion-input>
<ion-input aria-label="Input with Placeholder" placeholder="Placeholder"></ion-input>
`);
const input = page.locator('ion-input');
// Validates the display of an input with a placeholder.
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion core/src/components/input/test/legacy/a11y/input.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test.describe('input: a11y', () => {
test('does not set a default aria-labelledby when there is not a neighboring ion-label', async ({ page, skip }) => {
skip.rtl();

await page.setContent('<ion-input></ion-input>');
await page.setContent('<ion-input legacy="true"></ion-input>');

const input = page.locator('ion-input > input');
const ariaLabelledBy = await input.getAttribute('aria-labelledby');
Expand Down
17 changes: 9 additions & 8 deletions core/src/components/input/test/legacy/basic/input.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item>
<ion-input value="reallylonglonglonginputtoseetheedgesreallylonglonglonginputtoseetheedges"></ion-input>
<ion-input value="reallylonglonglonginputtoseetheedgesreallylonglonglonginputtoseetheedges" legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand All @@ -25,7 +25,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item>
<ion-input placeholder="Placeholder"></ion-input>
<ion-input placeholder="Placeholder" legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand All @@ -42,7 +42,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item>
<ion-input value="Input disabled" disabled></ion-input>
<ion-input value="Input disabled" disabled legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand All @@ -59,7 +59,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item lines="full">
<ion-input placeholder="Full"></ion-input>
<ion-input placeholder="Full" legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand Down Expand Up @@ -88,7 +88,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item lines="inset">
<ion-input placeholder="Inset"></ion-input>
<ion-input placeholder="Inset" legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand Down Expand Up @@ -118,7 +118,7 @@ test.describe('input: basic', () => {
<ion-content>
<ion-list>
<ion-item lines="none">
<ion-input placeholder="None"></ion-input>
<ion-input placeholder="None" legacy="true"></ion-input>
</ion-item>
</ion-list>
</ion-content>
Expand Down Expand Up @@ -152,6 +152,7 @@ test.describe('input: basic', () => {
<ion-input
clear-input
value="reallylonglonglonginputtoseetheedgesreallylonglonglonginputtoseetheedges"
legacy="true"
></ion-input>
</ion-item>
</ion-list>
Expand All @@ -170,7 +171,7 @@ test.describe('input: clear button', () => {
});
test('should clear the input when pressed', async ({ page }) => {
await page.setContent(`
<ion-input value="abc" clear-input="true"></ion-input>
<ion-input value="abc" clear-input="true" legacy="true"></ion-input>
`);

const input = page.locator('ion-input');
Expand All @@ -191,7 +192,7 @@ test.describe('input: clear button', () => {
*/
test('should keep the input focused when the clear button is pressed', async ({ page }) => {
await page.setContent(`
<ion-input value="abc" clear-input="true"></ion-searchbar>
<ion-input value="abc" clear-input="true" legacy="true"></ion-input>
`);

const input = page.locator('ion-input');
Expand Down