From 69f48be4176831ba2485054a572d7df57e1723b7 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 14 Jun 2023 14:34:29 -0400 Subject: [PATCH 1/2] add failing test --- core/src/components/select/test/fill/select.e2e.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/core/src/components/select/test/fill/select.e2e.ts b/core/src/components/select/test/fill/select.e2e.ts index cfd282d7854..971c4ea798e 100644 --- a/core/src/components/select/test/fill/select.e2e.ts +++ b/core/src/components/select/test/fill/select.e2e.ts @@ -224,4 +224,17 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, co expect(await select.screenshot()).toMatchSnapshot(screenshot(`select-fill-outline-hidden-slotted-label`)); }); }); + test.describe(title('select: notch cutout'), () => { + test('notch cutout should be hidden when no label is passed', async ({ page }) => { + await page.setContent( + ` + + `, + config + ); + + const notchCutout = page.locator('ion-select .select-outline-notch'); + await expect(notchCutout).toBeHidden(); + }); + }); }); From a20fe92c872f2fe252ef000cf7b9044a12806f0c Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 14 Jun 2023 14:36:36 -0400 Subject: [PATCH 2/2] textarea notch cutout is hidden if no label passed --- core/src/components/select/select.scss | 3 ++- core/src/components/select/select.tsx | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/core/src/components/select/select.scss b/core/src/components/select/select.scss index abfc74d9e2b..7823d04bd70 100644 --- a/core/src/components/select/select.scss +++ b/core/src/components/select/select.scss @@ -316,7 +316,8 @@ button { * then the element should be hidden otherwise * there will be additional margins added. */ -.label-text-wrapper-hidden { +.label-text-wrapper-hidden, +.select-outline-notch-hidden { display: none; } diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx index 1fb799146fa..bdd705382e4 100644 --- a/core/src/components/select/select.tsx +++ b/core/src/components/select/select.tsx @@ -910,7 +910,12 @@ export class Select implements ComponentInterface { return [
-
+