From 3c1936fe4398f8be0b93f960832c076df27564e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=CC=81=20Rio?= Date: Tue, 2 Apr 2024 18:09:38 +0100 Subject: [PATCH 1/2] [fix](button): Fix icon size to the default size. --- core/src/components/button/button.ionic.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/src/components/button/button.ionic.scss b/core/src/components/button/button.ionic.scss index 111a7487cce..b41707a82c9 100644 --- a/core/src/components/button/button.ionic.scss +++ b/core/src/components/button/button.ionic.scss @@ -36,6 +36,12 @@ z-index: 1; } + ::slotted(ion-icon[slot="start"]), + ::slotted(ion-icon[slot="end"]), + ::slotted(ion-icon[slot="icon-only"]) { + font-size: px-to-rem(16); + } + ::slotted(ion-icon[slot="start"]) { @include margin-horizontal(null, px-to-rem(8)); } From d9e6be798b117653fd6009e6821434e6130bd30d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=CC=81=20Rio?= Date: Wed, 3 Apr 2024 11:20:33 +0100 Subject: [PATCH 2/2] fix(button): update into the expected behaviour. --- core/src/components/button/button.ionic.scss | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/core/src/components/button/button.ionic.scss b/core/src/components/button/button.ionic.scss index b41707a82c9..1215a55eda7 100644 --- a/core/src/components/button/button.ionic.scss +++ b/core/src/components/button/button.ionic.scss @@ -36,12 +36,6 @@ z-index: 1; } - ::slotted(ion-icon[slot="start"]), - ::slotted(ion-icon[slot="end"]), - ::slotted(ion-icon[slot="icon-only"]) { - font-size: px-to-rem(16); - } - ::slotted(ion-icon[slot="start"]) { @include margin-horizontal(null, px-to-rem(8)); } @@ -115,7 +109,18 @@ ::slotted(ion-icon[slot="start"]), ::slotted(ion-icon[slot="end"]), ::slotted(ion-icon[slot="icon-only"]) { - font-size: 1em; + font-size: px-to-rem(16); +} + +:host(.button-xsmall), +:host(.button-small), +:host(.button-large), +:host(.button-xlarge) { + ::slotted(ion-icon[slot="start"]), + ::slotted(ion-icon[slot="end"]), + ::slotted(ion-icon[slot="icon-only"]) { + font-size: 1em; + } } /* Button extra small */