Skip to content

Commit 28d6938

Browse files
committed
Remove test_enter_eventloop
1 parent 4f84388 commit 28d6938

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
132132
- name: Run the tests
133133
timeout-minutes: 10
134-
run: pytest -k test_enter_eventloop -W default -vv || pytest -k test_enter_eventloop --vv -W default --lf
134+
run: pytest -W default -vv || pytest --vv -W default --lf
135135

136136
test_miniumum_versions:
137137
name: Test Minimum Versions

ipykernel/kernelbase.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,6 @@ def advance_eventloop():
455455
return
456456
self.log.debug("Advancing eventloop %s", eventloop)
457457
try:
458-
foo
459458
eventloop(self)
460459
except KeyboardInterrupt:
461460
# Ctrl-C shouldn't crash the kernel

ipykernel/tests/test_kernel_direct.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -132,27 +132,6 @@ def __init__(self, bytes):
132132
await kernel.dispatch_shell(msg)
133133

134134

135-
async def test_enter_eventloop(kernel):
136-
kernel.eventloop = None
137-
kernel.enter_eventloop()
138-
kernel.eventloop = asyncio.get_running_loop()
139-
kernel.enter_eventloop()
140-
called = 0
141-
142-
def check_status():
143-
nonlocal called
144-
if called == 0:
145-
msg = kernel.session.msg("debug_request", {})
146-
kernel.msg_queue.put(msg)
147-
called += 1
148-
kernel.io_loop.call_later(0.001, check_status)
149-
150-
kernel.io_loop.call_later(0.001, check_status)
151-
kernel.start()
152-
while called < 2:
153-
await asyncio.sleep(0.1)
154-
155-
156135
async def test_do_one_iteration(kernel):
157136
kernel.msg_queue = asyncio.Queue()
158137
await kernel.do_one_iteration()

0 commit comments

Comments
 (0)