From dfb8c6138b349c47de9097bc10b5e1974fc3dafc Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Tue, 25 Oct 2022 08:48:13 -0500 Subject: [PATCH 1/2] fix failing test and update matrix --- .github/workflows/ci.yml | 4 ++-- ipykernel/tests/test_message_spec.py | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f67948158..ceee6b901 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,14 +20,14 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - python-version: ["3.7", "3.10"] + python-version: ["3.7", "3.11"] include: - os: windows-latest python-version: "3.9" - os: ubuntu-latest python-version: "pypy-3.7" - os: ubuntu-latest - python-version: "3.11-dev" + python-version: "3.10" - os: macos-latest python-version: "3.8" steps: diff --git a/ipykernel/tests/test_message_spec.py b/ipykernel/tests/test_message_spec.py index c2195c099..1833f7ddc 100644 --- a/ipykernel/tests/test_message_spec.py +++ b/ipykernel/tests/test_message_spec.py @@ -509,9 +509,7 @@ def test_connect_request(): flush_channels() msg = KC.session.msg("connect_request") KC.shell_channel.send(msg) - return msg["header"]["msg_id"] - - msg_id = KC.kernel_info() + msg_id = msg["header"]["msg_id"] reply = get_reply(KC, msg_id, TIMEOUT) validate_message(reply, "connect_reply", msg_id) From d86687b411aa085e859116cd8a91425735cb4326 Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Tue, 25 Oct 2022 08:59:17 -0500 Subject: [PATCH 2/2] handle no macos release yet --- .github/workflows/ci.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ceee6b901..1c27c1f51 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,14 +21,17 @@ jobs: matrix: os: [ubuntu-latest, windows-latest, macos-latest] python-version: ["3.7", "3.11"] + exclude: + - os: macos-latest + python-version: "3.11" # not yet available include: - os: windows-latest python-version: "3.9" - os: ubuntu-latest python-version: "pypy-3.7" - - os: ubuntu-latest - python-version: "3.10" - os: macos-latest + python-version: "3.10" + - os: ubuntu-latest python-version: "3.8" steps: - name: Checkout