From 1ce11570bbf346a7eb735d05cd23d2261e4035b1 Mon Sep 17 00:00:00 2001 From: M Bussonnier Date: Tue, 21 Jan 2025 16:37:32 +0100 Subject: [PATCH 1/2] More Informative assert This keep failing downstream in IPython. It's annoying. I hope this will give an idea as to why. Otherwise can we mark the test as xfail ? If not I"ll stop testing in IPython if I break ipykernel. --- tests/test_subshells.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_subshells.py b/tests/test_subshells.py index 141a3b7c4..9e1f1167b 100644 --- a/tests/test_subshells.py +++ b/tests/test_subshells.py @@ -166,7 +166,7 @@ def test_run_concurrently_sequence(are_subshells, overlap): delete_subshell_helper(kc, subshell_id) for reply in replies: - assert reply["content"]["status"] == "ok" + assert reply["content"]["status"] == "ok", reply @pytest.mark.parametrize("include_main_shell", [True, False]) From 21d64f87dffee92805f15117d8cca0b8b60f563a Mon Sep 17 00:00:00 2001 From: M Bussonnier Date: Mon, 27 Jan 2025 10:22:06 +0100 Subject: [PATCH 2/2] mark xfail --- tests/test_subshells.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test_subshells.py b/tests/test_subshells.py index 9e1f1167b..419a6bd3b 100644 --- a/tests/test_subshells.py +++ b/tests/test_subshells.py @@ -125,6 +125,9 @@ def test_thread_ids(): delete_subshell_helper(kc, subshell_id) +@pytest.mark.xfail( + strict=False, reason="this randomly fail and make downstream testing less useful" +) @pytest.mark.parametrize("are_subshells", [(False, True), (True, False), (True, True)]) @pytest.mark.parametrize("overlap", [True, False]) def test_run_concurrently_sequence(are_subshells, overlap):