From ca794bf0dc6be23bae53e53205ce0972baa073a4 Mon Sep 17 00:00:00 2001 From: Matthias Bussonnier Date: Fri, 7 Jan 2022 13:19:35 +0100 Subject: [PATCH] Remove impossible skipif. According to the dependencies in setup.py those will never be skipped. --- ipykernel/tests/test_async.py | 7 ------- ipykernel/tests/test_eventloop.py | 1 - ipykernel/tests/test_kernel.py | 4 ---- 3 files changed, 12 deletions(-) diff --git a/ipykernel/tests/test_async.py b/ipykernel/tests/test_async.py index d1f327bff..9727f8376 100644 --- a/ipykernel/tests/test_async.py +++ b/ipykernel/tests/test_async.py @@ -26,13 +26,7 @@ def teardown_function(): KM.shutdown_kernel(now=True) -skip_without_async = pytest.mark.skipif( - sys.version_info < (3, 5) or V(IPython.__version__) < V("7.0"), - reason="IPython >=7 with async/await required", -) - -@skip_without_async def test_async_await(): flush_channels(KC) msg_id, content = execute("import asyncio; await asyncio.sleep(0.1)", KC) @@ -40,7 +34,6 @@ def test_async_await(): @pytest.mark.parametrize("asynclib", ["asyncio", "trio", "curio"]) -@skip_without_async def test_async_interrupt(asynclib, request): try: __import__(asynclib) diff --git a/ipykernel/tests/test_eventloop.py b/ipykernel/tests/test_eventloop.py index 418c7d34b..1f25d97e2 100644 --- a/ipykernel/tests/test_eventloop.py +++ b/ipykernel/tests/test_eventloop.py @@ -28,7 +28,6 @@ def teardown(): """ -@pytest.mark.skipif(sys.version_info < (3, 5), reason="async/await syntax required") @pytest.mark.skipif(tornado.version_info < (5,), reason="only relevant on tornado 5") def test_asyncio_interrupt(): flush_channels(KC) diff --git a/ipykernel/tests/test_kernel.py b/ipykernel/tests/test_kernel.py index 5b9b26682..2e9d5cbbc 100644 --- a/ipykernel/tests/test_kernel.py +++ b/ipykernel/tests/test_kernel.py @@ -415,10 +415,6 @@ def test_interrupt_with_message(): validate_message(reply, 'execute_reply', msg_id) -@pytest.mark.skipif( - version.parse(IPython.__version__) < version.parse("7.14.0"), - reason="Need new IPython" -) def test_interrupt_during_pdb_set_trace(): """ The kernel exits after being interrupted while waiting in pdb.set_trace().