From be4c8cb08bb84a6cf9e5b592fa99f9b68842dbf3 Mon Sep 17 00:00:00 2001 From: Ed Snible Date: Wed, 22 May 2019 12:47:40 +0200 Subject: [PATCH 1/3] Missing quote in match example --- policy/v1beta1/cfg.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/policy/v1beta1/cfg.proto b/policy/v1beta1/cfg.proto index e70b2dcf55..9c5be91604 100644 --- a/policy/v1beta1/cfg.proto +++ b/policy/v1beta1/cfg.proto @@ -119,7 +119,7 @@ message Rule { // // * an empty match evaluates to `true` // * `true`, a boolean literal; a rule with this match will always be executed - // * `match(destination.service.host, "ratings.*)` selects any request targeting a service whose + // * `match(destination.service.host, "ratings.*")` selects any request targeting a service whose // name starts with "ratings" // * `attr1 == "20" && attr2 == "30"` logical AND, OR, and NOT are also available string match = 1; From d1eda252e2dbc372ed700110741f3effa7350b37 Mon Sep 17 00:00:00 2001 From: Ed Snible Date: Wed, 22 May 2019 12:47:40 +0200 Subject: [PATCH 2/3] Missing quote in match example --- policy/v1beta1/cfg.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/policy/v1beta1/cfg.proto b/policy/v1beta1/cfg.proto index c051b7eeec..1fdba49a87 100644 --- a/policy/v1beta1/cfg.proto +++ b/policy/v1beta1/cfg.proto @@ -119,7 +119,7 @@ message Rule { // // * an empty match evaluates to `true` // * `true`, a boolean literal; a rule with this match will always be executed - // * `match(destination.service.host, "ratings.*)` selects any request targeting a service whose + // * `match(destination.service.host, "ratings.*")` selects any request targeting a service whose // name starts with "ratings" // * `attr1 == "20" && attr2 == "30"` logical AND, OR, and NOT are also available string match = 1; From 4865e07c53d99d82b95652838b2e39459a40c783 Mon Sep 17 00:00:00 2001 From: Ed Snible Date: Tue, 11 Jun 2019 13:39:57 -0400 Subject: [PATCH 3/3] Generated files must be generated with 'make' --- policy/v1beta1/cfg.pb.go | 2 +- policy/v1beta1/istio.policy.v1beta1.pb.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/policy/v1beta1/cfg.pb.go b/policy/v1beta1/cfg.pb.go index 1cc9be4816..e61c368167 100644 --- a/policy/v1beta1/cfg.pb.go +++ b/policy/v1beta1/cfg.pb.go @@ -306,7 +306,7 @@ type Rule struct { // // * an empty match evaluates to `true` // * `true`, a boolean literal; a rule with this match will always be executed - // * `match(destination.service.host, "ratings.*)` selects any request targeting a service whose + // * `match(destination.service.host, "ratings.*")` selects any request targeting a service whose // name starts with "ratings" // * `attr1 == "20" && attr2 == "30"` logical AND, OR, and NOT are also available Match string `protobuf:"bytes,1,opt,name=match,proto3" json:"match,omitempty"` diff --git a/policy/v1beta1/istio.policy.v1beta1.pb.html b/policy/v1beta1/istio.policy.v1beta1.pb.html index eae62809d7..6b3dd9b471 100644 --- a/policy/v1beta1/istio.policy.v1beta1.pb.html +++ b/policy/v1beta1/istio.policy.v1beta1.pb.html @@ -1115,7 +1115,7 @@

Rule

  • an empty match evaluates to true
  • true, a boolean literal; a rule with this match will always be executed
  • -
  • match(destination.service.host, "ratings.*) selects any request targeting a service whose +
  • match(destination.service.host, "ratings.*") selects any request targeting a service whose name starts with “ratings”
  • attr1 == "20" && attr2 == "30" logical AND, OR, and NOT are also available