From 8845897c1aa76d3767825d0eada84da57e721c85 Mon Sep 17 00:00:00 2001 From: Kuat Yessenov Date: Wed, 20 Feb 2019 15:58:10 -0800 Subject: [PATCH 1/2] compiler barking Signed-off-by: Kuat Yessenov --- src/envoy/http/mixer/control_factory.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/envoy/http/mixer/control_factory.h b/src/envoy/http/mixer/control_factory.h index 0d5a840e620..d257b0172af 100644 --- a/src/envoy/http/mixer/control_factory.h +++ b/src/envoy/http/mixer/control_factory.h @@ -82,6 +82,7 @@ class ControlFactory : public Logger::Loggable { case istio::utils::Logger::Level::ERROR_: return ENVOY_LOG_CHECK_LEVEL(error); } + return false; } virtual void writeBuffer(istio::utils::Logger::Level level, From 486f89aa1b7721d7fe88ebdffc879c434f6f55fe Mon Sep 17 00:00:00 2001 From: Kuat Yessenov Date: Wed, 20 Feb 2019 17:00:25 -0800 Subject: [PATCH 2/2] piotrs fix Signed-off-by: Kuat Yessenov --- src/envoy/http/mixer/control_factory.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/envoy/http/mixer/control_factory.h b/src/envoy/http/mixer/control_factory.h index d257b0172af..fdc8a7c59d5 100644 --- a/src/envoy/http/mixer/control_factory.h +++ b/src/envoy/http/mixer/control_factory.h @@ -81,8 +81,9 @@ class ControlFactory : public Logger::Loggable { return ENVOY_LOG_CHECK_LEVEL(warn); case istio::utils::Logger::Level::ERROR_: return ENVOY_LOG_CHECK_LEVEL(error); + default: + NOT_REACHED_GCOVR_EXCL_LINE; } - return false; } virtual void writeBuffer(istio::utils::Logger::Level level,