From d8f84945dfb4b97b0ff25a652282b8008efce810 Mon Sep 17 00:00:00 2001 From: Lizan Zhou Date: Thu, 5 Jan 2017 14:50:22 -0800 Subject: [PATCH 1/2] Add bazel.rc for TSAN and ASAN --- tools/bazel.rc | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 tools/bazel.rc diff --git a/tools/bazel.rc b/tools/bazel.rc new file mode 100644 index 00000000000..532d23035bc --- /dev/null +++ b/tools/bazel.rc @@ -0,0 +1,50 @@ +# Address sanitizer +build:asan --strip=never +build:asan --copt -fsanitize=address +build:asan --copt -g +build:asan --copt -O1 +build:asan --copt -fno-omit-frame-pointer +build:asan --copt -Wno-error=maybe-uninitialized +build:asan --linkopt -fsanitize=address + +# Thread sanitizer +build:tsan --strip=never +build:tsan --copt -fsanitize=thread +build:tsan --copt -fPIE +build:tsan --copt -O2 +build:tsan --copt -g +build:tsan --copt -fno-omit-frame-pointer +build:tsan --copt -DGRPC_TSAN +build:tsan --linkopt -fsanitize=thread +build:tsan --linkopt -pie +# Use -Wl,-ltsan instead of -ltsan to make Bazel link libtsan before all other +# libs in particularly before -lpthread. This allows TSAN to pull in it's own +# version of -lpthread. +build:tsan --linkopt -Wl,-ltsan + +# Our default TSAN setup with -pie does not work with some linux versions (e.g., +# on Travis's trusty). See https://github.com/google/sanitizers/issues/503 +# So for TSAN on Travis we use gcc-5, which supports TSAN for non-pie binaries. +build:tsan_nopie --strip=never +build:tsan_nopie --copt -fsanitize=thread +build:tsan_nopie --copt -O2 +build:tsan_nopie --copt -g +build:tsan_nopie --copt -fno-omit-frame-pointer +build:tsan_nopie --copt -DGRPC_TSAN +build:tsan_nopie --linkopt -fsanitize=thread +build:tsan_nopie --linkopt -Wl,-ltsan + +# Explicitly instruct the compiler to use the gold linker. TSAN uses linker +# options (e.g., --push-state) that are only available in gold linker. On some +# linux versions (e.g., Travis's latest trusty), specifying -fsanitize=thread +# doesn't automatically use the gold linker. +build:tsan_nopie --linkopt -fuse-ld=gold + +# Release builds +build:release -c opt + +# Add compile option for all C++ files +build --cxxopt -Wnon-virtual-dtor +build --cxxopt -Wformat +build --cxxopt -Wformat-security + From 9b1e9769beea6771f90f2ec2cc9747c87deca60a Mon Sep 17 00:00:00 2001 From: Lizan Zhou Date: Thu, 5 Jan 2017 15:22:06 -0800 Subject: [PATCH 2/2] Add to .bazelrc --- .bazelrc | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++ tools/bazel.rc | 50 ---------------------------------------------- 2 files changed, 54 insertions(+), 50 deletions(-) delete mode 100644 tools/bazel.rc diff --git a/.bazelrc b/.bazelrc index f8725e6d9df..385e8437593 100644 --- a/.bazelrc +++ b/.bazelrc @@ -1,2 +1,56 @@ test --test_output=errors test --test_size_filters=-large,-enormous + +# Address sanitizer +build:asan --strip=never +build:asan --copt -fsanitize=address +build:asan --copt -g +build:asan --copt -O1 +build:asan --copt -fno-omit-frame-pointer +build:asan --copt -Wno-error=maybe-uninitialized +build:asan --linkopt -fsanitize=address +test:asan --test_tag_filters=-no_asan + +# Thread sanitizer +build:tsan --strip=never +build:tsan --copt -fsanitize=thread +build:tsan --copt -fPIE +build:tsan --copt -O2 +build:tsan --copt -g +build:tsan --copt -fno-omit-frame-pointer +build:tsan --copt -DGRPC_TSAN +build:tsan --linkopt -fsanitize=thread +build:tsan --linkopt -pie +# Use -Wl,-ltsan instead of -ltsan to make Bazel link libtsan before all other +# libs in particularly before -lpthread. This allows TSAN to pull in it's own +# version of -lpthread. +build:tsan --linkopt -Wl,-ltsan +test:tsan --test_tag_filters=-no_tsan + +# Our default TSAN setup with -pie does not work with some linux versions (e.g., +# on Travis's trusty). See https://github.com/google/sanitizers/issues/503 +# So for TSAN on Travis we use gcc-5, which supports TSAN for non-pie binaries. +build:tsan_nopie --strip=never +build:tsan_nopie --copt -fsanitize=thread +build:tsan_nopie --copt -O2 +build:tsan_nopie --copt -g +build:tsan_nopie --copt -fno-omit-frame-pointer +build:tsan_nopie --copt -DGRPC_TSAN +build:tsan_nopie --linkopt -fsanitize=thread +build:tsan_nopie --linkopt -Wl,-ltsan + +# Explicitly instruct the compiler to use the gold linker. TSAN uses linker +# options (e.g., --push-state) that are only available in gold linker. On some +# linux versions (e.g., Travis's latest trusty), specifying -fsanitize=thread +# doesn't automatically use the gold linker. +build:tsan_nopie --linkopt -fuse-ld=gold +test:tsan_nopie --test_tag_filters=-no_tsan + +# Release builds +build:release -c opt + +# Add compile option for all C++ files +build --cxxopt -Wnon-virtual-dtor +build --cxxopt -Wformat +build --cxxopt -Wformat-security + diff --git a/tools/bazel.rc b/tools/bazel.rc deleted file mode 100644 index 532d23035bc..00000000000 --- a/tools/bazel.rc +++ /dev/null @@ -1,50 +0,0 @@ -# Address sanitizer -build:asan --strip=never -build:asan --copt -fsanitize=address -build:asan --copt -g -build:asan --copt -O1 -build:asan --copt -fno-omit-frame-pointer -build:asan --copt -Wno-error=maybe-uninitialized -build:asan --linkopt -fsanitize=address - -# Thread sanitizer -build:tsan --strip=never -build:tsan --copt -fsanitize=thread -build:tsan --copt -fPIE -build:tsan --copt -O2 -build:tsan --copt -g -build:tsan --copt -fno-omit-frame-pointer -build:tsan --copt -DGRPC_TSAN -build:tsan --linkopt -fsanitize=thread -build:tsan --linkopt -pie -# Use -Wl,-ltsan instead of -ltsan to make Bazel link libtsan before all other -# libs in particularly before -lpthread. This allows TSAN to pull in it's own -# version of -lpthread. -build:tsan --linkopt -Wl,-ltsan - -# Our default TSAN setup with -pie does not work with some linux versions (e.g., -# on Travis's trusty). See https://github.com/google/sanitizers/issues/503 -# So for TSAN on Travis we use gcc-5, which supports TSAN for non-pie binaries. -build:tsan_nopie --strip=never -build:tsan_nopie --copt -fsanitize=thread -build:tsan_nopie --copt -O2 -build:tsan_nopie --copt -g -build:tsan_nopie --copt -fno-omit-frame-pointer -build:tsan_nopie --copt -DGRPC_TSAN -build:tsan_nopie --linkopt -fsanitize=thread -build:tsan_nopie --linkopt -Wl,-ltsan - -# Explicitly instruct the compiler to use the gold linker. TSAN uses linker -# options (e.g., --push-state) that are only available in gold linker. On some -# linux versions (e.g., Travis's latest trusty), specifying -fsanitize=thread -# doesn't automatically use the gold linker. -build:tsan_nopie --linkopt -fuse-ld=gold - -# Release builds -build:release -c opt - -# Add compile option for all C++ files -build --cxxopt -Wnon-virtual-dtor -build --cxxopt -Wformat -build --cxxopt -Wformat-security -