Improve extension management in save mode

Author: j4321

README.rst

@@ -117,9 +117,11 @@ Changelog
 
 - tkfilebrowser 2.2.0
     * Use babel instead of locale in order not to change the locale globally
-    * Speed up (a little) folder content display (only python >= 3.5)
+    * Speed up (a little) folder content display
     * Improve example: add comparison with default dialogs
     * Add select all on Ctrl+A if multiple selection is enabled
+    * Disable folder creation button if the user does not have write access
+    * Improve extension management in save mode
 
 - tkfilebrowser 2.1.1
     * Fix error if LOCAL_PATH does not exists or is not writtable
@@ -174,25 +176,62 @@ Example
     try:
         import tkinter as tk
         import tkinter.ttk as ttk
+        from tkinter import filedialog
     except ImportError:
         import Tkinter as tk
         import ttk
-    from tkfilebrowser import askopendirnames, asksaveasfilename
+        import tkFileDialog as filedialog
+    from tkfilebrowser import askopendirname, askopenfilenames, asksaveasfilename
+
 
     root = tk.Tk()
+
     style = ttk.Style(root)
     style.theme_use("clam")
 
-    def c_open():
-        rep = askopendirnames(parent=root)
+
+    def c_open_file_old():
+        rep = filedialog.askopenfilenames(parent=root, initialdir='/', initialfile='tmp',
+                                          filetypes=[("PNG", "*.png"), ("JPEG", "*.jpg"), ("All files", "*")])
+        print(rep)
+
+
+    def c_open_dir_old():
+        rep = filedialog.askdirectory(parent=root, initialdir='/tmp')
+        print(rep)
+
+
+    def c_save_old():
+        rep = filedialog.asksaveasfilename(parent=root, defaultextension=".png", initialdir='/tmp', initialfile='image.png',
+                                           filetypes=[("PNG", "*.png"), ("JPEG", "*.jpg"), ("All files", "*")])
         print(rep)
 
+
+    def c_open_file():
+        rep = askopenfilenames(parent=root, initialdir='/', initialfile='tmp',
+                               filetypes=[("Pictures", "*.png|*.jpg|*.JPG"), ("All files", "*")])
+        print(rep)
+
+
+    def c_open_dir():
+        rep = askopendirname(parent=root, initialdir='/', initialfile='tmp')
+        print(rep)
+
+
     def c_save():
-        rep = asksaveasfilename(parent=root, defaultext=".png",
+        rep = asksaveasfilename(parent=root, defaultext=".png", initialdir='/tmp', initialfile='image.png',
                                 filetypes=[("Pictures", "*.png|*.jpg|*.JPG"), ("All files", "*")])
         print(rep)
 
-    ttk.Button(root, text="Open folders", command=c_open).pack()
-    ttk.Button(root, text="Save file", command=c_save).pack()
+
+    ttk.Label(root, text='Default dialogs').grid(row=0, column=0, padx=4, pady=4, sticky='ew')
+    ttk.Label(root, text='tkfilebrowser dialogs').grid(row=0, column=1, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Open files", command=c_open_file_old).grid(row=1, column=0, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Open folder", command=c_open_dir_old).grid(row=2, column=0, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Save file", command=c_save_old).grid(row=3, column=0, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Open files", command=c_open_file).grid(row=1, column=1, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Open folder", command=c_open_dir).grid(row=2, column=1, padx=4, pady=4, sticky='ew')
+    ttk.Button(root, text="Save file", command=c_save).grid(row=3, column=1, padx=4, pady=4, sticky='ew')
 
     root.mainloop()
+

TODO

@@ -11,6 +11,8 @@ Changelog
     * Speed up (a little) folder content display
     * Improve example: add comparison with default dialogs
     * Add select all on Ctrl+A if multiple selection is enabled
+    * Disable folder creation button if the user does not have write access
+    * Improve extension management in save mode
 
 - tkfilebrowser 2.1.1
     * Fix error if LOCAL_PATH does not exists or is not writtable

changelog

@@ -105,6 +105,25 @@ def test_filebrowser_save(self):
         self.window.update()
         fb.validate()
         self.assertEqual(fb.get_result(), '/test.png')
+        fb = FileBrowser(self.window, initialdir="/", initialfile="test.png", mode="save",
+                         filetypes=[("PNG", '*.png|*.PNG'), ("JPG", '*.jpg|*.JPG'),
+                                    ('ALL', '*')])
+        self.window.update()
+        self.assertEqual(fb.entry.get(), "test.png")
+        fb.filetype.set('JPG')
+        self.window.update()
+        self.assertEqual(fb.entry.get(), "test.jpg")
+        fb.filetype.set('ALL')
+        self.window.update()
+        self.assertEqual(fb.entry.get(), "test.jpg")
+        fb.filetype.set('PNG')
+        self.window.update()
+        self.assertEqual(fb.entry.get(), "test.png")
+        fb.entry.delete(0, 'end')
+        fb.entry.insert(0, "test.JPG")
+        fb.filetype.set('JPG')
+        self.window.update()
+        self.assertEqual(fb.entry.get(), "test.JPG")
 
     def test_filebrowser_keybrowse(self):
         # --- openfile
@@ -246,6 +265,21 @@ def test_filebrowser_keybrowse(self):
         fb.event_generate('<Alt-Down>')
         self.window.update()
 
+    def test_filebowser_foldercreation(self):
+        fb = FileBrowser(self.window, initialdir="/",
+                         foldercreation=True)
+        self.window.update()
+        self.assertTrue(fb.b_new_folder.winfo_ismapped())
+        self.assertTrue('disabled' in fb.b_new_folder.state())
+        fb.display_folder(os.path.expanduser('~'))
+        self.window.update()
+        self.assertTrue(fb.b_new_folder.winfo_ismapped())
+        self.assertFalse('disabled' in fb.b_new_folder.state())
+        fb.left_tree.selection_clear()
+        fb.left_tree.selection_set('recent')
+        self.window.update()
+        self.assertFalse(fb.b_new_folder.winfo_ismapped())
+
     def test_filebrowser_sorting(self):
         fb = FileBrowser(self.window, initialdir="/",
                          multiple_selection=True, defaultext=".png",

tests/test_filebrowser.py

@@ -190,8 +190,12 @@ def __init__(self, parent, initialdir="", initialfile="", mode="openfile",
                                       width=w)
             b_filetype.grid(row=3, sticky="e", padx=10, pady=(4, 0))
             self.filetype.set(filetypes[0][0])
-            b_filetype.bind('<<ComboboxSelected>>',
-                            lambda e: self._change_filetype())
+            try:
+                self.filetype.trace_add('write', lambda *args: self._change_filetype())
+            except AttributeError:
+                self.filetype.trace('w', lambda *args: self._change_filetype())
+#            b_filetype.bind('<<ComboboxSelected>>',
+#                            lambda e: self._change_filetype())
         else:
             self.filetypes[""] = [""]
 
@@ -749,6 +753,12 @@ def _change_filetype(self):
             self.display_folder(self.history[self._hist_index])
         else:
             self._display_recents()
+        if self.mode == 'save':
+            name, ext = splitext(self.entry.get())
+            new_ext = self.filetypes[self.filetype.get()][0]
+            if new_ext and ext not in self.filetypes[self.filetype.get()]:
+                self.entry.delete(len(name), 'end')
+                self.entry.insert('end', new_ext)
 
     # ---  path completion in entries: key bindings
     def _down(self, event):

tkfilebrowser/filebrowser.py

@@ -138,4 +138,4 @@ def asksaveasfilename(parent=None, title=_("Save As"), **kwargs):
     """
     dialog = FileBrowser(parent, mode="save", title=title, **kwargs)
     dialog.wait_window(dialog)
-    return dialog.get_result()
+    return dialog.get_result()