From 99ba8eeff92b67d86c94e0f08980356e7bc324a7 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Thu, 16 Oct 2025 21:58:47 +0530 Subject: [PATCH 01/34] Save test archive results to results.txt file --- bin/test-changed-exercise | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/bin/test-changed-exercise b/bin/test-changed-exercise index debefeba3..e9f8ccec7 100755 --- a/bin/test-changed-exercise +++ b/bin/test-changed-exercise @@ -43,9 +43,16 @@ for dir in $changed_exercises; do echo "=== Running tests for $slug ===" echo "========================================" + results_path="$dir/build/results.txt" + mkdir -p "$(dirname "$results_path")" + if [[ $dir == exercises/practice/* ]]; then - ./exercises/gradlew -p exercises ":practice:$slug:test" + ./exercises/gradlew -p exercises ":practice:$slug:test" \ + > "$results_path" 2>&1 elif [[ $dir == exercises/concept/* ]]; then - ./exercises/gradlew -p exercises ":concept:$slug:test" + ./exercises/gradlew -p exercises ":concept:$slug:test" \ + > "$results_path" 2>&1 fi + + echo "Results saved to: $results_path" done From a741d9dbf61a34cc56ae63a24d641cacaf196a7c Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Thu, 16 Oct 2025 22:02:47 +0530 Subject: [PATCH 02/34] Change test results file format from JSON to TXT --- .github/workflows/java.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml index ad374a4f0..b2a34bce6 100644 --- a/.github/workflows/java.yml +++ b/.github/workflows/java.yml @@ -68,5 +68,5 @@ jobs: uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 with: name: test-results - path: exercises/**/build/results.json + path: exercises/**/build/results.txt if: failure() From a605da2ad088361f6caa7003f82006ad57a997cc Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Thu, 16 Oct 2025 22:03:18 +0530 Subject: [PATCH 03/34] Use tee to save test results to file --- bin/test-changed-exercise | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/bin/test-changed-exercise b/bin/test-changed-exercise index e9f8ccec7..6676d6883 100755 --- a/bin/test-changed-exercise +++ b/bin/test-changed-exercise @@ -47,11 +47,9 @@ for dir in $changed_exercises; do mkdir -p "$(dirname "$results_path")" if [[ $dir == exercises/practice/* ]]; then - ./exercises/gradlew -p exercises ":practice:$slug:test" \ - > "$results_path" 2>&1 + ./exercises/gradlew -p exercises ":practice:$slug:test" 2>&1 | tee "$results_path" elif [[ $dir == exercises/concept/* ]]; then - ./exercises/gradlew -p exercises ":concept:$slug:test" \ - > "$results_path" 2>&1 + ./exercises/gradlew -p exercises ":concept:$slug:test" 2>&1 | tee "$results_path" fi echo "Results saved to: $results_path" From 2edaf5940a48223a25c1ac22a89762492fdac71c Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Thu, 16 Oct 2025 22:19:36 +0530 Subject: [PATCH 04/34] Remove echo statement for results path --- bin/test-changed-exercise | 2 -- 1 file changed, 2 deletions(-) diff --git a/bin/test-changed-exercise b/bin/test-changed-exercise index 6676d6883..cbc684b79 100755 --- a/bin/test-changed-exercise +++ b/bin/test-changed-exercise @@ -51,6 +51,4 @@ for dir in $changed_exercises; do elif [[ $dir == exercises/concept/* ]]; then ./exercises/gradlew -p exercises ":concept:$slug:test" 2>&1 | tee "$results_path" fi - - echo "Results saved to: $results_path" done From c248f7946b8dc4c4a479a6d2e81c7f84d8c0a164 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:37:06 +0530 Subject: [PATCH 05/34] Add Checkstyle plugin to build.gradle Added Checkstyle plugin to the build configuration. --- exercises/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/exercises/build.gradle b/exercises/build.gradle index 734815214..fe6223aea 100644 --- a/exercises/build.gradle +++ b/exercises/build.gradle @@ -10,6 +10,7 @@ def generatedTestSourceDir = "build/gen/test/java" subprojects { + apply plugin: "checkstyle" // Add a task that copies test source files into a build directory. From 12fe5a20de3b65e1b77a9ce7f29e01548c1173b4 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:38:04 +0530 Subject: [PATCH 06/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 25bad1a0b..dbd6b2828 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -10,7 +10,7 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); @Test - @DisplayName("encode yes") + @DisplayName("") public void testEncodeYes() { assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); } From 03ecfa35596dfee320db50f50878f32cec749c7c Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:39:59 +0530 Subject: [PATCH 07/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index dbd6b2828..7cdbe3beb 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); + assertThat(affineCipher.encode(5, 7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 82f8fe5eb0096ee1bd3ff39cd730d6079008a8b0 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:53:30 +0530 Subject: [PATCH 08/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 7cdbe3beb..5d517b8c3 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -10,7 +10,7 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); @Test - @DisplayName("") + @DisplayName("encode yes"") public void testEncodeYes() { assertThat(affineCipher.encode(5, 7)).isEqualTo("xbt"); } From 88404c09ca110462a5651073bd3ea1d4881d5003 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:53:46 +0530 Subject: [PATCH 09/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 5d517b8c3..1f741170d 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -10,7 +10,7 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); @Test - @DisplayName("encode yes"") + @DisplayName("encode yes") public void testEncodeYes() { assertThat(affineCipher.encode(5, 7)).isEqualTo("xbt"); } From bf90559ac5b0531617c3ddc28b4419be2cb3824e Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 18:56:30 +0530 Subject: [PATCH 10/34] Add test for encoding 'yes' in AffineCipher --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 1f741170d..79ba4b8dc 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -9,6 +9,7 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); + @Test @DisplayName("encode yes") public void testEncodeYes() { From a390166096845812f438b8bd25a085c2b21efb0a Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 19:10:34 +0530 Subject: [PATCH 11/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 79ba4b8dc..e30b69a15 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -8,7 +8,6 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); - @Test @DisplayName("encode yes") From ce492d55129245778867ec9edb280f95369df140 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 19:45:22 +0530 Subject: [PATCH 12/34] Format AffineCipherTest.java for readability --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index e30b69a15..d0b816fc6 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -8,7 +8,8 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); - + + @Test @DisplayName("encode yes") public void testEncodeYes() { From d089106e7254c05c8545941c29cb75373d33a388 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 19:56:53 +0530 Subject: [PATCH 13/34] Remove unnecessary empty line in AffineCipherTest Removed an empty line in AffineCipherTest class. --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index d0b816fc6..1f741170d 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -9,7 +9,6 @@ public class AffineCipherTest { private AffineCipher affineCipher = new AffineCipher(); - @Test @DisplayName("encode yes") public void testEncodeYes() { From c4ed44841a5284d48c3ed8079dd88fe02cbd2008 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 19:57:48 +0530 Subject: [PATCH 14/34] Update test to encode string 'yes' with parameters --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 1f741170d..25bad1a0b 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode(5, 7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 5a57910a8b18b132465be44e418f1eb718728b5a Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:36:17 +0530 Subject: [PATCH 15/34] Update test for affineCipher.encode method --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 25bad1a0b..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 0a16c949a1ebf091f2f90891710f1ee2e21bc759 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:36:53 +0530 Subject: [PATCH 16/34] Update testEncodeYes to include additional parameter --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..25bad1a0b 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From aaedaebeb94ebc5a130016de327875d348d68742 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:50:13 +0530 Subject: [PATCH 17/34] Update test for affineCipher.encode method --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 25bad1a0b..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5, 7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 7edb41480bd844749b6ae026054b3b59e299b1f8 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:50:47 +0530 Subject: [PATCH 18/34] Update testEncodeYes to include additional parameter --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..d0f60a645 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 8dbb85f7eb29d03f0cc01d53a64a90a3d58f8496 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:58:10 +0530 Subject: [PATCH 19/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index d0f60a645..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 83e8edfc5427e42ce063277b0e1ecd50c037e4e5 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 20:58:45 +0530 Subject: [PATCH 20/34] Update testEncodeYes to include additional argument --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..d0f60a645 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 3884a087b8e110ac67d343793d119acb48a4b5b6 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 21:14:02 +0530 Subject: [PATCH 21/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index d0f60a645..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 449b4ff1b6d2e94e5ad16ff4d76ab702d08fda2a Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 21:14:35 +0530 Subject: [PATCH 22/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..d0f60a645 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From b2392c7db50ef127d148d54ad67a46c5adf555e9 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 21:21:23 +0530 Subject: [PATCH 23/34] Update AffineCipherTest.java --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index d0f60a645..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 1af38dee3e2eb068a86aba50d77e91f595eaab2b Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sat, 15 Nov 2025 21:22:02 +0530 Subject: [PATCH 24/34] Update testEncodeYes to include additional parameter --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..d0f60a645 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 506b09f38050d827506dc023bf9f9155876059b3 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 18:41:11 +0530 Subject: [PATCH 25/34] Update BlackjackTest.java --- exercises/concept/blackjack/src/test/java/BlackjackTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/blackjack/src/test/java/BlackjackTest.java b/exercises/concept/blackjack/src/test/java/BlackjackTest.java index 9943b3c23..53ed81b07 100644 --- a/exercises/concept/blackjack/src/test/java/BlackjackTest.java +++ b/exercises/concept/blackjack/src/test/java/BlackjackTest.java @@ -19,7 +19,7 @@ public void setUp() { @Tag("task:1") @DisplayName("The parseCard returns the correct numerical value for card name ace") public void correctParsesAce () { - assertThat(blackjack.parseCard("ace")).isEqualTo(11); + assertThat(blackjack.parseCard("a")).isEqualTo(11); } @Test From 644c36a4a4017cd57a0a0b8a55f34ac89fd583fd Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 18:41:54 +0530 Subject: [PATCH 26/34] Fix test case for verseOne in HouseTest --- exercises/practice/house/src/test/java/HouseTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/house/src/test/java/HouseTest.java b/exercises/practice/house/src/test/java/HouseTest.java index 4841a9d14..64965e261 100644 --- a/exercises/practice/house/src/test/java/HouseTest.java +++ b/exercises/practice/house/src/test/java/HouseTest.java @@ -17,7 +17,7 @@ public void setup() { @Test @DisplayName("verse one - the house that jack built") public void verseOne() { - assertThat(house.verse(1)).isEqualTo( + assertThat(house.verse(2)).isEqualTo( "This is the house that Jack built."); } From b2a19b524c10dc3ef966eb5326cd2e686b853418 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:12:33 +0530 Subject: [PATCH 27/34] Delete exercises/concept/blackjack/src/test/java/BlackjackTest.java --- .../src/test/java/BlackjackTest.java | 404 ------------------ 1 file changed, 404 deletions(-) delete mode 100644 exercises/concept/blackjack/src/test/java/BlackjackTest.java diff --git a/exercises/concept/blackjack/src/test/java/BlackjackTest.java b/exercises/concept/blackjack/src/test/java/BlackjackTest.java deleted file mode 100644 index 53ed81b07..000000000 --- a/exercises/concept/blackjack/src/test/java/BlackjackTest.java +++ /dev/null @@ -1,404 +0,0 @@ -import org.junit.jupiter.api.BeforeEach; -import org.junit.jupiter.api.DisplayName; -import org.junit.jupiter.api.Tag; -import org.junit.jupiter.api.Test; - -import static org.assertj.core.api.Assertions.*; - - -public class BlackjackTest { - - private Blackjack blackjack; - - @BeforeEach - public void setUp() { - blackjack = new Blackjack(); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name ace") - public void correctParsesAce () { - assertThat(blackjack.parseCard("a")).isEqualTo(11); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name two") - public void correctParsesTwo () { - assertThat(blackjack.parseCard("two")).isEqualTo(2); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name three") - public void correctParsesThree () { - assertThat(blackjack.parseCard("three")).isEqualTo(3); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name four") - public void correctParsesFour () { - assertThat(blackjack.parseCard("four")).isEqualTo(4); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name five") - public void correctParsesFive () { - assertThat(blackjack.parseCard("five")).isEqualTo(5); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name six") - public void correctParsesSix () { - assertThat(blackjack.parseCard("six")).isEqualTo(6); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name seven") - public void correctParsesSeven () { - assertThat(blackjack.parseCard("seven")).isEqualTo(7); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name eight") - public void correctParsesEight () { - assertThat(blackjack.parseCard("eight")).isEqualTo(8); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name nine") - public void correctParsesNine () { - assertThat(blackjack.parseCard("nine")).isEqualTo(9); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name ten") - public void correctParsesTen () { - assertThat(blackjack.parseCard("ten")).isEqualTo(10); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name jack") - public void correctParsesJack () { - assertThat(blackjack.parseCard("jack")).isEqualTo(10); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name queen") - public void correctParsesQueen () { - assertThat(blackjack.parseCard("queen")).isEqualTo(10); - } - - @Test - @Tag("task:1") - @DisplayName("The parseCard returns the correct numerical value for card name king") - public void correctParsesKing () { - assertThat(blackjack.parseCard("king")).isEqualTo(10); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns true with ten and ace") - public void blackjackWithTenAceSecond() { - assertThat(blackjack.isBlackjack("ten", "ace")).isEqualTo(true); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns true with jack and ace") - public void blackjackWithJackAceSecond() { - assertThat(blackjack.isBlackjack("jack", "ace")).isEqualTo(true); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns true with queen and ace") - public void blackjackWithQueenAceSecond() { - assertThat(blackjack.isBlackjack("queen", "ace")).isEqualTo(true); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns true with king and ace") - public void blackjackWithKingAceSecond() { - assertThat(blackjack.isBlackjack("king", "ace")).isEqualTo(true); - } - - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with ace and five") - public void noBlackjackWithFive() { - assertThat(blackjack.isBlackjack("ace", "five")).isEqualTo(false); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with ace and nine") - public void noBlackjackWithNine() { - assertThat(blackjack.isBlackjack("ace", "nine")).isEqualTo(false); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with ace and ace") - public void noBlackjackWithTwoAces() { - assertThat(blackjack.isBlackjack("ace", "ace")).isEqualTo(false); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with queen and jack") - public void noBlackjackWithTwoFigures() { - assertThat(blackjack.isBlackjack("queen", "jack")).isEqualTo(false); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with king and five") - public void noBlackjackWithKingAndFive() { - assertThat(blackjack.isBlackjack("king", "five")).isEqualTo(false); - } - - @Test - @Tag("task:2") - @DisplayName("The isBlackjack method returns false with eight and five") - public void noBlackjackWithEightAndFive() { - assertThat(blackjack.isBlackjack("eight", "five")).isEqualTo(false); - } - - @Test - @Tag("task:3") - @DisplayName("The firstTurn method returns strategy Split given ace-ace and dealer ace") - public void firstTurnWithAceAceAndDealerAce () { - assertThat(blackjack.firstTurn("ace", "ace", "ace")).isEqualTo("P"); - } - - @Test - @Tag("task:3") - @DisplayName("The firstTurn method returns strategy Stand given jack-ace and dealer ace") - public void firstTurnWithJackAceAndDealerAce () { - assertThat(blackjack.firstTurn("jack", "ace", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:3") - @DisplayName("The firstTurn method returns strategy Stand given ace-king and dealer queen") - public void firstTurnWithAceKingAndDealerQueen () { - assertThat(blackjack.firstTurn("ace", "king", "queen")).isEqualTo("S"); - } - - @Test - @Tag("task:3") - @DisplayName("The firstTurn method returns strategy Automatically Win given ten-ace and dealer five") - public void firstTurnWithTenAceAndDealerFive () { - assertThat(blackjack.firstTurn("ten", "ace", "five")).isEqualTo("W"); - } - - @Test - @Tag("task:3") - @DisplayName("The firstTurn method returns strategy Automatically Win given king-ace and dealer nine") - public void firstTurnWithKingAceAndDealerNine () { - assertThat(blackjack.firstTurn("king", "ace", "nine")).isEqualTo("W"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given jack-jack and dealer ace") - public void firstTurnWithJackJackAndDealerAce () { - assertThat(blackjack.firstTurn("jack", "jack", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given king-king and dealer ace") - public void firstTurnWithKingKingAndDealerAce () { - assertThat(blackjack.firstTurn("king", "king", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-two and dealer ace") - public void firstTurnWithTwoTwoAndDealerAce () { - assertThat(blackjack.firstTurn("two", "two", "ace")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given five-five and dealer ace") - public void firstTurnWithFiveFiveAndAce () { - assertThat(blackjack.firstTurn("five", "five", "ace")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given king-ten and dealer ace") - public void firstTurnWithKingTenAndDealerAce () { - assertThat(blackjack.firstTurn("king", "ten", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given nine-ten and dealer ace") - public void firstTurnWithNineTenAndDealerAce () { - assertThat(blackjack.firstTurn("nine", "ten", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given eight-ten and dealer ace") - public void firstTurnWithEightTenAndDealerAce () { - assertThat(blackjack.firstTurn("eight", "ten", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given king-seven and dealer ace") - public void firstTurnWithKingSevenAndDealerAce () { - assertThat(blackjack.firstTurn("king", "seven", "ace")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given six-ten and dealer six") - public void firstTurnWithSixTenAndDealerSix () { - assertThat(blackjack.firstTurn("six", "ten", "six")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given six-ten and dealer seven") - public void firstTurnWithSixTenAndDealerSeven () { - assertThat(blackjack.firstTurn("six", "ten", "seven")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given six-ten and dealer ace") - public void firstTurnWithSixTenAndDealerAce () { - assertThat(blackjack.firstTurn("six", "ten", "ace")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given five-ten and dealer six") - public void firstTurnWithFiveTenAndDealerSix () { - assertThat(blackjack.firstTurn("five", "ten", "six")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given five-ten and dealer seven") - public void firstTurnWithFiveTenAndDealerSeven () { - assertThat(blackjack.firstTurn("five", "ten", "seven")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given five-ten and dealer king") - public void firstTurnWithFiveTenAndDealerKing () { - assertThat(blackjack.firstTurn("five", "ten", "king")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given four-ten and dealer six") - public void firstTurnWithFourTenAndDealerSix () { - assertThat(blackjack.firstTurn("four", "ten", "six")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given four-ten and dealer seven") - public void firstTurnWithFourTenAndDealerSeven () { - assertThat(blackjack.firstTurn("four", "ten", "seven")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given four-ten and dealer queen") - public void firstTurnWithFourTenAndDealerQueen () { - assertThat(blackjack.firstTurn("four", "ten", "queen")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given three-ten and dealer six") - public void firstTurnWithThreeTenAndDealerSix () { - assertThat(blackjack.firstTurn("three", "ten", "six")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given three-ten and dealer seven") - public void firstTurnWithThreeTenAndDealerSeven () { - assertThat(blackjack.firstTurn("three", "ten", "seven")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given three-ten and dealer queen") - public void firstTurnWithThreeTenAndDealerQueen () { - assertThat(blackjack.firstTurn("three", "ten", "queen")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Stand given two-ten and dealer six") - public void firstTurnWithTwoTenAndDealerSix () { - assertThat(blackjack.firstTurn("two", "ten", "six")).isEqualTo("S"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-ten and dealer seven") - public void firstTurnWithTwoTenAndDealerSeven () { - assertThat(blackjack.firstTurn("two", "ten", "seven")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-ten and dealer queen") - public void firstTurnWithTwoTenAndDealerQueen () { - assertThat(blackjack.firstTurn("two", "ten", "queen")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-nine and dealer queen") - public void firstTurnWithTwoNineAndDealerQueen () { - assertThat(blackjack.firstTurn("two", "nine", "queen")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-eight and dealer two") - public void firstTurnWithTwoEightAndDealerTwo () { - assertThat(blackjack.firstTurn("two", "eight", "two")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-three and dealer queen") - public void firstTurnWithTwoThreeAndDealerQueen () { - assertThat(blackjack.firstTurn("two", "three", "queen")).isEqualTo("H"); - } - - @Test - @Tag("task:4") - @DisplayName("The firstTurn method returns strategy Hit given two-two and dealer five") - public void firstTurnWithTwoTwoAndDealerFive () { - assertThat(blackjack.firstTurn("two", "two", "five")).isEqualTo("H"); - } - -} From e826eff079d161b033ad4c0734bbf349702f3faa Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:13:23 +0530 Subject: [PATCH 28/34] Update test for AffineCipher to use new encode method --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index d0f60a645..41a96ae87 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -12,7 +12,7 @@ public class AffineCipherTest { @Test @DisplayName("encode yes") public void testEncodeYes() { - assertThat(affineCipher.encode("yes", 5,7)).isEqualTo("xbt"); + assertThat(affineCipher.encode("yes", 5)).isEqualTo("xbt"); } @Disabled("Remove to run test") From 073d0f72f88033d34fc7cd54ba676eea32be5a4d Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:14:22 +0530 Subject: [PATCH 29/34] Change knightIsAwake to false in test case --- .../src/test/java/AnnalynsInfiltrationTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/annalyns-infiltration/src/test/java/AnnalynsInfiltrationTest.java b/exercises/concept/annalyns-infiltration/src/test/java/AnnalynsInfiltrationTest.java index 7514451bf..45842a95e 100644 --- a/exercises/concept/annalyns-infiltration/src/test/java/AnnalynsInfiltrationTest.java +++ b/exercises/concept/annalyns-infiltration/src/test/java/AnnalynsInfiltrationTest.java @@ -10,7 +10,7 @@ public class AnnalynsInfiltrationTest { @Tag("task:1") @DisplayName("The canFastAttack method returns false when knight is awake") public void cannotExecuteFastAttackIfKnightIsAwake() { - boolean knightIsAwake = true; + boolean knightIsAwake = false; assertThat(AnnalynsInfiltration.canFastAttack(knightIsAwake)).isFalse(); } From 4b08f2f14141e47e388b03e8464b75140c340e85 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:23:28 +0530 Subject: [PATCH 30/34] Update verseTwo test to include additional parameter --- exercises/practice/house/src/test/java/HouseTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/house/src/test/java/HouseTest.java b/exercises/practice/house/src/test/java/HouseTest.java index 64965e261..c60ebccfa 100644 --- a/exercises/practice/house/src/test/java/HouseTest.java +++ b/exercises/practice/house/src/test/java/HouseTest.java @@ -25,7 +25,7 @@ public void verseOne() { @Test @DisplayName("verse two - the malt that lay") public void verseTwo() { - assertThat(house.verse(2)).isEqualTo( + assertThat(house.verse(2, 1)).isEqualTo( "This is the malt " + "that lay in the house that Jack built." ); From ed8480582719babddd2dd88a7b94f638ee265d4d Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:24:31 +0530 Subject: [PATCH 31/34] Clean up build.gradle by removing blank line Removed unnecessary blank line in build.gradle --- exercises/build.gradle | 1 - 1 file changed, 1 deletion(-) diff --git a/exercises/build.gradle b/exercises/build.gradle index fe6223aea..953615523 100644 --- a/exercises/build.gradle +++ b/exercises/build.gradle @@ -9,7 +9,6 @@ def generatedTestSourceDir = "build/gen/test/java" subprojects { - apply plugin: "checkstyle" From 6271e3c8faa7a969973222abcaf1537f8db53c5b Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:24:48 +0530 Subject: [PATCH 32/34] Add checkstyle plugin to subprojects --- exercises/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/build.gradle b/exercises/build.gradle index 953615523..734815214 100644 --- a/exercises/build.gradle +++ b/exercises/build.gradle @@ -9,7 +9,7 @@ def generatedTestSourceDir = "build/gen/test/java" subprojects { - + apply plugin: "checkstyle" // Add a task that copies test source files into a build directory. From 5bf46282f34fcde3dcb297e3676fcbddcbbf52b6 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:27:07 +0530 Subject: [PATCH 33/34] Update verseTwo test to use single argument --- exercises/practice/house/src/test/java/HouseTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/house/src/test/java/HouseTest.java b/exercises/practice/house/src/test/java/HouseTest.java index c60ebccfa..64965e261 100644 --- a/exercises/practice/house/src/test/java/HouseTest.java +++ b/exercises/practice/house/src/test/java/HouseTest.java @@ -25,7 +25,7 @@ public void verseOne() { @Test @DisplayName("verse two - the malt that lay") public void verseTwo() { - assertThat(house.verse(2, 1)).isEqualTo( + assertThat(house.verse(2)).isEqualTo( "This is the malt " + "that lay in the house that Jack built." ); From 15a606a28652efb6e39954aa4304c9e3319ccf72 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 16 Nov 2025 19:32:07 +0530 Subject: [PATCH 34/34] Add disabled test for encoding with spaces --- .../practice/affine-cipher/src/test/java/AffineCipherTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java index 41a96ae87..35587f8cc 100644 --- a/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java +++ b/exercises/practice/affine-cipher/src/test/java/AffineCipherTest.java @@ -29,6 +29,7 @@ public void testEncodeOMG() { assertThat(affineCipher.encode("OMG", 21, 3)).isEqualTo("lvz"); } + @Disabled("Remove to run test") @Test @DisplayName("encode O M G")