From 3fcd0eda417797a45ac1e7e726dc387ce83f6462 Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Fri, 4 Jun 2021 14:36:56 +0200 Subject: [PATCH 1/9] Add pull request template --- .github/pull_request_template.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..dbbd9cf6d6 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,22 @@ + + +# Short descriptions of changes + + + +# Context: Fixes an issue? + + + +# Status of this pull request + + + +## What is missing until this pull request can be merged? + + +## Checklist +- [] I verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) +- [] I tested my code and it does what I want +- [] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) +- [] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. From c9d6f53f8976d1e7b1355cd23ecb686b95dd301a Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Fri, 4 Jun 2021 14:39:53 +0200 Subject: [PATCH 2/9] Add space to checkboxes --- .github/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index dbbd9cf6d6..878341b69c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -16,7 +16,7 @@ ## Checklist -- [] I verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) -- [] I tested my code and it does what I want -- [] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) -- [] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. +- [ ] I verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) +- [ ] I tested my code and it does what I want +- [ ] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) +- [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. From 1a88b7245f0e8675ff6b9f34519b2bce0a5b0f4e Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Fri, 4 Jun 2021 14:43:00 +0200 Subject: [PATCH 3/9] Fix typo --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 878341b69c..9895ed9145 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,6 @@ -# Short descriptions of changes +# Short description of changes From a2be6932c5b82db4899204e154e468754b6ce35e Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Fri, 4 Jun 2021 14:46:56 +0200 Subject: [PATCH 4/9] Add documentation link --- .github/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9895ed9145..5f7c9edd51 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,6 +8,10 @@ +# Does this change need documentation? What needs to be documented and how? + + + # Status of this pull request From 7a91759c70874b0411e7b1c8241229149f312971 Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Sun, 13 Jun 2021 20:52:56 +0200 Subject: [PATCH 5/9] Don't use headlines but bold formating --- .github/pull_request_template.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5f7c9edd51..fe7455c447 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,22 +1,22 @@ -# Short description of changes +**Short description of changes** -# Context: Fixes an issue? +**Context: Fixes an issue?** -# Does this change need documentation? What needs to be documented and how? +**Does this change need documentation? What needs to be documented and how?** -# Status of this pull request +**Status of this pull request** -## What is missing until this pull request can be merged? +**What is missing until this pull request can be merged?** ## Checklist @@ -24,3 +24,4 @@ - [ ] I tested my code and it does what I want - [ ] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) - [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. +- [ ] I've filled all the content above From 014ca93d7f1e51dfde0328205604f3c207ab4625 Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Sun, 13 Jun 2021 22:00:06 +0200 Subject: [PATCH 6/9] Add more meaningful comment Co-authored-by: Christian Hoffmann --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fe7455c447..4a9c9cc619 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -20,6 +20,7 @@ ## Checklist + - [ ] I verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) - [ ] I tested my code and it does what I want - [ ] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) From 64f6854ffa261a3ff3f95015ffcbc76203f5688f Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Sun, 13 Jun 2021 22:01:34 +0200 Subject: [PATCH 7/9] Fix grammar Co-authored-by: Christian Hoffmann --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4a9c9cc619..0811842199 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -21,7 +21,7 @@ ## Checklist -- [ ] I verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) +- [ ] I've verified that this Pull Request follows the [general code principles](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#jamulus-projectsource-code-general-principles) - [ ] I tested my code and it does what I want - [ ] My code follows the [style guide](https://github.com/jamulussoftware/jamulus/blob/master/CONTRIBUTING.md#source-code-consistency) - [ ] I waited some time after this Pull Request was opened and all GitHub checks completed without errors. From 81e46b3bd1d2373fb32047f983e9b0f0a6a5345a Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Sun, 13 Jun 2021 22:01:42 +0200 Subject: [PATCH 8/9] Update .github/pull_request_template.md Co-authored-by: Christian Hoffmann --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0811842199..8c34967f13 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,7 +12,7 @@ -**Status of this pull request** +**Status of this Pull Request** From a800dae86d62fba58f1a214c536a85f49a78b6a8 Mon Sep 17 00:00:00 2001 From: ann0see <20726856+ann0see@users.noreply.github.com> Date: Tue, 15 Jun 2021 23:23:35 +0200 Subject: [PATCH 9/9] Update .github/pull_request_template.md Co-authored-by: Christian Hoffmann --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8c34967f13..03a2eb818a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ - + **Short description of changes**