From 1ec28dae3fafeeb387d83b673eb6e94708847caa Mon Sep 17 00:00:00 2001 From: Daniel Fortunov Date: Sun, 25 Oct 2020 17:20:21 +0000 Subject: [PATCH] Always return booleans from all retry_* methods ...rather than sometimes allowing a default return of `None` --- tenacity/retry.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tenacity/retry.py b/tenacity/retry.py index 8e4fab32..283e6202 100644 --- a/tenacity/retry.py +++ b/tenacity/retry.py @@ -67,6 +67,8 @@ def __init__(self, predicate): def __call__(self, retry_state): if retry_state.outcome.failed: return self.predicate(retry_state.outcome.exception()) + else: + return False class retry_if_exception_type(retry_if_exception): @@ -104,6 +106,8 @@ def __init__(self, predicate): def __call__(self, retry_state): if not retry_state.outcome.failed: return self.predicate(retry_state.outcome.result()) + else: + return False class retry_if_not_result(retry_base): @@ -116,6 +120,8 @@ def __init__(self, predicate): def __call__(self, retry_state): if not retry_state.outcome.failed: return not self.predicate(retry_state.outcome.result()) + else: + return False class retry_if_exception_message(retry_if_exception):