From bf3edc49a4ce04299565dd2d8897925a069fdc48 Mon Sep 17 00:00:00 2001 From: Jason Hu Date: Tue, 25 Sep 2018 03:05:44 -0700 Subject: [PATCH 1/2] Camera.software_version can get from Nest API --- nest/nest.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nest/nest.py b/nest/nest.py index aa515d8..120e769 100644 --- a/nest/nest.py +++ b/nest/nest.py @@ -1303,8 +1303,7 @@ def resource_id(self): @property def software_version(self): - raise NotImplementedError("No longer available in Nest API") - # return self._device['software_version'] + return self._device['software_version'] @property def spoken_where_id(self): From 436b7ef5b68fc297889b30269903a128e38bcec9 Mon Sep 17 00:00:00 2001 From: Matt Schmitt Date: Mon, 22 Oct 2018 00:27:00 -0400 Subject: [PATCH 2/2] Move software_version to Device object --- nest/nest.py | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/nest/nest.py b/nest/nest.py index 120e769..2bf7218 100644 --- a/nest/nest.py +++ b/nest/nest.py @@ -267,6 +267,10 @@ def device_id(self): def online(self): return self._device.get('is_online') + @property + def software_version(self): + return self._device.get('software_version') + @property def structure(self): if 'structure_id' in self._device: @@ -336,10 +340,6 @@ def _track(self): raise NotImplementedError("Deprecated Nest API") # return self._nest_api._status['track'][self._serial] - @property - def software_version(self): - return self._device.get('software_version') - @property def fan(self): # FIXME confirm this is the same as old havac_fan_state @@ -920,10 +920,6 @@ def smoke_sequence_number(self): def smoke_status(self): return self._device.get('smoke_alarm_state') - @property - def software_version(self): - return self._device.get('software_version') - @property def spoken_where_id(self): raise NotImplementedError("No longer available in Nest API") @@ -1301,10 +1297,6 @@ def resource_id(self): raise NotImplementedError("No longer available in Nest API") # return self._device['resource_id'] - @property - def software_version(self): - return self._device['software_version'] - @property def spoken_where_id(self): raise NotImplementedError("No longer available in Nest API")