Skip to content

Conversation

@hertschuh
Copy link
Collaborator

@hertschuh hertschuh commented Dec 5, 2025

Problem: the current approach creates two entries for TPU tests: one for pull_request and one for pull_request_review. But we only want one entry and one run of the tests.

Solution: add a new labeler workflow to label the PR on approval, which in turn triggers the TPU tests.

lso rename welcome workflow.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@hertschuh hertschuh marked this pull request as draft December 5, 2025 19:18
@hertschuh hertschuh changed the title Always use run_tpu_tests label to run the TPU tests. Always use run_tpu_tests label to run Gemma. Dec 5, 2025
@github-actions github-actions bot added the Gemma Gemma model specific issues label Dec 5, 2025
@hertschuh hertschuh changed the title Always use run_tpu_tests label to run Gemma. Always use run_tpu_tests label to run TPU tests. Dec 5, 2025
@hertschuh hertschuh removed the Gemma Gemma model specific issues label Dec 5, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.30%. Comparing base (7631c1a) to head (2ff0711).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21900      +/-   ##
==========================================
+ Coverage   76.27%   76.30%   +0.02%     
==========================================
  Files         579      579              
  Lines       59917    59950      +33     
  Branches     9403     9410       +7     
==========================================
+ Hits        45703    45744      +41     
+ Misses      11748    11738      -10     
- Partials     2466     2468       +2     
Flag Coverage Δ
keras 76.17% <ø> (+0.02%) ⬆️
keras-jax 62.16% <ø> (-0.55%) ⬇️
keras-numpy 57.35% <ø> (-0.02%) ⬇️
keras-openvino 34.27% <ø> (-0.02%) ⬇️
keras-torch 63.27% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Dec 5, 2025
@hertschuh hertschuh marked this pull request as ready for review December 5, 2025 19:29
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Dec 5, 2025
@hertschuh hertschuh changed the title Always use run_tpu_tests label to run TPU tests. Always use run_tpu_tests label to run Gemma tests. Dec 5, 2025
@github-actions github-actions bot added the Gemma Gemma model specific issues label Dec 5, 2025
@hertschuh hertschuh changed the title Always use run_tpu_tests label to run Gemma tests. Always use run_tpu_tests label to run TPU tests. Dec 5, 2025
@hertschuh hertschuh removed the Gemma Gemma model specific issues label Dec 5, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Dec 5, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
Problem: the current approach creates two entries for TPU tests: one for `pull_request` and one for `pull_request_review`. But we only want one entry and one run of the tests.

Solution: add a new labeler workflow to label the PR on approval, which in turn triggers the TPU tests.

Also rename `welcome` workflow.
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Dec 5, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 5, 2025
@hertschuh hertschuh marked this pull request as draft December 6, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants