Fix review findings

Author: kullingk

CMakeLists.txt

@@ -1,10 +1,10 @@
 CMAKE_MINIMUM_REQUIRED( VERSION 3.10 )
 PROJECT( cppcore )
-SET ( CPPCORE_VERSION_MAJOR 0 )
-SET ( CPPCORE_VERSION_MINOR 1 )
-SET ( CPPCORE_VERSION_PATCH 0 )
-SET ( CPPCORE_VERSION ${CPPCORE_VERSION_MAJOR}.${CPPCORE_VERSION_MINOR}.${CPPCORE_VERSION_PATCH} )
-SET ( PROJECT_VERSION "${CPPCORE_VERSION}" )
+SET( CPPCORE_VERSION_MAJOR 0 )
+SET( CPPCORE_VERSION_MINOR 1 )
+SET( CPPCORE_VERSION_PATCH 0 )
+SET( CPPCORE_VERSION ${CPPCORE_VERSION_MAJOR}.${CPPCORE_VERSION_MINOR}.${CPPCORE_VERSION_PATCH} )
+SET( PROJECT_VERSION "${CPPCORE_VERSION}" )
 
 find_package(GTest)
 
@@ -17,11 +17,11 @@ option( CPPCORE_BUILD_UNITTESTS
     "Build unit tests."
      ON 
 )
-option( CPPCORE_ASAN
+option(CPPCORE_ASAN
     "Enable AddressSanitizer."
     OFF
 )
-option( CPPCORE_UBSAN
+option(CPPCORE_UBSAN
     "Enable Undefined Behavior sanitizer."
     OFF
 )
@@ -38,9 +38,9 @@ link_directories(
     ${CMAKE_HOME_DIRECTORY}/
 )
 
-SET( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib )
-SET( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib )
-SET( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/bin )
+SET(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib )
+SET(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib )
+SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/bin )
 
 if( WIN32 AND NOT CYGWIN )
   set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc" )  # Force to always compile with W4
@@ -56,24 +56,24 @@ elseif ( "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" )
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long -g -pedantic -std=c++11")
 endif()
 
-IF (ASSIMP_ASAN)
+IF(CPPCORE_ASAN)
   MESSAGE(STATUS "AddressSanitizer enabled")
   SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address")
   SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address")
 ENDIF()
 
-IF (ASSIMP_UBSAN)
+IF(CPPCORE_UBSAN)
   MESSAGE(STATUS "Undefined Behavior sanitizer enabled")
-  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined -fno-sanitize-recover=all")
-  SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=undefined -fno-sanitize-recover=all")
+  SET(CMAKE_CXX_FLAGS   "${CMAKE_CXX_FLAGS} -fsanitize=undefined -fno-sanitize-recover=all")
+  SET(CMAKE_C_FLAGS     "${CMAKE_C_FLAGS} -fsanitize=undefined -fno-sanitize-recover=all")
 ENDIF()
 
-SET ( cppcore_src
+SET(cppcore_src
     code/cppcore.cpp
     include/cppcore/CPPCoreCommon.h
 )
 
-SET ( cppcore_common_src
+SET(cppcore_common_src
     include/cppcore/Common/Hash.h
     include/cppcore/Common/TStringBase.h
     include/cppcore/Common/TStringView.h
@@ -83,12 +83,12 @@ SET ( cppcore_common_src
     include/cppcore/Common/TOptional.h
 )
 
-SET( cppcore_random_src
+SET(cppcore_random_src
     include/cppcore/Random/RandomGenerator.h
     code/Random/RandomGenerator.cpp
 )
 
-SET ( cppcore_container_src
+SET(cppcore_container_src
     include/cppcore/Container/THashMap.h
     include/cppcore/Container/TArray.h
     include/cppcore/Container/TStaticArray.h
@@ -97,7 +97,7 @@ SET ( cppcore_container_src
     include/cppcore/Container/TStaticArray.h
 )
 
- SET ( cppcore_memory_src
+ SET(cppcore_memory_src
     include/cppcore/Memory/MemUtils.h
     include/cppcore/Memory/TDefaultAllocator.h
     include/cppcore/Memory/TStackAllocator.h

include/cppcore/Common/TStringBase.h

@@ -84,7 +84,7 @@ inline TStringBase<T>::~TStringBase() {
 
 template <class T>
 inline void TStringBase<T>::set(const T *ptr, size_t size) {
-    void reset();
+    reset();
     if (nullptr != ptr) {
         copyFrom(*this, ptr, size);
     }

include/cppcore/Common/TStringView.h

@@ -40,7 +40,7 @@ class TStringView {
     TStringView(const T *ptr, size_t len);
     ~TStringView() = default;
     size_t size() const;
-    T *data() const;
+    const T *data() const;
     bool isEmpty() const;
     const_iterator begin() const;
     const_iterator end() const;
@@ -63,7 +63,7 @@ inline size_t TStringView<T>::size() const {
 }
 
 template <class T>
-inline T *TStringView<T>::data() const {
+inline const T *TStringView<T>::data() const {
     return mPtr;
 }
 

test/common/HashTest.cpp

@@ -31,9 +31,6 @@ using namespace cppcore;
 class HashTest : public testing::Test {
 public:
     using UiHash = THash<unsigned int>;
-
-protected:
-    // empty
 };
 
 TEST_F( HashTest, CreateTest ) {

test/common/TOptionalTest.cpp

@@ -28,15 +28,15 @@ using namespace ::cppcore;
 class TOptionalTest : public ::testing::Test {};
 
 TEST_F(TOptionalTest, createInstance_success) {
-    constexpr int ValInt = 1;
+    constexpr int ValInt{1};
     TOptional<int> test_int(ValInt);
 
     EXPECT_FALSE(test_int.isInited());
     test_int.set(1);
     EXPECT_TRUE(test_int.isInited());
     EXPECT_EQ(test_int.value(), ValInt);
 
-    constexpr float ValFloat = 1.0f;
+    constexpr float ValFloat{1.0f};
     TOptional<float> test_float(ValFloat);
 
     EXPECT_FALSE(test_float.isInited());

test/common/TStringViewTest.cpp

@@ -34,8 +34,8 @@ TEST_F(TStringViewTest, createTest) {
     using StringView = TStringView<char>;
 
     StringView sv("this is a test", 14l);
-    StringView::const_iterator start = sv.begin();
-    StringView::const_iterator end = sv.end();
+    auto start = sv.begin();
+    auto end = sv.end();
 
     size_t d = distance(start, end);
     EXPECT_EQ(d, 14);
@@ -46,7 +46,7 @@ TEST_F(TStringViewTest, iterateTest) {
     constexpr char tag[] = "this is a test";
     StringView sv(tag, 14l);
     size_t i{0};
-    for (StringView::const_iterator it = sv.begin(); it != sv.end(); ++it) {
+    for (auto it = sv.begin(); it != sv.end(); ++it) {
         EXPECT_EQ(tag[i++], *it);
     }
 }