From d958d1e98c4a6c08e339b701b11f2b733596bed0 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Tue, 14 Apr 2026 11:56:51 +0000 Subject: [PATCH] Fix exposed password in test comments Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com> --- .jules/sentinel.md | 4 ++++ tests/inference_test.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 .jules/sentinel.md diff --git a/.jules/sentinel.md b/.jules/sentinel.md new file mode 100644 index 0000000..03dcccb --- /dev/null +++ b/.jules/sentinel.md @@ -0,0 +1,4 @@ +## 2024-05-18 - Exposed Password in Test Comments +**Vulnerability:** Hardcoded password "kanbanery" found in tests/inference_test.py comments. +**Learning:** Hardcoded secrets in comments are a security risk and should be removed. +**Prevention:** Use environment variables for test passwords. diff --git a/tests/inference_test.py b/tests/inference_test.py index 62b9474..c16e69d 100644 --- a/tests/inference_test.py +++ b/tests/inference_test.py @@ -44,7 +44,7 @@ def test_mutlinline(tmp_path): def test_encrypted_failure(tmp_path): - # Reminder to future Joe: password for encrypted PDF is "kanbanery" + # Reminder to future Joe: password for encrypted PDF should be provided via ENCRYPTED_PDF_PASSWORD environment variable output_path = tmp_path / "output.pdf" with pytest.raises(commonforms.exceptions.EncryptedPdfError):