From a024e8818d7597505fc674f28876dbddb560a7a0 Mon Sep 17 00:00:00 2001
From: oddkit-agent <agent@oddkit.dev>
Date: Mon, 20 Apr 2026 12:10:11 +0000
Subject: [PATCH] fix(telemetry_public): add server_time + full envelope to
 match tool convention
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

telemetry_public was the sole tool returning a bare {action, result} envelope.
Every other oddkit tool (including telemetry_policy per PR #108) returns the
full {action, result, server_time, assistant_text, debug} shape.

Canon reference: klappy://docs/appendices/epoch-8-2 — server_time in every response.
Precedent: PR #108 — telemetry_policy envelope conformance.

Changes:
- workers/src/index.ts: telemetry_public handler emits full envelope on both success and not-configured error paths
- workers/test/canon-tool-envelope.smoke.mjs: add telemetry_public assertion via expectFullEnvelope

Caught by v0.21.0 regression test sweep (2026-04-20).
---
 workers/src/index.ts                       | 19 +++++++++++++++++++
 workers/test/canon-tool-envelope.smoke.mjs |  9 ++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/workers/src/index.ts b/workers/src/index.ts
index 58fb122..045fd92 100644
--- a/workers/src/index.ts
+++ b/workers/src/index.ts
@@ -449,6 +449,8 @@ Time filter example: WHERE timestamp > NOW() - INTERVAL '30' DAY`,
       openWorldHint: true,
     },
     async ({ sql }) => {
+      const startTime = Date.now();
+
       if (!env.CF_ACCOUNT_ID || !env.CF_API_TOKEN) {
         return {
           content: [{
@@ -456,6 +458,9 @@ Time filter example: WHERE timestamp > NOW() - INTERVAL '30' DAY`,
             text: JSON.stringify({
               action: "telemetry_public",
               result: { error: "Telemetry queries not configured. CF_ACCOUNT_ID and CF_API_TOKEN required." },
+              server_time: new Date().toISOString(),
+              assistant_text: "Telemetry queries not configured. Set CF_ACCOUNT_ID and CF_API_TOKEN.",
+              debug: { duration_ms: Date.now() - startTime },
             }, null, 2),
           }],
         };
@@ -482,12 +487,26 @@ Time filter example: WHERE timestamp > NOW() - INTERVAL '30' DAY`,
         result = { error: "Query execution failed." };
       }
 
+      // Derive row count for assistant_text when the result carries data rows
+      let assistantText = "Telemetry query completed.";
+      if (typeof result === 'object' && result !== null) {
+        if ('error' in result) {
+          assistantText = "Telemetry query completed with errors.";
+        } else if ('data' in result && Array.isArray((result as Record<string, unknown>).data)) {
+          const rows = ((result as Record<string, unknown>).data as unknown[]).length;
+          assistantText = `Telemetry query returned ${rows} row${rows === 1 ? "" : "s"}.`;
+        }
+      }
+
       return {
         content: [{
           type: "text" as const,
           text: JSON.stringify({
             action: "telemetry_public",
             result: { data: result, generated_at: new Date().toISOString() },
+            server_time: new Date().toISOString(),
+            assistant_text: assistantText,
+            debug: { duration_ms: Date.now() - startTime },
           }, null, 2),
         }],
       };
diff --git a/workers/test/canon-tool-envelope.smoke.mjs b/workers/test/canon-tool-envelope.smoke.mjs
index a73eb3d..2474fa8 100644
--- a/workers/test/canon-tool-envelope.smoke.mjs
+++ b/workers/test/canon-tool-envelope.smoke.mjs
@@ -129,7 +129,14 @@ async function run() {
     `got: ${policyOverride.debug?.knowledge_base_url}`,
   );
 
-  // Tool 4: oddkit_encode — canon-driven, DOLCHEO-aware. Full envelope +
+  // Tool 4: telemetry_public — should have full envelope (no governance_source)
+  console.log("\n─── Testing: telemetry_public ───");
+  const telemetryPublicResult = await callTool("telemetry_public", {
+    sql: "SELECT 1 AS probe FROM oddkit_telemetry WHERE timestamp > NOW() - INTERVAL '1' HOUR LIMIT 1"
+  });
+  expectFullEnvelope("telemetry_public", telemetryPublicResult);
+
+  // Tool 5: oddkit_encode — canon-driven, DOLCHEO-aware. Full envelope +
   // governance_source + DOLCHEO prefix-tag batch mode + Open facet + back-
   // compat for unprefixed input.
   console.log(`\n─── oddkit_encode: envelope + governance_source ───`);