From 4ce5d1a8c729711ad127a6121600729b43979642 Mon Sep 17 00:00:00 2001
From: oddkit-agent <agent@oddkit.dev>
Date: Mon, 20 Apr 2026 12:28:28 +0000
Subject: [PATCH] fix(catalog): debug.generated_at is response time, not cached
 index timestamp
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

runCatalog returned index.generated_at as debug.generated_at — the cached
index build timestamp, not the current response time. Every other handler
uses new Date().toISOString() for this field.

Observed during v0.21.0 regression testing: debug.generated_at lagged
server_time by 48 minutes in a single response envelope.

Changes:
- workers/src/orchestrate.ts: runCatalog now sets debug.generated_at
  to new Date().toISOString(). Cached index build timestamp preserved
  as debug.index_built_at for consumers wanting the freshness signal.
- workers/test/canon-tool-envelope.smoke.mjs: add oddkit_catalog
  coverage. Bug slipped because catalog had no smoke assertion.

Canon references:
- klappy://canon/values/axioms (Axiom 1 — Reality Is Sovereign)
- klappy://canon/principles/consistency-same-pattern-every-time
- klappy://canon/principles/cache-fetches-and-parses (PR #125)
---
 workers/src/orchestrate.ts                 |  3 ++-
 workers/test/canon-tool-envelope.smoke.mjs | 22 ++++++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/workers/src/orchestrate.ts b/workers/src/orchestrate.ts
index 96c55b5..f2ba00b 100644
--- a/workers/src/orchestrate.ts
+++ b/workers/src/orchestrate.ts
@@ -1742,7 +1742,8 @@ async function runCatalog(
     debug: {
       knowledge_base_url: knowledgeBaseUrl,
       baseline_url: index.baseline_url,
-      generated_at: index.generated_at,
+      generated_at: new Date().toISOString(),   // response time — consistent with all other handlers
+      index_built_at: index.generated_at,       // preserve cache-freshness diagnostic under accurate name
       duration_ms: Date.now() - startMs,
     },
   };
diff --git a/workers/test/canon-tool-envelope.smoke.mjs b/workers/test/canon-tool-envelope.smoke.mjs
index 2474fa8..89ce465 100644
--- a/workers/test/canon-tool-envelope.smoke.mjs
+++ b/workers/test/canon-tool-envelope.smoke.mjs
@@ -603,6 +603,28 @@ async function run() {
     `got: met=${prereqPass.result?.prerequisites?.required_met} total=${prereqPass.result?.prerequisites?.required_total}`,
   );
 
+  // Tool: oddkit_catalog — debug.generated_at must be response time, not cached index time
+  console.log("\n─── Testing: oddkit_catalog ───");
+  const catalogResult = await callTool("oddkit", { action: "catalog", input: "recent" });
+  expectFullEnvelope("oddkit_catalog", catalogResult);
+
+  // debug.generated_at must be recent (under 60s) — not the cached index build time
+  const generatedAt = catalogResult.debug?.generated_at;
+  ok(`oddkit_catalog: debug.generated_at present`,
+    typeof generatedAt === "string" && /^\d{4}-\d{2}-\d{2}T/.test(generatedAt),
+    `got: ${generatedAt}`);
+  if (typeof generatedAt === "string") {
+    const ageMs = Date.now() - Date.parse(generatedAt);
+    ok(`oddkit_catalog: debug.generated_at is response time (age < 60s)`,
+      ageMs < 60_000 && ageMs >= 0,
+      `ageMs=${ageMs}`);
+  }
+
+  // index_built_at is the separate, accurately-named cache-freshness diagnostic
+  ok(`oddkit_catalog: debug.index_built_at present`,
+    typeof catalogResult.debug?.index_built_at === "string",
+    `got: ${catalogResult.debug?.index_built_at}`);
+
   console.log(`\n${passed} passed, ${failed} failed`);
   process.exit(failed === 0 ? 0 : 1);
 }