fix(build): Minor build optimizations#265
Merged
Merged
Conversation
Contributor
rhuss
commented
Jul 13, 2019
rhuss
commented
- Check that every generated file has been regenerated for CI
- No color when not on a tty which is useful for build logs
- Always do updates when called without args
- Removed -u option and added -c for codegen only (dep update, docs gen, formatting, license check)
knative-prow-robot
added
approved
rhuss
force-pushed
the
pr/build-fixes
branch
4 times, most recently
from
beeb8c6 to
1d79562
Compare
* Check that every generated file has been regenerated for CI * No color when not on a tty which is useful for build logs * Always do updates when called without args * Removed -u option and added -c for codegen only (dep update, docs gen, formatting, license check)
Contributor
Author
|
/retest pull-knative-client-integration-tests |
Contributor
Author
|
/retest |
navidshaikh
approved these changes
Jul 15, 2019
Contributor
Author
|
@maximilien could you have a quick look please and potentially merge ? This PR is about making the build more error proof so (e.g. update will be automatically called so that it can't be forgotten + the presubmit CI check also checks for license + docs now) |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Feb 14, 2020
…d-image Unset GOFLAGS and explicitly set required go flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.