From 56e2d73867aa033ac7c7a080145e10034b4ea503 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roland=20Hu=C3=9F?= Date: Tue, 16 Jul 2019 08:43:23 +0200 Subject: [PATCH 1/2] chore(revision): Remove bogus log message This showed up in the test run as single log message so I removed that. --- pkg/kn/commands/revision/revision_list_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/kn/commands/revision/revision_list_test.go b/pkg/kn/commands/revision/revision_list_test.go index 5425dfbfd1..1202f698c3 100644 --- a/pkg/kn/commands/revision/revision_list_test.go +++ b/pkg/kn/commands/revision/revision_list_test.go @@ -154,7 +154,6 @@ func TestRevisionListOneOutput(t *testing.T) { } func TestRevisionListOutputWithTwoRevName(t *testing.T) { - t.Log("verify by passing two revision name to get command") RevisionList := &v1alpha1.RevisionList{Items: []v1alpha1.Revision{}} _, _, err := fakeRevisionList([]string{"revision", "list", "foo-abcd", "bar-abcd"}, RevisionList) assert.ErrorContains(t, err, "'kn revision list' accepts maximum 1 argument") @@ -164,7 +163,7 @@ func createMockRevisionWithParams(name, svcName string) *v1alpha1.Revision { revision := &v1alpha1.Revision{ TypeMeta: metav1.TypeMeta{ Kind: "Revision", - APIVersion: "knative.dev/v1alpha1", + APIVersion: "serving.knative.dev/v1alpha1", }, ObjectMeta: metav1.ObjectMeta{ Name: name, From a8b3a68fd4a568d7c6cd0124bbed9719cbb1a0d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roland=20Hu=C3=9F?= Date: Wed, 17 Jul 2019 22:26:02 +0200 Subject: [PATCH 2/2] chore(revision): Revert back to wrong API group in test as its unrelated to this PR --- pkg/kn/commands/revision/revision_list_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kn/commands/revision/revision_list_test.go b/pkg/kn/commands/revision/revision_list_test.go index 1202f698c3..b02a038f90 100644 --- a/pkg/kn/commands/revision/revision_list_test.go +++ b/pkg/kn/commands/revision/revision_list_test.go @@ -163,7 +163,7 @@ func createMockRevisionWithParams(name, svcName string) *v1alpha1.Revision { revision := &v1alpha1.Revision{ TypeMeta: metav1.TypeMeta{ Kind: "Revision", - APIVersion: "serving.knative.dev/v1alpha1", + APIVersion: "knative.dev/v1alpha1", }, ObjectMeta: metav1.ObjectMeta{ Name: name,