From 69b644eaf18f7c5322a34c4d37b83e9a71d7cb61 Mon Sep 17 00:00:00 2001 From: sebgoa Date: Wed, 15 May 2019 11:30:06 +0200 Subject: [PATCH 1/4] add reference to custom DNS config --- docs/install/getting-started-knative-app.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/install/getting-started-knative-app.md b/docs/install/getting-started-knative-app.md index d6bcf5ce1c2..ed931d81005 100644 --- a/docs/install/getting-started-knative-app.md +++ b/docs/install/getting-started-knative-app.md @@ -135,6 +135,8 @@ assigned an external IP address. helloworld-go helloworld-go.default.example.com ``` + > Note: Knative installation use the default domain `example.com` if you want to use a custom DNS domain please refer to this [installation guide](./docs/serving/using-a-custom-domain.md). + You can also export the host URL as a variable using the following command: ```shell From 297aa8e4b662bd44f5dad0e9c1962d9e671ebf95 Mon Sep 17 00:00:00 2001 From: sebgoa Date: Mon, 20 May 2019 08:50:09 +0200 Subject: [PATCH 2/4] Update docs/install/getting-started-knative-app.md Co-Authored-By: Sam O'Dell <31352624+samodell@users.noreply.github.com> --- docs/install/getting-started-knative-app.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install/getting-started-knative-app.md b/docs/install/getting-started-knative-app.md index ed931d81005..09bbba4897f 100644 --- a/docs/install/getting-started-knative-app.md +++ b/docs/install/getting-started-knative-app.md @@ -135,7 +135,7 @@ assigned an external IP address. helloworld-go helloworld-go.default.example.com ``` - > Note: Knative installation use the default domain `example.com` if you want to use a custom DNS domain please refer to this [installation guide](./docs/serving/using-a-custom-domain.md). + > Note: Knative uses the default domain `example.com`. If you want to configure a custom DNS domain, see [Using a Custom Domain](./docs/serving/using-a-custom-domain.md). You can also export the host URL as a variable using the following command: From 10d0e507d52c50fa71ada912abb4d5d3529330f7 Mon Sep 17 00:00:00 2001 From: RichieEscarez Date: Tue, 21 May 2019 14:08:50 +0200 Subject: [PATCH 3/4] fix relative link --- docs/install/getting-started-knative-app.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install/getting-started-knative-app.md b/docs/install/getting-started-knative-app.md index 09bbba4897f..156670cc2c7 100644 --- a/docs/install/getting-started-knative-app.md +++ b/docs/install/getting-started-knative-app.md @@ -135,7 +135,7 @@ assigned an external IP address. helloworld-go helloworld-go.default.example.com ``` - > Note: Knative uses the default domain `example.com`. If you want to configure a custom DNS domain, see [Using a Custom Domain](./docs/serving/using-a-custom-domain.md). + > Note: By default Knative uses the `example.com` domain. To configure a custom DNS domain, see [Using a Custom Domain](../serving/using-a-custom-domain.md). You can also export the host URL as a variable using the following command: From 81762649bc19c92634a7cbb70282d95c0f078b47 Mon Sep 17 00:00:00 2001 From: RichieEscarez Date: Tue, 21 May 2019 14:12:14 +0200 Subject: [PATCH 4/4] Fix PR#1202 --- docs/install/getting-started-knative-app.md | 107 ++++++++++---------- 1 file changed, 54 insertions(+), 53 deletions(-) diff --git a/docs/install/getting-started-knative-app.md b/docs/install/getting-started-knative-app.md index 156670cc2c7..760e69386ae 100644 --- a/docs/install/getting-started-knative-app.md +++ b/docs/install/getting-started-knative-app.md @@ -93,85 +93,86 @@ assigned an external IP address. 1. To find the IP address for your service, enter: - ```shell - # In Knative 0.2.x and prior versions, the `knative-ingressgateway` service was used instead of `istio-ingressgateway`. - INGRESSGATEWAY=knative-ingressgateway + ```shell + # In Knative 0.2.x and prior versions, the `knative-ingressgateway` service was used instead of `istio-ingressgateway`. + INGRESSGATEWAY=knative-ingressgateway - # The use of `knative-ingressgateway` is deprecated in Knative v0.3.x. - # Use `istio-ingressgateway` instead, since `knative-ingressgateway` - # will be removed in Knative v0.4. - if kubectl get configmap config-istio -n knative-serving &> /dev/null; then - INGRESSGATEWAY=istio-ingressgateway - fi + # The use of `knative-ingressgateway` is deprecated in Knative v0.3.x. + # Use `istio-ingressgateway` instead, since `knative-ingressgateway` + # will be removed in Knative v0.4. + if kubectl get configmap config-istio -n knative-serving &> /dev/null; then + INGRESSGATEWAY=istio-ingressgateway + fi - kubectl get svc $INGRESSGATEWAY --namespace istio-system + kubectl get svc $INGRESSGATEWAY --namespace istio-system - NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE - istio-ingressgateway LoadBalancer 10.23.247.74 35.203.155.229 80:32380/TCP,443:32390/TCP,32400:32400/TCP 2d - ``` + NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE + istio-ingressgateway LoadBalancer 10.23.247.74 35.203.155.229 80:32380/TCP,443:32390/TCP,32400:32400/TCP 2d + ``` - Take note of the `EXTERNAL-IP` address. + Take note of the `EXTERNAL-IP` address. - You can also export the IP address as a variable with the following command: + You can also export the IP address as a variable with the following command: - ```shell - export IP_ADDRESS=$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.status.loadBalancer.ingress[0].ip}') - ``` + ```shell + export IP_ADDRESS=$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.status.loadBalancer.ingress[0].ip}') + ``` - > Note: if you use minikube or a baremetal cluster that has no external load - > balancer, the `EXTERNAL-IP` field is shown as ``. You need to use - > `NodeIP` and `NodePort` to interact your app instead. To get your app's - > `NodeIP` and `NodePort`, enter the following command: + > Note: If you use minikube or a baremetal cluster that has no external load + > balancer, the `EXTERNAL-IP` field is shown as ``. You need to use + > `NodeIP` and `NodePort` to interact your app instead. To get your app's + > `NodeIP` and `NodePort`, enter the following command: - ```shell - export IP_ADDRESS=$(kubectl get node --output 'jsonpath={.items[0].status.addresses[0].address}'):$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}') - ``` + ```shell + export IP_ADDRESS=$(kubectl get node --output 'jsonpath={.items[0].status.addresses[0].address}'):$(kubectl get svc $INGRESSGATEWAY --namespace istio-system --output 'jsonpath={.spec.ports[?(@.port==80)].nodePort}') + ``` 1. To find the host URL for your service, enter: - ```shell - kubectl get route helloworld-go --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain - NAME DOMAIN - helloworld-go helloworld-go.default.example.com - ``` + ```shell + kubectl get route helloworld-go --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain + NAME DOMAIN + helloworld-go helloworld-go.default.example.com + ``` - > Note: By default Knative uses the `example.com` domain. To configure a custom DNS domain, see [Using a Custom Domain](../serving/using-a-custom-domain.md). + > Note: By default, Knative uses the `example.com` domain. + > To configure a custom DNS domain, see [Using a Custom Domain](../serving/using-a-custom-domain.md). - You can also export the host URL as a variable using the following command: + You can also export the host URL as a variable using the following command: - ```shell - export HOST_URL=$(kubectl get route helloworld-go --output jsonpath='{.status.domain}') - ``` + ```shell + export HOST_URL=$(kubectl get route helloworld-go --output jsonpath='{.status.domain}') + ``` - If you changed the name from `helloworld-go` to something else when creating - the `.yaml` file, replace `helloworld-go` in the above commands with the name - you entered. + If you changed the name from `helloworld-go` to something else when creating + the `.yaml` file, replace `helloworld-go` in the above commands with the name + you entered. 1. Now you can make a request to your app and see the results. Replace `IP_ADDRESS` with the `EXTERNAL-IP` you wrote down, and replace `helloworld-go.default.example.com` with the domain returned in the previous step. - ```shell - curl -H "Host: helloworld-go.default.example.com" http://${IP_ADDRESS} - Hello World: Go Sample v1! - ``` + ```shell + curl -H "Host: helloworld-go.default.example.com" http://${IP_ADDRESS} + Hello World: Go Sample v1! + ``` - If you exported the host URL and IP address as variables in the previous - steps, you can use those variables to simplify your cURL request: + If you exported the host URL and IP address as variables in the previous + steps, you can use those variables to simplify your cURL request: - ```shell - curl -H "Host: ${HOST_URL}" http://${IP_ADDRESS} - Hello World: Go Sample v1! - ``` + ```shell + curl -H "Host: ${HOST_URL}" http://${IP_ADDRESS} + Hello World: Go Sample v1! + ``` - If you deployed your own app, you might want to customize this cURL request - to interact with your application. + If you deployed your own app, you might want to customize this cURL request + to interact with your application. - It can take a few seconds for Knative to scale up your application and return - a response. + It can take a few seconds for Knative to scale up your application and return + a response. - > Note: Add `-v` option to get more detail if the `curl` command failed. + > Note: Add `-v` option to get more detail if the `curl` command failed. You've successfully deployed your first application using Knative!