From 2a2364fb8e94176a1b02cf68a578e36f848cbdf7 Mon Sep 17 00:00:00 2001
From: "Bora M. Alper" <bora@boramalper.org>
Date: Thu, 27 May 2021 16:18:28 +0300
Subject: [PATCH] (eventing helloworld-python) add missing Broker and reformat
 YAML

Signed-off-by: Bora M. Alper <bora@boramalper.org>
---
 .../helloworld/helloworld-python/README.md    | 31 ++++++++++-------
 .../helloworld-python/sample-app.yaml         | 33 +++++++++++--------
 2 files changed, 39 insertions(+), 25 deletions(-)

diff --git a/docs/eventing/samples/helloworld/helloworld-python/README.md b/docs/eventing/samples/helloworld/helloworld-python/README.md
index 3b6f0f91491..d6667413db5 100644
--- a/docs/eventing/samples/helloworld/helloworld-python/README.md
+++ b/docs/eventing/samples/helloworld/helloworld-python/README.md
@@ -97,6 +97,13 @@ cd knative-docs/docs/eventing/samples/helloworld/helloworld-python
       labels:
            eventing.knative.dev/injection: enabled
     ---
+    # A default broker
+    apiVersion: eventing.knative.dev/v1
+    kind: Broker
+    metadata:
+      name: default
+      namespace: knative-samples
+    ---
     # Helloworld-python app deploment
     apiVersion: apps/v1
     kind: Deployment
@@ -119,18 +126,18 @@ cd knative-docs/docs/eventing/samples/helloworld/helloworld-python
     ---
     # Service that exposes helloworld-python app.
     # This will be the subscriber for the Trigger
-      kind: Service
-      apiVersion: v1
-      metadata:
-        name: helloworld-python
-        namespace: knative-samples
-      spec:
-        selector:
-          app: helloworld-python
-        ports:
-        - protocol: TCP
-          port: 80
-          targetPort: 8080
+    kind: Service
+    apiVersion: v1
+    metadata:
+      name: helloworld-python
+      namespace: knative-samples
+    spec:
+      selector:
+        app: helloworld-python
+      ports:
+      - protocol: TCP
+        port: 80
+        targetPort: 8080
     ---
     # Knative Eventing Trigger to trigger the helloworld-python service
     apiVersion: eventing.knative.dev/v1
diff --git a/docs/eventing/samples/helloworld/helloworld-python/sample-app.yaml b/docs/eventing/samples/helloworld/helloworld-python/sample-app.yaml
index 18fdcb95548..c95e1b7050d 100644
--- a/docs/eventing/samples/helloworld/helloworld-python/sample-app.yaml
+++ b/docs/eventing/samples/helloworld/helloworld-python/sample-app.yaml
@@ -6,6 +6,13 @@ metadata:
   labels:
        eventing.knative.dev/injection: enabled
 ---
+# A default broker
+apiVersion: eventing.knative.dev/v1
+kind: Broker
+metadata:
+  name: default
+  namespace: knative-samples
+---
 # Helloworld-go app deploment
 apiVersion: apps/v1
 kind: Deployment
@@ -23,23 +30,23 @@ spec:
     spec:
       containers:
         - name: helloworld-python
-          image: docker.io/axsauze/helloworld-python
+          image: docker.io/{username}/helloworld-python
           imagePullPolicy: IfNotPresent
 ---
 # Service that exposes helloworld-go app.
 # This will be the subscriber for the Trigger
-  kind: Service
-  apiVersion: v1
-  metadata:
-    name: helloworld-python
-    namespace: knative-samples
-  spec:
-    selector:
-      app: helloworld-python
-    ports:
-    - protocol: TCP
-      port: 80
-      targetPort: 8080
+apiVersion: v1
+kind: Service
+metadata:
+  name: helloworld-python
+  namespace: knative-samples
+spec:
+  selector:
+    app: helloworld-python
+  ports:
+  - protocol: TCP
+    port: 80
+    targetPort: 8080
 ---
 # Knative Eventing Trigger to trigger the helloworld-go service
 apiVersion: eventing.knative.dev/v1